From patchwork Mon Jan 18 09:58:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 8053961 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 989A29F859 for ; Mon, 18 Jan 2016 09:59:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CA7A4201BC for ; Mon, 18 Jan 2016 09:59:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2878200F0 for ; Mon, 18 Jan 2016 09:59:13 +0000 (UTC) Received: from localhost ([::1]:58565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aL6af-0001pF-9U for patchwork-qemu-devel@patchwork.kernel.org; Mon, 18 Jan 2016 04:59:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aL6aV-0001m4-B6 for qemu-devel@nongnu.org; Mon, 18 Jan 2016 04:59:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aL6aS-0004dB-44 for qemu-devel@nongnu.org; Mon, 18 Jan 2016 04:59:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aL6aR-0004cd-Uf for qemu-devel@nongnu.org; Mon, 18 Jan 2016 04:59:00 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 81B0DC09FAAB; Mon, 18 Jan 2016 09:58:59 +0000 (UTC) Received: from redhat.com (vpn1-7-233.ams2.redhat.com [10.36.7.233]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0I9wuma021155 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 18 Jan 2016 04:58:58 -0500 Date: Mon, 18 Jan 2016 09:58:55 +0000 From: "Daniel P. Berrange" To: Programmingkid Message-ID: <20160118095855.GC13395@redhat.com> References: <5525054B-A7E2-4538-9F68-9E606B85B1B7@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5525054B-A7E2-4538-9F68-9E606B85B1B7@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Peter Maydell , qemu-devel qemu-devel , Paolo Bonzini Subject: Re: [Qemu-devel] CMSG_SPACE() causing compile time error on Mac OS X X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Jan 17, 2016 at 05:23:44PM -0500, Programmingkid wrote: > I was wondering if you had problems compiling QEMU on Mac OS X recently. On my system, the channel-socket.c file causes this error: > > io/channel-socket.c: In function 'qio_channel_socket_writev': > io/channel-socket.c:497:18: error: variable-sized object may not be initialized > char control[CMSG_SPACE(sizeof(int) * SOCKET_MAX_FDS)] = { 0 }; Can you try applying this patch: Regards, Daniel Reviewed-By: John Arbuckle diff --git a/io/channel-socket.c b/io/channel-socket.c index eaa411f..bc117b1 100644 --- a/io/channel-socket.c +++ b/io/channel-socket.c @@ -493,10 +495,12 @@ static ssize_t qio_channel_socket_writev(QIOChannel *ioc, QIOChannelSocket *sioc = QIO_CHANNEL_SOCKET(ioc); ssize_t ret; struct msghdr msg = { NULL, }; - char control[CMSG_SPACE(sizeof(int) * SOCKET_MAX_FDS)] = { 0 }; + char control[CMSG_SPACE(sizeof(int) * SOCKET_MAX_FDS)]; size_t fdsize = sizeof(int) * nfds; struct cmsghdr *cmsg; + memset(control, 0, CMSG_SPACE(sizeof(int) * SOCKET_MAX_FDS)); + msg.msg_iov = (struct iovec *)iov; msg.msg_iovlen = niov;