Message ID | 20160126145946.GH4218@thinpad.lan.raisama.net (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 01/26/16 15:59, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > Additional code removal. > --- > hw/acpi/core.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/hw/acpi/core.c b/hw/acpi/core.c > index 21e113d..c2a5383 100644 > --- a/hw/acpi/core.c > +++ b/hw/acpi/core.c > @@ -309,14 +309,6 @@ out: > error_propagate(errp, err); > } > > -static bool acpi_table_builtin = false; > - > -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp) > -{ > - acpi_table_builtin = true; > - acpi_table_add(opts, errp); > -} > - > unsigned acpi_table_len(void *current) > { > struct acpi_table_header *hdr = current - sizeof(hdr->_length); > @@ -332,7 +324,7 @@ void *acpi_table_hdr(void *h) > > uint8_t *acpi_table_first(void) > { > - if (acpi_table_builtin || !acpi_tables) { > + if (!acpi_tables) { > return NULL; > } > return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE); > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
On Tue, 26 Jan 2016 12:59:46 -0200 Eduardo Habkost <ehabkost@redhat.com> wrote: > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > Additional code removal. > --- > hw/acpi/core.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/hw/acpi/core.c b/hw/acpi/core.c > index 21e113d..c2a5383 100644 > --- a/hw/acpi/core.c > +++ b/hw/acpi/core.c > @@ -309,14 +309,6 @@ out: > error_propagate(errp, err); > } > > -static bool acpi_table_builtin = false; > - > -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp) > -{ > - acpi_table_builtin = true; > - acpi_table_add(opts, errp); > -} > - > unsigned acpi_table_len(void *current) > { > struct acpi_table_header *hdr = current - sizeof(hdr->_length); > @@ -332,7 +324,7 @@ void *acpi_table_hdr(void *h) > > uint8_t *acpi_table_first(void) > { > - if (acpi_table_builtin || !acpi_tables) { > + if (!acpi_tables) { > return NULL; > } > return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
diff --git a/hw/acpi/core.c b/hw/acpi/core.c index 21e113d..c2a5383 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -309,14 +309,6 @@ out: error_propagate(errp, err); } -static bool acpi_table_builtin = false; - -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp) -{ - acpi_table_builtin = true; - acpi_table_add(opts, errp); -} - unsigned acpi_table_len(void *current) { struct acpi_table_header *hdr = current - sizeof(hdr->_length); @@ -332,7 +324,7 @@ void *acpi_table_hdr(void *h) uint8_t *acpi_table_first(void) { - if (acpi_table_builtin || !acpi_tables) { + if (!acpi_tables) { return NULL; } return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Additional code removal. --- hw/acpi/core.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)