From patchwork Thu Mar 10 09:52:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cornelia Huck X-Patchwork-Id: 8554671 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 07F3D9F7CA for ; Thu, 10 Mar 2016 09:53:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 314C8201BB for ; Thu, 10 Mar 2016 09:53:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F138B202FE for ; Thu, 10 Mar 2016 09:53:25 +0000 (UTC) Received: from localhost ([::1]:47280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adxHZ-00059i-GH for patchwork-qemu-devel@patchwork.kernel.org; Thu, 10 Mar 2016 04:53:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adxHR-00058b-6V for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:53:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adxHN-0006fQ-UQ for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:53:17 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:44891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adxHN-0006fA-Jn for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:53:13 -0500 Received: from localhost by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 Mar 2016 09:53:11 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 10 Mar 2016 09:53:09 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: cornelia.huck@de.ibm.com X-IBM-RcptTo: qemu-devel@nongnu.org Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 78F791B0805F for ; Thu, 10 Mar 2016 09:53:35 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2A9r95Q64880760 for ; Thu, 10 Mar 2016 09:53:09 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2A9r8Do004603 for ; Thu, 10 Mar 2016 02:53:08 -0700 Received: from gondolin (sig-9-79-9-138.uk.ibm.com [9.79.9.138]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2A9r4bI004486; Thu, 10 Mar 2016 02:53:06 -0700 Date: Thu, 10 Mar 2016 10:52:55 +0100 From: Cornelia Huck To: Thomas Huth Message-ID: <20160310105255.7780b6f1.cornelia.huck@de.ibm.com> In-Reply-To: <56E09BD2.9070803@redhat.com> References: <1457544488-5276-1-git-send-email-cornelia.huck@de.ibm.com> <1457544488-5276-5-git-send-email-cornelia.huck@de.ibm.com> <56E09BD2.9070803@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031009-0025-0000-0000-000009524AC6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 195.75.94.112 Cc: Matthew Rosato , agraf@suse.de, qemu-devel@nongnu.org, Markus Armbruster , borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com Subject: Re: [Qemu-devel] [PATCH for-2.6 04/10] s390x/cpu: Tolerate max_cpus X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 9 Mar 2016 22:55:30 +0100 Thomas Huth wrote: > While you're at it, it might be better to use g_new0 here instead > (see e.g. https://patchwork.ozlabs.org/patch/517377/ for a description > why this is better). Using g_new0 sounds sensible; but rather than respinning again, I'll just put the following on top: From 0a11840959f61861672858ce961fc34b71efa3be Mon Sep 17 00:00:00 2001 From: Cornelia Huck Date: Thu, 10 Mar 2016 10:19:46 +0100 Subject: [PATCH] s390x/cpu: use g_new0 Let's use g_new0 to allocate cpu_states. Suggested-by: Thomas Huth Signed-off-by: Cornelia Huck Reviewed-by: Thomas Huth --- hw/s390x/s390-virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c index 4ea9040..7c6e281 100644 --- a/hw/s390x/s390-virtio.c +++ b/hw/s390x/s390-virtio.c @@ -103,7 +103,7 @@ void s390_init_cpus(MachineState *machine) machine->cpu_model = "host"; } - cpu_states = g_malloc0(sizeof(S390CPU *) * max_cpus); + cpu_states = g_new0(S390CPU *, max_cpus); for (i = 0; i < max_cpus; i++) { name = g_strdup_printf("cpu[%i]", i);