From patchwork Mon Nov 7 05:08:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haozhong Zhang X-Patchwork-Id: 9414269 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 93B6560585 for ; Mon, 7 Nov 2016 05:10:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C8A228CE6 for ; Mon, 7 Nov 2016 05:10:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6BDE128DA8; Mon, 7 Nov 2016 05:10:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E66AB28CD4 for ; Mon, 7 Nov 2016 05:10:09 +0000 (UTC) Received: from localhost ([::1]:51178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3cC9-00065g-5a for patchwork-qemu-devel@patchwork.kernel.org; Mon, 07 Nov 2016 00:10:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3cBj-000650-11 for qemu-devel@nongnu.org; Mon, 07 Nov 2016 00:09:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3cBf-0001Ww-T4 for qemu-devel@nongnu.org; Mon, 07 Nov 2016 00:09:42 -0500 Received: from mga02.intel.com ([134.134.136.20]:6606) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3cBf-0001Ul-L2 for qemu-devel@nongnu.org; Mon, 07 Nov 2016 00:09:39 -0500 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 06 Nov 2016 21:09:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,604,1473145200"; d="scan'208";a="458347" Received: from hz-desktop.sh.intel.com (HELO localhost) ([10.239.159.148]) by orsmga002.jf.intel.com with ESMTP; 06 Nov 2016 21:09:35 -0800 From: Haozhong Zhang To: qemu-devel@nongnu.org Date: Mon, 7 Nov 2016 13:08:57 +0800 Message-Id: <20161107050859.31058-2-haozhong.zhang@intel.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20161107050859.31058-1-haozhong.zhang@intel.com> References: <20161107050859.31058-1-haozhong.zhang@intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.20 Subject: [Qemu-devel] [PATCH 1/3] exec.c: add comment for errors of get_file_size() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haozhong Zhang , Eduardo Habkost , Peter Crosthwaite , Paolo Bonzini , Igor Mammedov , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Indicate that not stopping on get_file_size() errors in file_ram_alloc() is on purpose and not a mistake. Signed-off-by: Haozhong Zhang --- exec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/exec.c b/exec.c index 3d867f1..68b0c92 100644 --- a/exec.c +++ b/exec.c @@ -1314,6 +1314,9 @@ static void *file_ram_alloc(RAMBlock *block, } #endif + /* If QEMU fails to get the backend file size, i.e. file_size < 0, + * it will treat the file as non-empty and not truncate it. + */ file_size = get_file_size(fd); if (memory < block->page_size) {