| Message ID | 20170711163748.17817-4-el13635@mail.ntua.gr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote: > Now that bdrv_truncate is passed to bs->file by default, remove the > callback from block/blkdebug.c and set is_filter to true. This also automatically gives blkdebug access to bdrv_probe_blocksizes bdrv_probe_geometry bdrv_has_zero_init bdrv_get_info all of which make sense to me. > > Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr> > --- > block/blkdebug.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
On Tue, Jul 11, 2017 at 07:37:47PM +0300, Manos Pitsidianakis wrote: > Now that bdrv_truncate is passed to bs->file by default, remove the > callback from block/blkdebug.c and set is_filter to true. > > Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr> > --- > block/blkdebug.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/block/blkdebug.c b/block/blkdebug.c index b25856c4..91ffd1fe 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -821,11 +821,6 @@ static int64_t blkdebug_getlength(BlockDriverState *bs) return bdrv_getlength(bs->file->bs); } -static int blkdebug_truncate(BlockDriverState *bs, int64_t offset, Error **errp) -{ - return bdrv_truncate(bs->file, offset, errp); -} - static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) { BDRVBlkdebugState *s = bs->opaque; @@ -908,6 +903,7 @@ static BlockDriver bdrv_blkdebug = { .format_name = "blkdebug", .protocol_name = "blkdebug", .instance_size = sizeof(BDRVBlkdebugState), + .is_filter = true, .bdrv_parse_filename = blkdebug_parse_filename, .bdrv_file_open = blkdebug_open, @@ -916,7 +912,6 @@ static BlockDriver bdrv_blkdebug = { .bdrv_child_perm = bdrv_filter_default_perms, .bdrv_getlength = blkdebug_getlength, - .bdrv_truncate = blkdebug_truncate, .bdrv_refresh_filename = blkdebug_refresh_filename, .bdrv_refresh_limits = blkdebug_refresh_limits,
Now that bdrv_truncate is passed to bs->file by default, remove the callback from block/blkdebug.c and set is_filter to true. Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr> --- block/blkdebug.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)