diff mbox

[3/5] qemu-iotests: remove commented out variables

Message ID 20170727120210.6943-4-crosa@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Cleber Rosa July 27, 2017, 12:02 p.m. UTC
The variables FULL_MKFS_OPTIONS and FULL_MOUNT_OPTIONS are commented
out, never used, and even refer to functions that do exist.  The last
time these were touched was around 8 years ago, so I guess it's safe
to assume outputting such information on test execution is still on the
radar.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/qemu-iotests/check | 4 ----
 1 file changed, 4 deletions(-)

Comments

Stefan Hajnoczi July 28, 2017, 12:15 p.m. UTC | #1
On Thu, Jul 27, 2017 at 08:02:08AM -0400, Cleber Rosa wrote:
> The variables FULL_MKFS_OPTIONS and FULL_MOUNT_OPTIONS are commented
> out, never used, and even refer to functions that do exist.  The last
> time these were touched was around 8 years ago, so I guess it's safe
> to assume outputting such information on test execution is still on the
> radar.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  tests/qemu-iotests/check | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff mbox

Patch

diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 7a2e0d0..437ef65 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -229,8 +229,6 @@  rm -f check.full
 
 FULL_IMGFMT_DETAILS=`_full_imgfmt_details`
 FULL_HOST_DETAILS=`_full_platform_details`
-#FULL_MKFS_OPTIONS=`_scratch_mkfs_options`
-#FULL_MOUNT_OPTIONS=`_scratch_mount_options`
 
 cat <<EOF
 QEMU          -- "$QEMU_PROG" $QEMU_OPTIONS
@@ -244,8 +242,6 @@  TEST_DIR      -- $TEST_DIR
 SOCKET_SCM_HELPER -- $SOCKET_SCM_HELPER
 
 EOF
-#MKFS_OPTIONS  -- $FULL_MKFS_OPTIONS
-#MOUNT_OPTIONS -- $FULL_MOUNT_OPTIONS
 
 seq="check"