From patchwork Fri Aug 25 13:23:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manos Pitsidianakis X-Patchwork-Id: 9922023 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 972D0602BD for ; Fri, 25 Aug 2017 13:33:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A4F728179 for ; Fri, 25 Aug 2017 13:33:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7E038281C3; Fri, 25 Aug 2017 13:33:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B791628179 for ; Fri, 25 Aug 2017 13:33:22 +0000 (UTC) Received: from localhost ([::1]:53351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlEjh-0005ZV-TL for patchwork-qemu-devel@patchwork.kernel.org; Fri, 25 Aug 2017 09:33:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlEbV-00077u-JM for qemu-devel@nongnu.org; Fri, 25 Aug 2017 09:24:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlEbS-0003SX-CK for qemu-devel@nongnu.org; Fri, 25 Aug 2017 09:24:53 -0400 Received: from smtp1.ntua.gr ([2001:648:2000:de::183]:40258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlEbO-0003PO-8E; Fri, 25 Aug 2017 09:24:46 -0400 Received: from mail.ntua.gr (carp0.noc.ntua.gr [147.102.222.60]) (authenticated bits=0) by smtp1.ntua.gr (8.15.2/8.15.2) with ESMTPSA id v7PDOD6x025245 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Aug 2017 16:24:13 +0300 (EEST) (envelope-from el13635@mail.ntua.gr) X-Authentication-Warning: smtp1.ntua.gr: Host carp0.noc.ntua.gr [147.102.222.60] claimed to be mail.ntua.gr From: Manos Pitsidianakis To: qemu-devel Date: Fri, 25 Aug 2017 16:23:31 +0300 Message-Id: <20170825132332.6734-7-el13635@mail.ntua.gr> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170825132332.6734-1-el13635@mail.ntua.gr> References: <20170825132332.6734-1-el13635@mail.ntua.gr> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:648:2000:de::183 Subject: [Qemu-devel] [PATCH v3 6/7] block: remove BlockBackendPublic X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , Stefan Hajnoczi , qemu-block Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP All BlockBackend level throttling (via the implicit throttle filter node) is done in block/block-backend.c and block/throttle-groups.c doesn't know about BlockBackends anymore. Since BlockBackendPublic is not needed anymore, remove it. Reviewed-by: Alberto Garcia Signed-off-by: Manos Pitsidianakis --- include/sysemu/block-backend.h | 12 +----------- block/block-backend.c | 43 +++++++++++++++++++----------------------- block/qapi.c | 4 ++-- blockdev.c | 4 ++-- 4 files changed, 24 insertions(+), 39 deletions(-) diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h index 4a7ca53685..a05d75fa5f 100644 --- a/include/sysemu/block-backend.h +++ b/include/sysemu/block-backend.h @@ -68,14 +68,6 @@ typedef struct BlockDevOps { void (*drained_end)(void *opaque); } BlockDevOps; -/* This struct is embedded in (the private) BlockBackend struct and contains - * fields that must be public. This is in particular for QLIST_ENTRY() and - * friends so that BlockBackends can be kept in lists outside block-backend.c - * */ -typedef struct BlockBackendPublic { - BlockDriverState *throttle_node; -} BlockBackendPublic; - BlockBackend *blk_new(uint64_t perm, uint64_t shared_perm); BlockBackend *blk_new_open(const char *filename, const char *reference, QDict *options, int flags, Error **errp); @@ -90,9 +82,7 @@ BlockBackend *blk_all_next(BlockBackend *blk); bool monitor_add_blk(BlockBackend *blk, const char *name, Error **errp); void monitor_remove_blk(BlockBackend *blk); -BlockBackendPublic *blk_get_public(BlockBackend *blk); -BlockBackend *blk_by_public(BlockBackendPublic *public); - +BlockDriverState *blk_get_throttle_node(BlockBackend *blk); BlockDriverState *blk_bs(BlockBackend *blk); void blk_remove_bs(BlockBackend *blk); int blk_insert_bs(BlockBackend *blk, BlockDriverState *bs, Error **errp); diff --git a/block/block-backend.c b/block/block-backend.c index 65f458ce8f..c70e1c5cf7 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -37,7 +37,10 @@ struct BlockBackend { DriveInfo *legacy_dinfo; /* null unless created by drive_new() */ QTAILQ_ENTRY(BlockBackend) link; /* for block_backends */ QTAILQ_ENTRY(BlockBackend) monitor_link; /* for monitor_block_backends */ - BlockBackendPublic public; + + /* implicit throttle filter node for backwards compatibility with legacy + * throttling commands */ + BlockDriverState *throttle_node; void *dev; /* attached device model, if any */ bool legacy_dev; /* true if dev is not a DeviceState */ @@ -320,7 +323,7 @@ static void blk_delete(BlockBackend *blk) assert(!blk->refcnt); assert(!blk->name); assert(!blk->dev); - if (blk->public.throttle_node) { + if (blk->throttle_node) { blk_io_limits_disable(blk); } if (blk->root) { @@ -615,19 +618,11 @@ BlockBackend *blk_by_legacy_dinfo(DriveInfo *dinfo) } /* - * Returns a pointer to the publicly accessible fields of @blk. + * Returns the throttle_node field of @blk. */ -BlockBackendPublic *blk_get_public(BlockBackend *blk) +BlockDriverState *blk_get_throttle_node(BlockBackend *blk) { - return &blk->public; -} - -/* - * Returns a BlockBackend given the associated @public fields. - */ -BlockBackend *blk_by_public(BlockBackendPublic *public) -{ - return container_of(public, BlockBackend, public); + return blk->throttle_node; } /* @@ -1920,15 +1915,15 @@ int blk_commit_all(void) /* throttling disk I/O limits */ void blk_set_io_limits(BlockBackend *blk, ThrottleConfig *cfg) { - assert(blk->public.throttle_node); - throttle_group_config(throttle_get_tgm(blk->public.throttle_node), cfg); + assert(blk->throttle_node); + throttle_group_config(throttle_get_tgm(blk->throttle_node), cfg); } void blk_io_limits_disable(BlockBackend *blk) { BlockDriverState *bs, *throttle_node; - throttle_node = blk_get_public(blk)->throttle_node; + throttle_node = blk->throttle_node; assert(throttle_node); @@ -1944,7 +1939,7 @@ void blk_io_limits_disable(BlockBackend *blk) * blk, at this point it might have more than one parent, so use * bdrv_replace_node(). This destroys throttle_node */ bdrv_replace_node(throttle_node, bs, &error_abort); - blk_get_public(blk)->throttle_node = NULL; + blk->throttle_node = NULL; bdrv_unref(bs); bdrv_drained_end(bs); @@ -1994,7 +1989,7 @@ void blk_io_limits_enable(BlockBackend *blk, const char *group, Error **errp) end: bdrv_drained_end(bs); - blk_get_public(blk)->throttle_node = throttle_node; + blk->throttle_node = throttle_node; } void blk_io_limits_update_group(BlockBackend *blk, const char *group, Error **errp) @@ -2002,11 +1997,11 @@ void blk_io_limits_update_group(BlockBackend *blk, const char *group, Error **er ThrottleGroupMember *tgm; /* this BB is not part of any group */ - if (!blk->public.throttle_node) { + if (!blk->throttle_node) { return; } - tgm = throttle_get_tgm(blk->public.throttle_node); + tgm = throttle_get_tgm(blk->throttle_node); /* this BB is a part of the same group than the one we want */ if (!g_strcmp0(throttle_group_get_name(tgm), group)) { return; @@ -2030,8 +2025,8 @@ static void blk_root_drained_begin(BdrvChild *child) /* Note that blk->root may not be accessible here yet if we are just * attaching to a BlockDriverState that is drained. Use child instead. */ - if (blk->public.throttle_node) { - tgm = throttle_get_tgm(blk->public.throttle_node); + if (blk->throttle_node) { + tgm = throttle_get_tgm(blk->throttle_node); if (atomic_fetch_inc(&tgm->io_limits_disabled) == 0) { throttle_group_restart_tgm(tgm); } @@ -2044,8 +2039,8 @@ static void blk_root_drained_end(BdrvChild *child) BlockBackend *blk = child->opaque; assert(blk->quiesce_counter); - if (blk->public.throttle_node) { - tgm = throttle_get_tgm(blk->public.throttle_node); + if (blk->throttle_node) { + tgm = throttle_get_tgm(blk->throttle_node); assert(tgm->io_limits_disabled); atomic_dec(&tgm->io_limits_disabled); } diff --git a/block/qapi.c b/block/qapi.c index ab55db7134..2be44a6758 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -66,9 +66,9 @@ BlockDeviceInfo *bdrv_block_device_info(BlockBackend *blk, info->detect_zeroes = bs->detect_zeroes; - if (blk && blk_get_public(blk)->throttle_node) { + if (blk && blk_get_throttle_node(blk)) { ThrottleConfig cfg; - BlockDriverState *throttle_node = blk_get_public(blk)->throttle_node; + BlockDriverState *throttle_node = blk_get_throttle_node(blk); ThrottleGroupMember *tgm = throttle_get_tgm(throttle_node); throttle_group_get_config(tgm, &cfg); diff --git a/blockdev.c b/blockdev.c index 3f76eed2aa..df8316b1c3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2712,7 +2712,7 @@ void qmp_block_set_io_throttle(BlockIOThrottle *arg, Error **errp) if (throttle_enabled(&cfg)) { /* Enable I/O limits if they're not enabled yet, otherwise * just update the throttling group. */ - if (!blk_get_public(blk)->throttle_node) { + if (!blk_get_throttle_node(blk)) { blk_io_limits_enable(blk, arg->has_group ? arg->group : arg->has_device ? arg->device : arg->id, &local_err); @@ -2730,7 +2730,7 @@ void qmp_block_set_io_throttle(BlockIOThrottle *arg, Error **errp) } /* Set the new throttling configuration */ blk_set_io_limits(blk, &cfg); - } else if (blk_get_public(blk)->throttle_node) { + } else if (blk_get_throttle_node(blk)) { /* * If all throttling settings are set to 0, disable I/O limits * by deleting the legacy throttle node