From patchwork Mon Nov 6 15:47:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10043761 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 90398603FF for ; Mon, 6 Nov 2017 15:55:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7AE9829E3C for ; Mon, 6 Nov 2017 15:55:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6FD6629E65; Mon, 6 Nov 2017 15:55:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E639C29E11 for ; Mon, 6 Nov 2017 15:55:47 +0000 (UTC) Received: from localhost ([::1]:48795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBjkY-0003n1-Lr for patchwork-qemu-devel@patchwork.kernel.org; Mon, 06 Nov 2017 10:55:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBjdb-00071F-HJ for qemu-devel@nongnu.org; Mon, 06 Nov 2017 10:48:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBjda-0000OJ-L4 for qemu-devel@nongnu.org; Mon, 06 Nov 2017 10:48:35 -0500 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:52656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBjdX-0000M9-5U; Mon, 06 Nov 2017 10:48:31 -0500 Received: by mail-pg0-x241.google.com with SMTP id a192so8504612pge.9; Mon, 06 Nov 2017 07:48:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bQXVz+3ZaGZQxv+pGzi011Ap/wEKxrmHydrrlySYiFY=; b=oRgMnRIP41f3ECl3h2+X1jFBAqWsY8YQ1CDIoaqc3pombwNRlLc69EKqCceg2XjbdI HByiOMblRsRQ0tNlFVBKN0As1odVCLHZUbwaKvK2ap+LQF+OmR5hgaq88i9lgaeLQnJP HHqU7ZSxW9wnIQnPmSHrpkrM8jfODUG5VXozrfB9YTWKvnvCN18ImjNEX38pIbYpe8IO yEvI725JxsL9Hw9cAqGpfVi0uJS20T0JPvw5e6quabfCtBTotEjsSYgfqLvbnBfcPXtm NKz4GEjnqjfocacKsR9FD6ueV+V/rHgugy6kg3ONC9m2d53U6x8O47grUCqInHe8sDH+ zIlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bQXVz+3ZaGZQxv+pGzi011Ap/wEKxrmHydrrlySYiFY=; b=I4LH49Vj8PwZrFXN2OBgW7hSgolvz82V1aAIQ+gad4llpgx2Gc5ovUjs4/sFkG8WqY N45TKL/VGn04JUJfZ7QzLYzE9gOuguO9OMTAiz49HXTa16OIq8dX9evXvKl1Ipi8Sov0 ZbM+iGis8lD1yEU5TQLPbMgG1H8aozbyrwM3ZXH9tgylqqHpDQz4pBw8Veysv8PleAxy KzAiFY6oM647ArwYrd8PDVzVE+edkfdYeaxymIKCFYeUBcx/aj7st4Q/SciPzj4Eq5y6 Wfdv8PMXOYMygAwCg3zXo4oK4oE/ybbLa3vo2X9TTwI234tcfxiS/wuT224IbuGPx8fJ ILfg== X-Gm-Message-State: AMCzsaVAZNLiOIoexNzDToAr05+lw3nK5BDwFd2E1dQTkQA84hFh8VbG nm47QIK3AOliG7gkhv7KcGp42m9rfWI= X-Google-Smtp-Source: ABhQp+RTASASsIQCDX21f3fPLreOERU5w3FrDr6Xm4H1+6eLpncJ9R5wADtUtZ1gQYF+XHHI8WUBVg== X-Received: by 10.98.192.195 with SMTP id g64mr16951163pfk.95.1509983309874; Mon, 06 Nov 2017 07:48:29 -0800 (PST) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id x1sm22719590pfh.113.2017.11.06.07.48.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Nov 2017 07:48:29 -0800 (PST) From: Andrey Smirnov To: qemu-arm@nongnu.org Date: Mon, 6 Nov 2017 07:47:45 -0800 Message-Id: <20171106154813.19936-3-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171106154813.19936-1-andrew.smirnov@gmail.com> References: <20171106154813.19936-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PATCH v3 02/30] imx_fec: Refactor imx_eth_enable_rx() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrey Smirnov , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, yurovsky@gmail.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Refactor imx_eth_enable_rx() to have more meaningfull variable name than 'tmp' and to reduce number of logical negations done. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Cc: yurovsky@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 88b4b049d7..8b2e4b8ffe 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -536,19 +536,19 @@ static void imx_eth_do_tx(IMXFECState *s) static void imx_eth_enable_rx(IMXFECState *s) { IMXFECBufDesc bd; - bool tmp; + bool rx_ring_full; imx_fec_read_bd(&bd, s->rx_descriptor); - tmp = ((bd.flags & ENET_BD_E) != 0); + rx_ring_full = !(bd.flags & ENET_BD_E); - if (!tmp) { + if (rx_ring_full) { FEC_PRINTF("RX buffer full\n"); } else if (!s->regs[ENET_RDAR]) { qemu_flush_queued_packets(qemu_get_queue(s->nic)); } - s->regs[ENET_RDAR] = tmp ? ENET_RDAR_RDAR : 0; + s->regs[ENET_RDAR] = rx_ring_full ? 0 : ENET_RDAR_RDAR; } static void imx_eth_reset(DeviceState *d)