From patchwork Mon Dec 11 21:29:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10105791 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B1A6C602D8 for ; Mon, 11 Dec 2017 21:33:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACEC92990E for ; Mon, 11 Dec 2017 21:33:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A1C5529912; Mon, 11 Dec 2017 21:33:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 48ABC2990E for ; Mon, 11 Dec 2017 21:33:18 +0000 (UTC) Received: from localhost ([::1]:55543 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOVhN-0003LP-FQ for patchwork-qemu-devel@patchwork.kernel.org; Mon, 11 Dec 2017 16:33:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOVf7-0000j4-8U for qemu-devel@nongnu.org; Mon, 11 Dec 2017 16:30:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOVf6-0004A7-Au for qemu-devel@nongnu.org; Mon, 11 Dec 2017 16:30:57 -0500 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:45482) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOVf0-0003us-TS; Mon, 11 Dec 2017 16:30:51 -0500 Received: by mail-pg0-x242.google.com with SMTP id m25so11839996pgv.12; Mon, 11 Dec 2017 13:30:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gHgUtmN0/rGU/APCPhW0EAHnmsZlsiEW/PZANp51ENA=; b=lqQhQHdw0B6+UVafVQP3r75nmssP9hFrUULw9eAGxvsCVB9gQQq3J61w86lP+kWQ5S 8SWOsQaW8xqrsnyHHnFwz+Ve6ejldRfaE4fRMFYTIw4BEbx5knOxs1/OvXfrgR/jIHD+ CXClDF4lgRu6inJ+Jw8utklhW/ow4yqurStigz/8tpFdvHk6lkh0iaTb4K2KjqXwpcxS U3u42c0MlANxECwQMTscNGPa9RTS8rUGluebZ8tOz3A9R0A1LpbnzbKjfOejKtCKT0Xv UiwxRMdfS3X0hBIFw2Pg6P8UiRB9rDvTvzy+7Zskatrd1/GOnh9uvvMkilNEZsTBlAVV wGbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gHgUtmN0/rGU/APCPhW0EAHnmsZlsiEW/PZANp51ENA=; b=SHBRlKOZFH7SMvFf6dyzECuxteZAkqz0N9uwCyz9arNf5+1hm4nHsL5kEJ91JRjKu1 PwL10PKyCSlK8kym8d/2niadtjlxERQDV5IbWBN4x8JSNt0D3bPNIMwZgPrthVn5xOT7 mYtJDDlc7fY+PXJQi07Cu3kAIfNgPqHt9G2//QhspMHvzGRS59xK3AM+qPeDDPo/nsFq SxwlOlnPKCs57wEdu7wGSaPyaTC6kIqjR6JT8QdyCmY81IuLpqcEXjrV7wbzDlkggNOD AVCsDIM2Py63b2VtbBblV9Cz1gQmqHRmaoPSvnZVtgvnclFFux1ycH081dpYMGB9vFIP gtAw== X-Gm-Message-State: AKGB3mIhTOe3TZVZsrMT4UAx7oIQHmHKmDDyyliSoNQQ44gsW8ZltSxu 0vm+Qmv3h+i/dN4TBqJkzf/3y3kH X-Google-Smtp-Source: ACJfBovui2fA5A9miYJUNvCSmUJpj7OW/q3etoNGqMRIBssh8nkeq7So9T+8U1/NBAauqc9vebLRew== X-Received: by 10.159.195.72 with SMTP id z8mr1628345pln.183.1513027849587; Mon, 11 Dec 2017 13:30:49 -0800 (PST) Received: from squirtle.westlake.spaceflightindustries.com ([173.226.206.194]) by smtp.gmail.com with ESMTPSA id q10sm25359690pgc.84.2017.12.11.13.30.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Dec 2017 13:30:48 -0800 (PST) From: Andrey Smirnov To: qemu-arm@nongnu.org Date: Mon, 11 Dec 2017 13:29:56 -0800 Message-Id: <20171211213007.7353-3-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171211213007.7353-1-andrew.smirnov@gmail.com> References: <20171211213007.7353-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH 02/13] imx_fec: Refactor imx_eth_enable_rx() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrey Smirnov , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, yurovsky@gmail.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Refactor imx_eth_enable_rx() to have more meaningfull variable name than 'tmp' and to reduce number of logical negations done. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Cc: yurovsky@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 88b4b049d7..8b2e4b8ffe 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -536,19 +536,19 @@ static void imx_eth_do_tx(IMXFECState *s) static void imx_eth_enable_rx(IMXFECState *s) { IMXFECBufDesc bd; - bool tmp; + bool rx_ring_full; imx_fec_read_bd(&bd, s->rx_descriptor); - tmp = ((bd.flags & ENET_BD_E) != 0); + rx_ring_full = !(bd.flags & ENET_BD_E); - if (!tmp) { + if (rx_ring_full) { FEC_PRINTF("RX buffer full\n"); } else if (!s->regs[ENET_RDAR]) { qemu_flush_queued_packets(qemu_get_queue(s->nic)); } - s->regs[ENET_RDAR] = tmp ? ENET_RDAR_RDAR : 0; + s->regs[ENET_RDAR] = rx_ring_full ? 0 : ENET_RDAR_RDAR; } static void imx_eth_reset(DeviceState *d)