From patchwork Tue Jan 2 19:36:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10141259 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 079A76035E for ; Tue, 2 Jan 2018 19:38:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB90628DCF for ; Tue, 2 Jan 2018 19:38:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E023A28DF9; Tue, 2 Jan 2018 19:38:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6E2F228DCF for ; Tue, 2 Jan 2018 19:38:20 +0000 (UTC) Received: from localhost ([::1]:52914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWSOB-0004V6-5P for patchwork-qemu-devel@patchwork.kernel.org; Tue, 02 Jan 2018 14:38:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWSMb-0003EU-R6 for qemu-devel@nongnu.org; Tue, 02 Jan 2018 14:36:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWSMa-0000Jn-PK for qemu-devel@nongnu.org; Tue, 02 Jan 2018 14:36:41 -0500 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:45443) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWSMX-0000Gb-8R; Tue, 02 Jan 2018 14:36:37 -0500 Received: by mail-pf0-x243.google.com with SMTP id u19so26002863pfa.12; Tue, 02 Jan 2018 11:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+R7JD2AboYJs7m3vYE67ODV+/FajhNS+oxOIt/bT5AM=; b=eRqJZfZgDXLpzHUUBegHQrKBdnZ8gqFSNYg7EMm0Jng1LwvnoqwqYelZFtoR31EPcN DxQ1Vtzf+Ge8idnIZciTWOTlMeVjfjLnXldHPOn02on7jZ98yS9NHe2h+sIsS3LyOWTc 7IYOaxEZPkyJjw287vgZfDTFHCEpZ7aHgv5C6p9Bpiw05vUbjYuIK6+ynZHRBOgUNMoJ rz0JHSgvbR7+9vGGEDPdrfmDcgjGsV1/2Yl+gfJ6ULogjRAE7ppbTIXStlJO8XBvp3ij 4EcXEUCEE+1eJ+Le16JzLZpihNRtYzvN8VWwrS+40DIE6lcmvGExiGs9cgx8KR6wMKQn EICQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+R7JD2AboYJs7m3vYE67ODV+/FajhNS+oxOIt/bT5AM=; b=LzDlYfWwVbEXY5AvfKqUnGVm/Wyq6ZlKooKVxo7tgx6IwB38rG6uxnZ5X3ohAM9v6l yuVUoawKMPSV8TtxHT/l8omHsBepAzHxqtmERoT4sr4dhvT2lFpmwNXzfBid5uZwZMKH bm/wRWv8bfWVqt0k2maUpmCfokwt/Y4v5yJXwpikuTUnEn/7dSU7iZ+BgmJNwluEBVvY T/1scDtu3HjGKoYzIX29U7HlsEBaTE0G9gHzroRXH5EgivXNrv/s/xIuyhqi3Izk6qKf dncD05vqYF+6g6XXcrNhE5MAsynku36ufqrQQEzk0QjCjaNcPe8Jrex0Gi6vA6Mu8ayV XIAg== X-Gm-Message-State: AKGB3mItNO1MPX56x4GBEOyc8Ll6pXGH669c0V9VKTcSWFB+NLROorGJ bKCTF2T97KTKlEtHA8DSahUpiQdTSVI= X-Google-Smtp-Source: ACJfBosalpM4hINC+Pj486VwPv7EijNMCr2XgIW4LIizvt5M1/wDtMg9s2kFxq34HgycF/7vvYZVnQ== X-Received: by 10.98.87.142 with SMTP id i14mr46637906pfj.212.1514921796017; Tue, 02 Jan 2018 11:36:36 -0800 (PST) Received: from squirtle.westlake.spaceflightindustries.com ([173.226.206.194]) by smtp.gmail.com with ESMTPSA id g9sm97905951pfk.0.2018.01.02.11.36.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jan 2018 11:36:35 -0800 (PST) From: Andrey Smirnov To: qemu-arm@nongnu.org Date: Tue, 2 Jan 2018 11:36:13 -0800 Message-Id: <20180102193622.27215-3-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180102193622.27215-1-andrew.smirnov@gmail.com> References: <20180102193622.27215-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH v3 02/11] imx_fec: Refactor imx_eth_enable_rx() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrey Smirnov , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, yurovsky@gmail.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Refactor imx_eth_enable_rx() to have more meaningfull variable name than 'tmp' and to reduce number of logical negations done. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Cc: yurovsky@gmail.com Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 88b4b049d7..8b2e4b8ffe 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -536,19 +536,19 @@ static void imx_eth_do_tx(IMXFECState *s) static void imx_eth_enable_rx(IMXFECState *s) { IMXFECBufDesc bd; - bool tmp; + bool rx_ring_full; imx_fec_read_bd(&bd, s->rx_descriptor); - tmp = ((bd.flags & ENET_BD_E) != 0); + rx_ring_full = !(bd.flags & ENET_BD_E); - if (!tmp) { + if (rx_ring_full) { FEC_PRINTF("RX buffer full\n"); } else if (!s->regs[ENET_RDAR]) { qemu_flush_queued_packets(qemu_get_queue(s->nic)); } - s->regs[ENET_RDAR] = tmp ? ENET_RDAR_RDAR : 0; + s->regs[ENET_RDAR] = rx_ring_full ? 0 : ENET_RDAR_RDAR; } static void imx_eth_reset(DeviceState *d)