From patchwork Sat Mar 31 17:16:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 10319005 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DCFED602A7 for ; Sat, 31 Mar 2018 17:17:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1C28293F7 for ; Sat, 31 Mar 2018 17:17:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B5C4B293FB; Sat, 31 Mar 2018 17:17:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1FA67293F7 for ; Sat, 31 Mar 2018 17:17:14 +0000 (UTC) Received: from localhost ([::1]:38487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2K7t-0002DG-P1 for patchwork-qemu-devel@patchwork.kernel.org; Sat, 31 Mar 2018 13:17:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2K7A-0001qF-DH for qemu-devel@nongnu.org; Sat, 31 Mar 2018 13:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2K79-00014s-Fk for qemu-devel@nongnu.org; Sat, 31 Mar 2018 13:16:28 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:34506) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f2K79-00013c-73 for qemu-devel@nongnu.org; Sat, 31 Mar 2018 13:16:27 -0400 Received: by mail-lf0-x241.google.com with SMTP id c78-v6so15988738lfh.1 for ; Sat, 31 Mar 2018 10:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=sSuMKLWxyMer5Sa65JlCnYzSQTBCoO/mZ/XE1XjEGgc=; b=Zy387Nk8GwIdwlWj2kvDwgVAJmbvjUileJgd7oszX1z/YHogxtoxI8mU4yL3pv9mmG KC4sCTm96apEyIIrgkSZ3ARBFtSiCJPMNKdPbyQmxtVocmSTEYKC7gap1fqrdlgIHO3O yiw0s0XPF4QJMYxQ66pfRzisv2jEGWYIcEkpaGWMpzzPvqb4340qlnpa7xFyYvDMqUaT 1IIVuyj4hsEWFX8N+tXatBKcaOq/eVK80EBeN0Dx2a5VQKYya1RQtuujhQDXSXMTbxTo Fb1oWiYPzWXT5Vb9T3pfWNauKOguKEl5wCubw5/qFFjoVXNdaISkYrPDrM0OZEyl86BX 5z0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sSuMKLWxyMer5Sa65JlCnYzSQTBCoO/mZ/XE1XjEGgc=; b=JRNkapRn2V5lovKgzYsj2cER1EX40NCwW2klfvBGPnaCSy1FuHydxs11taZOyjzZ1t A6KtAmhk/6acmvxR12NxVqecO/tsYOPyFxiSZVTQHaOtOmvTw4iUn6SR5HwKt1I4u78G tLtBjskvGA+hEReKaCDeyFbc6fRTxpKNcBJv9I08yNGx1VkTujFNtjTHgx/4ZjEWAmRI Fpj3uWNhXS2RtZIAHMIAwsmyzu3I/5UWT/aAwWOFhKEAQUaFHGbXpQV1DyUW1gNC/19P lK4Mu8/qmBS7WydJ4qPjwpmeaxmXEu/zO9EqTYKfL4XHgciFBX6nwFX/M5r3Fyr+EKka hbDA== X-Gm-Message-State: AElRT7FrT0c1nMwqF9Iokb1fyptA2MiSCITjFljI5xuwrbD128R5BvLE idpdzX2JqB50VgNDd9JIsm7Oxw== X-Google-Smtp-Source: AIpwx4/AStmUzan6tvaKk5iKLHNeT6L6HKZl9T2Xcep8MFrVx0U27KPmH4A4+JUsry2frXfWZozLDA== X-Received: by 10.46.112.24 with SMTP id l24mr2209536ljc.104.1522516585727; Sat, 31 Mar 2018 10:16:25 -0700 (PDT) Received: from octofox.hsd1.ca.comcast.net. (jcmvbkbc-1-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:1fa::2]) by smtp.gmail.com with ESMTPSA id x17sm1119392ljx.80.2018.03.31.10.16.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Mar 2018 10:16:25 -0700 (PDT) From: Max Filippov To: qemu-devel@nongnu.org Date: Sat, 31 Mar 2018 10:16:15 -0700 Message-Id: <20180331171615.21259-1-jcmvbkbc@gmail.com> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PATCH v3] linux-user: fix mq_getsetattr implementation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lionel Landwerlin , Riku Voipio , Laurent Vivier , Max Filippov , "Kirill A . Shutemov" , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP mq_getsetattr implementation does not set errno correctly in case of error. Also in the presence of both 2nd and 3rd arguments it calls both mq_getattr and mq_setattr, whereas only the latter call would suffice. Don't call mq_getattr in the presence of the 2nd argument. Don't copy output back to user in case of error. Use get_errno to set errno value. This fixes test rt/tst-mqueue2 from the glibc testsuite. Cc: Lionel Landwerlin Cc: Kirill A. Shutemov Cc: Riku Voipio Cc: Aurelien Jarno Cc: Laurent Vivier Signed-off-by: Max Filippov Reviewed-by: Laurent Vivier --- Changes v2->v3: - don't defer get_errno call; Changes v1->v2: - don't copy output back to user in case of error; - fix changelog. linux-user/syscall.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 18ea79140f16..d51e2a00ee31 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -12092,15 +12092,16 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, { struct mq_attr posix_mq_attr_in, posix_mq_attr_out; ret = 0; - if (arg3 != 0) { - ret = mq_getattr(arg1, &posix_mq_attr_out); - copy_to_user_mq_attr(arg3, &posix_mq_attr_out); - } if (arg2 != 0) { copy_from_user_mq_attr(&posix_mq_attr_in, arg2); - ret |= mq_setattr(arg1, &posix_mq_attr_in, &posix_mq_attr_out); + ret = get_errno(mq_setattr(arg1, &posix_mq_attr_in, + &posix_mq_attr_out)); + } else if (arg3 != 0) { + ret = get_errno(mq_getattr(arg1, &posix_mq_attr_out)); + } + if (ret == 0 && arg3 != 0) { + copy_to_user_mq_attr(arg3, &posix_mq_attr_out); } - } break; #endif