From patchwork Mon May 14 16:54:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Chen X-Patchwork-Id: 10398929 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F1F85601E7 for ; Mon, 14 May 2018 16:59:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2A7D2811E for ; Mon, 14 May 2018 16:59:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D55DD2838F; Mon, 14 May 2018 16:59:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4D2D12811E for ; Mon, 14 May 2018 16:59:28 +0000 (UTC) Received: from localhost ([::1]:47279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIGop-0003ED-Fg for patchwork-qemu-devel@patchwork.kernel.org; Mon, 14 May 2018 12:59:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIGkU-0007dL-8c for qemu-devel@nongnu.org; Mon, 14 May 2018 12:54:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIGkP-0005Jk-9V for qemu-devel@nongnu.org; Mon, 14 May 2018 12:54:58 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:44320) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fIGkP-0005J0-3u for qemu-devel@nongnu.org; Mon, 14 May 2018 12:54:53 -0400 Received: by mail-pf0-x241.google.com with SMTP id q22-v6so6302003pff.11 for ; Mon, 14 May 2018 09:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PYeU+Tc1rcAKSmqU2XR30cyGjmPFM8SQWmmnAuMGfD8=; b=DzJ7vdupTyQhJlgdHAG6YrxIVlIK/+sYRIqFEiOq9T8VEb/dfMUhHxoyI6PEp7GFf3 EJISAMAMEOZbZTDkzScjqY8W5bBjCfKkZlA+KEo0tR7tKPx3S7SpYxQa4FVNvt9hR+ee 44nJXMFUZ8/SJpE3eK89z3658yIRK0X/IAOChNUJ9JiYR6wNO8FX9pY9pOeT8SF5shCQ r7P0DzcZnGegiHtUZI1kKw9MJIThfExssuZljHsgAXnNNGAP60Ce2HLyovQnXubNK967 KoRSUdyj18IJcRjmNuDwAHgFgdM+kFppYT8DOWhH/TgYpCL/ODBZCnEVBMXCYba9d+9+ y+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PYeU+Tc1rcAKSmqU2XR30cyGjmPFM8SQWmmnAuMGfD8=; b=rvDqRLB0U0/TAdpLhYga9f15mtAC5iDxWf+HDJreW3bjAaxnJ7I7Xuml2wqdy76Phe mfUo86FUP0KYcr/qnSlth0CBdaiwiI7Yt5i0h7oSODILR+waEaba+LV3635ZoGPJAlJP uIrJoaEwhq3rrXamhG7DKmdw4XT88tHIIQr48x1Z8+gqOcyJZXCzYidwHa9HWRU5Ec6x cd6O0LYF9uilHHliGoToOeE7eOk9Zz8mno0CReuP0ZANN+K0q4DsFkAGAbdssU7WHdhP mY/XYKA6G/bk7SMhbhjOBUhCq2m6azpwVf+TkUnACSOxtXl+LoluLSw2tLHAddAkg2Xz LSuQ== X-Gm-Message-State: ALKqPweY7vMHe41CYvc50XaYH3LEMy77pk3Wm3Hx+A/5DxD9TDCXM9ja KH/yuWSwMc1/RCzSKWtZwLvAUQ== X-Google-Smtp-Source: AB8JxZr954ZoScELuK6++Tdg4uEz8GquYSxb3zFH/RSKV5E5dIUfBbZ9T/pZPmdErupDD98flWQuMg== X-Received: by 2002:a65:4dca:: with SMTP id q10-v6mr9192153pgt.22.1526316891838; Mon, 14 May 2018 09:54:51 -0700 (PDT) Received: from localhost.localdomain (109.227.199.104.bc.googleusercontent.com. [104.199.227.109]) by smtp.gmail.com with ESMTPSA id u69-v6sm631448pgb.42.2018.05.14.09.54.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 09:54:50 -0700 (PDT) From: Zhang Chen To: qemu-devel@nongnu.org Date: Tue, 15 May 2018 00:54:10 +0800 Message-Id: <20180514165424.12884-4-zhangckid@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180514165424.12884-1-zhangckid@gmail.com> References: <20180514165424.12884-1-zhangckid@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PATCH V7 RESEND 03/17] colo-compare: use notifier to notify packets comparing result X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhanghailiang , Jason Wang , Markus Armbruster , "Dr . David Alan Gilbert" , Zhang Chen , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP It's a good idea to use notifier to notify COLO frame of inconsistent packets comparing. Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang --- net/colo-compare.c | 32 +++++++++++++++++++++++++------- net/colo-compare.h | 2 ++ 2 files changed, 27 insertions(+), 7 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 7ff3ae8904..05061cd1c4 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -29,6 +29,7 @@ #include "sysemu/iothread.h" #include "net/colo-compare.h" #include "migration/colo.h" +#include "migration/migration.h" #define TYPE_COLO_COMPARE "colo-compare" #define COLO_COMPARE(obj) \ @@ -37,6 +38,9 @@ static QTAILQ_HEAD(, CompareState) net_compares = QTAILQ_HEAD_INITIALIZER(net_compares); +static NotifierList colo_compare_notifiers = + NOTIFIER_LIST_INITIALIZER(colo_compare_notifiers); + #define COMPARE_READ_LEN_MAX NET_BUFSIZE #define MAX_QUEUE_SIZE 1024 @@ -561,8 +565,24 @@ static int colo_old_packet_check_one(Packet *pkt, int64_t *check_time) } } +static void colo_compare_inconsistent_notify(void) +{ + notifier_list_notify(&colo_compare_notifiers, + migrate_get_current()); +} + +void colo_compare_register_notifier(Notifier *notify) +{ + notifier_list_add(&colo_compare_notifiers, notify); +} + +void colo_compare_unregister_notifier(Notifier *notify) +{ + notifier_remove(notify); +} + static int colo_old_packet_check_one_conn(Connection *conn, - void *user_data) + void *user_data) { GList *result = NULL; int64_t check_time = REGULAR_PACKET_CHECK_MS; @@ -573,10 +593,7 @@ static int colo_old_packet_check_one_conn(Connection *conn, if (result) { /* Do checkpoint will flush old packet */ - /* - * TODO: Notify colo frame to do checkpoint. - * colo_compare_inconsistent_notify(); - */ + colo_compare_inconsistent_notify(); return 0; } @@ -620,11 +637,12 @@ static void colo_compare_packet(CompareState *s, Connection *conn, /* * If one packet arrive late, the secondary_list or * primary_list will be empty, so we can't compare it - * until next comparison. + * until next comparison. If the packets in the list are + * timeout, it will trigger a checkpoint request. */ trace_colo_compare_main("packet different"); g_queue_push_head(&conn->primary_list, pkt); - /* TODO: colo_notify_checkpoint();*/ + colo_compare_inconsistent_notify(); break; } } diff --git a/net/colo-compare.h b/net/colo-compare.h index 1b1ce76aea..22ddd512e2 100644 --- a/net/colo-compare.h +++ b/net/colo-compare.h @@ -18,5 +18,7 @@ #define QEMU_COLO_COMPARE_H void colo_notify_compares_event(void *opaque, int event, Error **errp); +void colo_compare_register_notifier(Notifier *notify); +void colo_compare_unregister_notifier(Notifier *notify); #endif /* QEMU_COLO_COMPARE_H */