From patchwork Tue May 29 10:49:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 10434917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0273B601E9 for ; Tue, 29 May 2018 10:51:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E68BD286B6 for ; Tue, 29 May 2018 10:51:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DA5B8286C0; Tue, 29 May 2018 10:51:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, FSL_HELO_FAKE, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5719C286B6 for ; Tue, 29 May 2018 10:51:45 +0000 (UTC) Received: from localhost ([::1]:60088 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNcEC-0002Nw-PG for patchwork-qemu-devel@patchwork.kernel.org; Tue, 29 May 2018 06:51:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNcCq-0001A2-Ef for qemu-devel@nongnu.org; Tue, 29 May 2018 06:50:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNcCm-0003gp-LY for qemu-devel@nongnu.org; Tue, 29 May 2018 06:50:20 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:39272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fNcCm-0003gb-FB for qemu-devel@nongnu.org; Tue, 29 May 2018 06:50:16 -0400 Received: by mail-wm0-x242.google.com with SMTP id f8-v6so39337513wmc.4 for ; Tue, 29 May 2018 03:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZuqoeEh2iRHdYcrhRznRZMZfGgaIogY6PwFPOwEPfM8=; b=ULdD45+WXLfl1KlJuyVbtWqWArMFiUHufYgXBgHL9/Kozbpwp4SKbhlskhrHvueokg FBuT88dm8R27GlHNnGMZfT4Dn2jgznN3K8ecn2plVffQI4kCNKalNgFnkXe0LpJxqIs9 AHLpl/a+Fq7TIQk8zetb4AnbBMOspYEu6rFxYEGFagp5ZHgV5J7s14xbCDjYrHP7VNfm vGPlpn8zXcAhfMJa7raPV+/BhaFjlAvl8UKEdLjieFYBvLxdQE1zvN/ePdOiW0ITV0Bc J6jE+4j74GJ7h2XfwRzhAr9W9Cqb8NFdCJjRgnlR04O9eBd8I4NnzfJatTtYRxJci56Y wy8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZuqoeEh2iRHdYcrhRznRZMZfGgaIogY6PwFPOwEPfM8=; b=Iu9MbNN1zrA1eIzyL3F0hCHNsv+lJgSHhndk/iX/dCK4GpBWKvuUE2d3uuhc/ly67n G+bSsPWKzXcyJPH5URkzmCKvsPFff9ICvTuPaAm4dv0HAIj4SqAKYnzUZVwd385NkqLN pJiTnZcXAybtLBFsNJnEAJJHb04t1t2VjwuF+z50M7QGsHGr/HI+2VSISSae0bNLBCYK ugV0IQPhUvCfFIXVfA9HmbIAsBWAMXl9wGc5DSfuuAuJ3324Fo/QXO2WzskOxDQUuONk ZSPOh5q20u9/s8bkd4nkrImwNvc45JqELw1BclOqgPim/9h7mQXGz+weJsWeaNTyIExQ XdAA== X-Gm-Message-State: ALKqPwcKAWkS3xM0TJjReQ62MI17670P0YGSt6qviJcwBVrqgPmbTkt/ taVJq+jxn9deqt2ntrxTsdpn6w== X-Google-Smtp-Source: AB8JxZpCsnmvVdcfIcP7g58UqqW+uL1uwy9LMLeuLrAjy/K4RMupJUJTju/pmwNq4NmRGihh1ynb1Q== X-Received: by 2002:a2e:83d7:: with SMTP id s23-v6mr10681940ljh.34.1527591015016; Tue, 29 May 2018 03:50:15 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id x26-v6sm6270818ljd.81.2018.05.29.03.50.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 03:50:14 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Tue, 29 May 2018 12:49:34 +0200 Message-Id: <20180529105011.1914-2-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180529105011.1914-1-edgar.iglesias@gmail.com> References: <20180529105011.1914-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PULL v1 01/38] target-microblaze: dec_load: Use bool instead of unsigned int X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. No functional change. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 0872dc9ded..a8a5eaebec 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -897,14 +897,15 @@ static inline TCGv *compute_ldst_addr(DisasContext *dc, TCGv *t) static void dec_load(DisasContext *dc) { TCGv t, v, *addr; - unsigned int size, rev = 0, ex = 0; + unsigned int size; + bool rev = false, ex = false; TCGMemOp mop; mop = dc->opcode & 3; size = 1 << mop; if (!dc->type_b) { - rev = (dc->ir >> 9) & 1; - ex = (dc->ir >> 10) & 1; + rev = extract32(dc->ir, 9, 1); + ex = extract32(dc->ir, 10, 1); } mop |= MO_TE; if (rev) {