| Message ID | 20180725121655.12867.68682.stgit@pasha-VirtualBox (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fixing record/replay and adding reverse debugging | expand |
On 25/07/2018 14:16, Pavel Dovgalyuk wrote: > This patch makes IDE trim BH deterministic, because it affects > the device state. Therefore its invocation should be replayed > instead of running at the random moment. > > Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru> > --- > hw/ide/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 2c62efc..04e22e7 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -35,6 +35,7 @@ > #include "sysemu/block-backend.h" > #include "qapi/error.h" > #include "qemu/cutils.h" > +#include "sysemu/replay.h" > > #include "hw/ide/internal.h" > #include "trace.h" > @@ -479,7 +480,7 @@ static void ide_issue_trim_cb(void *opaque, int ret) > done: > iocb->aiocb = NULL; > if (iocb->bh) { > - qemu_bh_schedule(iocb->bh); > + replay_bh_schedule_event(iocb->bh); > } > } > > > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/hw/ide/core.c b/hw/ide/core.c index 2c62efc..04e22e7 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -35,6 +35,7 @@ #include "sysemu/block-backend.h" #include "qapi/error.h" #include "qemu/cutils.h" +#include "sysemu/replay.h" #include "hw/ide/internal.h" #include "trace.h" @@ -479,7 +480,7 @@ static void ide_issue_trim_cb(void *opaque, int ret) done: iocb->aiocb = NULL; if (iocb->bh) { - qemu_bh_schedule(iocb->bh); + replay_bh_schedule_event(iocb->bh); } }
This patch makes IDE trim BH deterministic, because it affects the device state. Therefore its invocation should be replayed instead of running at the random moment. Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru> --- hw/ide/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)