From patchwork Wed Jul 25 14:27:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonid Bloch X-Patchwork-Id: 10544099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3CADC139A for ; Wed, 25 Jul 2018 14:29:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B4402A100 for ; Wed, 25 Jul 2018 14:29:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F28B2A112; Wed, 25 Jul 2018 14:29:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D7EA62A100 for ; Wed, 25 Jul 2018 14:29:50 +0000 (UTC) Received: from localhost ([::1]:51531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiKnW-00068Y-0a for patchwork-qemu-devel@patchwork.kernel.org; Wed, 25 Jul 2018 10:29:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiKmL-00055E-5s for qemu-devel@nongnu.org; Wed, 25 Jul 2018 10:28:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fiKmI-0000AZ-5L for qemu-devel@nongnu.org; Wed, 25 Jul 2018 10:28:37 -0400 Received: from mail-eopbgr700133.outbound.protection.outlook.com ([40.107.70.133]:39036 helo=NAM04-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fiKmH-00009d-UN; Wed, 25 Jul 2018 10:28:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janustech.onmicrosoft.com; s=selector1-janustech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aqMmRNU/7KRZTAja561wiGva9NoVtDNSGoa3NKB24bs=; b=lMHwdVxM37GgLAL4bTv9Cnrz6LL8+D4sEtr2yr0pgJX9NDxhw6GtKRhxNKUhRl0STb+fiJ/QeaAGJCCnm0wjYzGcU3ccCfO75EobXgtrfCSStX7wafv3uUANMKKzzgc92+SGCTk6UTPRTuWSilmU6YydpD72JSQEt0lZmdJBJV4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=lbloch@janustech.com; Received: from Jupiter.local (141.226.29.227) by SN2PR07MB2622.namprd07.prod.outlook.com (2603:10b6:804:8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.16; Wed, 25 Jul 2018 14:28:30 +0000 From: Leonid Bloch To: qemu-devel@nongnu.org Date: Wed, 25 Jul 2018 17:27:56 +0300 Message-Id: <20180725142758.9980-3-lbloch@janustech.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180725142758.9980-1-lbloch@janustech.com> References: <20180725142758.9980-1-lbloch@janustech.com> MIME-Version: 1.0 X-Originating-IP: [141.226.29.227] X-ClientProxiedBy: HE1PR05CA0386.eurprd05.prod.outlook.com (2603:10a6:7:94::45) To SN2PR07MB2622.namprd07.prod.outlook.com (2603:10b6:804:8::6) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 51f43407-c89f-425d-99b0-08d5f23ae5f4 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(7021125)(8989117)(5600073)(711020)(4534165)(7022125)(4603075)(4627221)(201702281549075)(8990107)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(7193020); SRVR:SN2PR07MB2622; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2622; 3:NOgfap1O1FmEPmS/9r+ni2tfPCVwFRp+YRyo0bK5XCQHaP1MrNS9gtyNo+EUvnK0UoPZJ7Io+CGIb8wl5F4eKkNrs5qVtdxggU5S7BSeEyu3DTSTZYbpu1gD2pwXdq3pgM8CVASVbQeTY/Nkm6eQSDmFmvDv2A6ltAq8VSoomIuHOS6NUa3AZLXe2FnP+yoPqwTBGlGoDimAX2Id7c+ObeHJzmUWKNcd9o2Kr3QQ7Rnjhvkp3LamvhnHlSNtCBlK; 25:w+LP7NsjpBsVKj9Z5jNxALFMwa8n0/G+eiwFFwXM140DMCZmU2EfMirznLZJT2Wx/ubpfHlyAUApvkGNcR5O+kfdbNZf9veLE9QWdEljO4Ad4KrfcwGSAG5P4ZZJSTWCzNGFzzeXsa4hXdIl/FDcq4kCrSqeHVViOIDxUDt0td037bI3SpQ9LXJoEIy3+8ordJ7cmFs5+Iw5IYh1DyB6rJMNAlqjMFuNr3n67o39sTorduYR4uoqoYS9sXmN7NKgiunNOg07fQOOGSJ6zf9LvN8fZcTC+XDb3g3sNvxaLT+zMRMEcgygjpSd6dYv3JdMp4VKkbuPxx3yaROJsfrwKw==; 31:2z2376y4NCpkPhslfj7x8NGnYmLZV2lHDRKsVZZDA/yarqVH/YNROsV+ai0TpQNd6SfyayrKPTRPZajeoWhtCL1pQPdOOc4uP+Bw+68RjqTV0dRMf+s5Uyk0E2ptUWrMK6YZ8kjfcuMaQC8p+QDq7i+DkIFhT4OGyqgIfnO71dHcAj+Hl3VCFyKM1n3Bw8Slz++DwGykXjtVr1GNvsG8yfuDff6g4wF9nlXav/Omljs= X-MS-TrafficTypeDiagnostic: SN2PR07MB2622: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123560045)(2016111802025)(20161123558120)(20161123562045)(20161123564045)(6072148)(6043046)(201708071742011)(7699016); SRVR:SN2PR07MB2622; BCL:0; PCL:0; RULEID:; SRVR:SN2PR07MB2622; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2622; 4:RD6VsU9kHAq45nIHb141CNAE+jOoLOUg94sLO34Y+BpXpi9O35PlOhM6oTRehNqzDXPywKumLkbFZquzhzveVyQFsx5HkAJkZV1IVgcrKHNLz6ltEjMmc+RWuERrKVN12/Ayh/FPKocp4fmN/83vj8PB9RK2dUS/boXRcOaglrw7Ot2FMo2xpY798u8mBA5CtNUfN2uYVTPPXGlAy44rmPI/nbhEhnzwNcrw+zm4lxG6VvfRvGpvMSDCABssXwJydwGyAW7wJUFkQ8ZDFCW2vw== X-Forefront-PRVS: 0744CFB5E8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(366004)(346002)(39830400003)(396003)(136003)(189003)(199004)(446003)(11346002)(2616005)(476003)(486006)(54906003)(956004)(316002)(52116002)(51416003)(76176011)(16586007)(1076002)(3846002)(6116002)(2351001)(186003)(16526019)(36756003)(26005)(97736004)(48376002)(106356001)(105586002)(86362001)(575784001)(8936002)(68736007)(50226002)(53936002)(6512007)(7736002)(6916009)(6666003)(478600001)(6486002)(2361001)(305945005)(25786009)(14444005)(2906002)(386003)(50466002)(6506007)(47776003)(4326008)(8676002)(107886003)(66066001)(5660300001)(81166006)(81156014); DIR:OUT; SFP:1102; SCL:1; SRVR:SN2PR07MB2622; H:Jupiter.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: janustech.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2622; 23:wxixuHABzD+HKEdRZc5pddMWEy0aFrMVX17jEPdRb?= xdilhYyyzUU9tMrQJsrjr1BnCsjig5WiCx96g13f0cmnYNdoberhuydYAIkkwERQjgl4gnOU5S0ZrV7v17BhdSEk3E+Lq6K5tbC9AymErY8BU4nXJz+ZlqU5TISNKasn3eQlaVqHOnHjBXr1CaATFMyl1BbhyGAb02GaVWB+LwZnhn0jmMYjQhIa9BdG4xc99USfV0xlOzV7wNFXkxadxNiMYCW2wTi7DjzOBOHicWj2iP9nMPCDNCWL5Ve/GQuWTqs/NoBEIKQA4FbJbSBt6YoLhweKT1nizTAWRvmkFu2Kti2EV2z79Y72xxRfqMkyFVwwNAD1K13euIqHDE6DNimdNo5+mevq/w2bre6pPpD9R8rnYPb4aYjnSgAxPsXrSgQBuw71UN4TC3xN4wxLQPOnN52SB0SNEWNw4N2soV11daKwQrKOOXfPFSkHLytATTj4E1YEq1SYjkJL8QhLZfMAVwURW14A3HCALNaMuk/raWRBIhIlQU4IOBjq6o515QQrQRoL8A+qbJuKk3yHthsfVO9jWxfDu9mNn25Dg2dgB7MC3FYhqLxZsn+cuIlq9C8hMwfdbD9wgXYjx9B7IhM4BzZ+T0StzPB7gGDFi2v/+M2j/YuT9uq2iUxwytGcwiqlu8Nc4ZuQtQ9EqXGYFsLHGjqvsiLDmNXiVlIx9e/z784Ai1S652PlpTotr7Q/935xrrvIDKazW0QTIrGbtAmghKosWzB1zDWXrfdW6SNiQqtUWNgrCd4gEj+Ov7nbC6dKoYt0d+tcXQXHDkVf6/bCVykJxr05D85ShOJ/+Q8HRIBVPmYVYWPgK5DPyvVqwiGxEKKW+HXLLqHUO6jI+scuXIwRvCTl+SEIHmiU6/qXFELJIQp2T0ke3eXCICMvFrlKjfD5sZvVP5cE5UADHb5N0j+/4kq366jFZjdJuaCEBmwI7o2mIevBDsyVaryRXIMpCpQbW88izYxXDS4SW3UCxy4zaXiw6BgEyJV8sZ1yU99AR1ujdbZ7c72hiXf7yEmx7mmlPXBKfroDJiRJKReZEiauvofhchAcvp6tTLPA27udiaNS5ywnQxkddzMo/oOi26pNn+rSi1i2VUQE2R9dioFUmUXnxRqI45IDEn34eeSptSJ1ruS2tMx/ONq0JW0QnNIdVFk/5/5Lg1wDyLiGLjbnvLbrTJpNnhs+i2SzCaIh6p3dRL/tpiNFekiUvd6RRY6XMi2m+PXSG3+w09F68S/iKap7iVM65kTOMuAMiNRtH9/Crl+cg0Z9gbAVfA= X-Microsoft-Antispam-Message-Info: Uo7OPylBBxg3QFSvTw7U055TVm71ti9Ql7GOpV1TGIm/q6Ncmd4U7NgW7qvVzqrAwFTJHt/Qq/3XVK7qhIIYxENmc4FVLfrjm/IKTiAzd9ZfakpZQGk/H6byjj0ZBv3mwJghZqseGuBlPh5AId3/tbEEKmAXY65PW8KX+58vN47qu+26Q0KfV4Ix4Rhulr8imV1lA25mjnP3CZVEHja5329tLBbHnV1GJUpEkWM/xJK5d2HC86bFmH5VLwQnpv8U3knAyM7UhylSG/IbYzh968U1DOfP21hMJ21QIu4EjLlhCs8997vafdWxoJGQeyULsG02zQjXXZOiULgzlFV9gN4RlOb/EOoSDx96P/EAwNs= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2622; 6:I4yWRA6HQjYDoeMj1HHPnvePDEAEpV5rPMxLKMSOKmtlXDPH2tDAa6+o/dLEka60AIcTCpyMji71DbbhvcdWII3YfER2pyhVnqHPrYInSc1xC+L02aiWoevugXqGgqQZu+ZGFULzxavJx7lRnxKxahpR0tbEoXKZeWHWr/0clUNs/ydBWc7/At8YBXmZP205Tg9g3Ms9CdbeDsyHcLrd00X5Tbb2/rOfyD1UWeI/iKG87sGHNbJB27s6zbrDTiUMJ2bkS/AkcAuNxPzPEhz9reMm+ObtmpSs+0bKiptUdFjiz9TJUK9x5Ym5z52SLWsq9iSwZkXlxAbaJWcrrphmbK+QPGCwXxbYRDWhcD9EiVLEImRZc7InFuNLyROvohUy6sOwPrlftFJqR+zWDvpd+IHcRpV2Usa6Vz4ZkCFh5or2Eu7ykbRABwinJfg/gYdN0n5/EApGXh9KMWZqaEoVLg==; 5:OVxOY6CAQ43qTsLayy7w0UlLh68Q4sOaahmb9xjWa8HlUb7WQJXJigfsFxWF6ibAaBd/CefDPTw6PoOMyBi+d3ED0u5V/wcrnbfVeDlGcWyC5YtDZiuiMGnZol0hOgTevof2OBZUwRMoegsKDRyVHa1j4reudRk8AoBIJT8IBZA=; 7:X3Scoaa168iGkHGJltkcp7hvOukM+vXJUtfQBIWD9Q0GVuNgK1pdDoLrPTMl8Uf3+lMPhjyBKsA/Q3Xq0qPk/AQ3C4g9RAbRhT0fhWRrmyFxRa+flAg15Axv0EJPOj3MPFkYWLjBTioqIPLnl48eIN2JDbW7JX1+RKCw1aob//QHCFpDSAtIeMze9aRbD4+CeBZnX2gTLlVF7gvKU7nQukwMUPeSTL59jcUP/PTxZV8vANqxbk7PMJ3wXdWnSuAo SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: janustech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2018 14:28:30.3611 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51f43407-c89f-425d-99b0-08d5f23ae5f4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 34eb020e-3cf3-43a1-afeb-f5cf1310628e X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2622 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.70.133 Subject: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Leonid Bloch , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Leonid Bloch --- docs/qcow2-cache.txt | 3 +++ qemu-options.hx | 10 ++++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index 8a09a5cc5f..3673f2be0e 100644 --- a/docs/qcow2-cache.txt +++ b/docs/qcow2-cache.txt @@ -130,6 +130,9 @@ There are a few things that need to be taken into account: memory as possible to the L2 cache before increasing the refcount cache size. +- At most two of "l2-cache-size", "refcount-cache-size", and "cache-size" + can be set simultaneously. + Unlike L2 tables, refcount blocks are not used during normal I/O but only during allocations and internal snapshots. In most cases they are accessed sequentially (even during random guest I/O) so increasing the diff --git a/qemu-options.hx b/qemu-options.hx index b1bf0f485f..13ece21cb6 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -752,15 +752,17 @@ image file) @item cache-size The maximum total size of the L2 table and refcount block caches in bytes -(default: 1048576 bytes or 8 clusters, whichever is larger) @item l2-cache-size -The maximum size of the L2 table cache in bytes -(default: 4/5 of the total cache size) +The maximum size of the L2 table cache. +(default: if cache-size is not defined - 1048576 bytes or 8 clusters, whichever +is larger; otherwise, as large as possible or needed within the cache-size, +while permitting the requested or the minimal refcount cache size) @item refcount-cache-size The maximum size of the refcount block cache in bytes -(default: 1/5 of the total cache size) +(default: 4 times the cluster size, or any portion of the cache-size, if it is +specified and large enough, left over after allocating the full L2 cache) @item cache-clean-interval Clean unused entries in the L2 and refcount caches. The interval is in seconds.