From patchwork Wed Aug 8 22:11:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonid Bloch X-Patchwork-Id: 10560515 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A178413B4 for ; Wed, 8 Aug 2018 22:13:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 942B72AF13 for ; Wed, 8 Aug 2018 22:13:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 87D882B05E; Wed, 8 Aug 2018 22:13:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EC79A2AF13 for ; Wed, 8 Aug 2018 22:13:29 +0000 (UTC) Received: from localhost ([::1]:45681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnWht-0002SG-3M for patchwork-qemu-devel@patchwork.kernel.org; Wed, 08 Aug 2018 18:13:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnWgf-0002R9-Fu for qemu-devel@nongnu.org; Wed, 08 Aug 2018 18:12:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnWgb-00026j-UT for qemu-devel@nongnu.org; Wed, 08 Aug 2018 18:12:13 -0400 Received: from mail-co1nam03on0114.outbound.protection.outlook.com ([104.47.40.114]:31488 helo=NAM03-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnWgb-00025R-Mk; Wed, 08 Aug 2018 18:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janustech.onmicrosoft.com; s=selector1-janustech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pLHx9xKaBOiDTV2a45vGIWo+W90AZrxjHPn623UNZ8o=; b=sfv4WbVmigvgVMNOFu5+A/uXtUGn7+biya40VPMOagXQYi5ZwIPgFsDrtfV7oV7ycZ2Zr9idZAxYfi2om4rIRM2pvtDrMgKG4hcC53pmygIraThfHp3XBB8ueLMNAnQYNd9aCQmB0OT1Ym5MpeNJ6h6qcHaPccoT9Mbkkmk1zWo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=lbloch@janustech.com; Received: from Jupiter.local (141.226.29.227) by CY1PR07MB2620.namprd07.prod.outlook.com (2a01:111:e400:c637::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Wed, 8 Aug 2018 22:12:05 +0000 From: Leonid Bloch To: qemu-devel@nongnu.org Date: Thu, 9 Aug 2018 01:11:34 +0300 Message-Id: <20180808221138.5770-2-lbloch@janustech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180808221138.5770-1-lbloch@janustech.com> References: <20180808221138.5770-1-lbloch@janustech.com> MIME-Version: 1.0 X-Originating-IP: [141.226.29.227] X-ClientProxiedBy: AM0PR01CA0018.eurprd01.prod.exchangelabs.com (2603:10a6:208:69::31) To CY1PR07MB2620.namprd07.prod.outlook.com (2a01:111:e400:c637::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2afaa91-f6be-47a2-8869-08d5fd7bfac6 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(7021125)(8989117)(5600074)(711020)(4534165)(7022125)(4603075)(4627221)(201702281549075)(8990107)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2620; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2620; 3:yfTQxrV8+Il3yo0h+sE4dl84QDN9ewH9r4YOt812nbIM1m+xDOkW2nyn2tGFGxnpJHddO6K2AKdpYQ3Xts5VVHcg7gD6/sImQ7WxwrjB+9CIy7PGPEHDrQAPhjXFTqmQzFbzY6Kw0OPVF7vfISWH29bv5KfoKV+uCv4qX7qd84MHaVq8AC1ibEK/AoG5zyIXjHF0TVRaihdfYQoA0fBnytBtn/z2MeiEWY7yuDJFVog5fDCzcnQexX2rDIh4pV5O; 25:yOyp+91ylrCkDyHnqAxnr8EQpTfHmtGi3yD/isvBhSBiuUmh0y2l9F9sXWxmyqFrCXTdk0FgP5PMFn9WlpSQX5Tu13U4Msa4a2WwYIK/XcZswQEEoHy6fTOFbrTRks26c6L65EoEBVzUyCZkyW0oMTDWlViEFG5JXzUFRepZMRoodX2gNij38VkH80LlRfvrG2xhXRxiRlQmZZ08qFCCUMvXPYBHvttwLi+XJQUHi2RgXnDfIFF1Y5pDzizhy8y5nxDKRNh1fFqWJNmwGONsgGrLe9nC0GPJ2luaH6gUH7tPFptqKtQ3qXl2eb+Awd27l5iwWAf4c58x06RWxhpjjQ==; 31:nxqTmyYd9B6p6yqLPzfDjHxUxSwSzg9AogaU8qqRsrJHHPR7hYeebLftH5dlI+UyXeGEgge1r3rbEM3z3AJtB1z4uZr+cY0BWVKW1WB+6Q0NdShdvkahjAYYlf6mBinoxZsveKvXW9vXWRe0+fNPQ1p1rucC6CR1xUf1UTalGRyOJnLNGx8nuu8IbBocHwrCcRXa5ToJFQyXGyvGTDhhFJZp7H8b8Qq5U83hXIQSRVI= X-MS-TrafficTypeDiagnostic: CY1PR07MB2620: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(149027)(150027)(6041310)(20161123564045)(20161123562045)(2016111802025)(20161123558120)(20161123560045)(6043046)(6072148)(201708071742011)(7699016); SRVR:CY1PR07MB2620; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2620; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2620; 4:yjU8GMx6sMi8AOVDyLetpILFJCuwI5oauVtNAsEmas9jBpTbZy0nJa4gVxqUtPIExvMmZtrSlCdYIy6RE7gKZeBSm7iPey9i8hcHf9E2wP3Y7gH0jlbRNzdVDQ2hIVwS2HZd07Szq7Zz9nq6LqgHjKU8aK1KqgqmG3m/khb3Xu2PWqrTTlX7bP+U7V58K/037mgfOvu2WNGCYDsmsWoIwwQhMSsT0kgrHv8hVNjDb7V1jUQDJ2v1Pq9Uc6xmhToc+xYj7V3QsDXdm57SZI52Ag== X-Forefront-PRVS: 07584EDBCD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(346002)(366004)(376002)(39830400003)(396003)(136003)(189003)(199004)(52116002)(6506007)(386003)(106356001)(97736004)(53936002)(68736007)(2351001)(105586002)(186003)(66066001)(11346002)(47776003)(14444005)(446003)(81166006)(551984002)(8936002)(16526019)(76176011)(2616005)(956004)(305945005)(6512007)(476003)(7736002)(81156014)(26005)(8676002)(486006)(51416003)(36756003)(86362001)(575784001)(6486002)(50226002)(4326008)(107886003)(2361001)(50466002)(1076002)(478600001)(6916009)(6666003)(48376002)(6116002)(5660300001)(54906003)(16586007)(316002)(2906002)(3846002)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR07MB2620; H:Jupiter.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: janustech.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2620; 23:a6E04RE/e3P7EVmGWGYcVWY8TlRXGVnaeObb+QPw9?= fdlnz42Dtaob3S+OYevITV29kj0koruPVNGdXWHZYXJ/DEpZWrWuCG4Q831tKUtkGQbncqHBDE9+56Ug9Dlc83l5wa/NAsIYbGJxCC4jEvpFHgjdlyRilsuHPxniKaS6pXwO5NKYAUDmNesZ05+GbD3WgM0QhDGTdA38bu3MWa9aJGAwKsscg6XlRiPUuwaGCjvwGTFC78F1v6D5DTaVuz1Sn5U9WQus2dwvUmk2itZDV0DuLLYvKpjlPsd5682bN78Ex++MnRd2nyWYPRYfsXn1NtcBPY3S/9P5fqYANvosiVMWg0vBHNkQY8hJ3/tkP54SDBeVyEIF70px0+C9ZzrKLVFo0KRIAlyOBUde26sPkwzBJKGXpd4esYFpKcGU8iRpY9y9HctlEYuLI7WgQzR6qRoSAV/4hzQkj4Mv72GwbekqQV3FFQLEM/CRMj6xiw/PZUbscA52HvQke05bSgKqIHU3mXZirMh4O+dPBm7bkbHC/fvZ2AACCDjE1q753k2zBFlADC2DD9nFzOCOh0uL2pqJj4KfbidkZa0wLv1nizLy5zkosC7jqODQevlz7j3UhclWxM6Wxym5hdEetMlo5rhY+4zz6FXjtViY3X2updir8I/xfL/we+lCELNxkPR+I9d7nUINp1/bvglEJlftrJYmKKoTf9B9OsU6G1RB+d2PVJZTBepHmY3Hiw/cb1vXVhYSQZE4kUtf74wsxtoB3FVpAK3r3ftSWBTo7Ix504tGZe/8Vw1T/R3KkwvmDinuNAFMtUkSwJZEZmNiVjZpRItmfYM1BBn0K2e0UUp5wEs/jyaUa1qhfhC4LhDd/DKYbLacJhG+ArVb+MWnw2u4TGGRSOGcERe3yuN6F81ihJM6UKzYdLyhEKN9AMM2TBPTVtQl8Ys3Ps1prvg5dSx/KlbhgzoNDgFpmDoHdJbmas2WdFH3OvMHuIe5EKj37npLdz4duXs+3vQwMJRK3AinMIYXUTyfoJspWsPeCBejipg5q2iiaBr/LYceR0Uy5Sdqwaz/XlBoCR/iIeXmuqQ7vWhUQoJxqv1r811dgt3A9ojFFZE8TComTJinFAcl16Fxo5wfdtKrNBWyB7eG15Bt7C4IXnJPPexJVoTgId0Mwx+X3ZuKCC4qToVcwR74U3AwMwxa0KzEa4k3t/yWFcRgljwhz0Xq6tXrVwniPuKIdkAYyhOHY8Cm7M93pyTb/TOSbh9xVwjqS1xu9TzNCbx3d8bZxjmYHCWDgQIdDWTxiUwTmH5VAwgAuy/UN2xxlUcVglnc5PRaJhlWOfQZcMC X-Microsoft-Antispam-Message-Info: pU78tOBd4ETIXvO3fOn2roibFx3RLfs+CNgts5OgGqWNSBHGVsVc6jvTNas4RmXv7jxh7pQDUsm41aRyEEaJwSf7yko2J4DU+XQa17QDV+1WmnYEv5Ho3uUk4SgeehzCmqwUEiynvHZ+5X+m621vtcLV4yzGrNLcjcl+BfhYR53Qv8xLywFik4Tzb2ruuPZs+GwlT+DGtOSyALtUKmg9O7VVG2KOgt5IMDk2P3lL1n52tCMrI2sMFSCnNklStbie2joO6YZqq2X5SjPa6tgH/1N9Ny+Nt5FHtwznqUjP4VA2pZfda/w7p29WvWSm/Xk53ysBlnXWr8UvTBW70fI3oKpjeZ3TagoKlHjUHCLsq/0= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2620; 6:JNtqdX3S6U2WiSWVudYVkrbXrwLOr3eoOaNitzYcctRCdzsFg+bd6fMx5BlN5CUgVGqVpgjfvHUlk6JpwvuVbIP0ertadqk9d68bWNLjKHy067wWuq1djgcFmY3U1BVfuLLJPoIm1SjR7gz1jgs0qbWRDfmpaToBQJJ8kXJ12DEblBo8FH2NEv3sUYbWbAP7G4pJVgnULZkRGPaO4r84220ibbJahpR7erMd46wkCRRFgenYLWhucPq6Fb2t2GMydJ6VK3DvCGG8TDaFOd0dWrK/l629xaMGZdcZCV6oNgN9ZsTQ8i37Beb5/+Pj4sXnjidxIm7ZPG9d1PISjeC4ieeR6YB+siWq77bU60XmyXWhoTdCKuab50r5al3oFFaQzWIsM0TTU1S8TAgoZiKnKjMse5hve9/sMUM8xkkP/G7mPAqiraeoTEaOA0Y0TtDAWhgoYcgM85bfir6MogXJug==; 5:reebILx51ECWpOmncWP5sUmE0WFvmcGs/XE16nw56nG0XP63YZ1tkOk8xse+2owTSSQMqOr8DGKNUfcLHJFjQplga4OPjAk51xtBbLdZv7yrTqWxkJzl09sO+bSAlIX5Fmzsl7TW9W8CJb8pmpzoNj4TxX4ykCdVCBD4uicH1K4=; 7:1acyW66tfvUlHlTb3z81E58unRGlH/lwqPnkSk174+zXElEHdphOwc1Ly9wn4mzs5MugwJdjIc9uOoRdDCdU8VHI1s5BMoYms9rtoeoSPgSsIjGRp6IX4IWy7w1xlLX9lTwmgjIE9ocwCe66IqCYNwPatDRe3s6RxBJe3lPFKDW3v8/sSlXcRSngFRLYW3n0eMFVlduXc+4jreJQeuNlorPhA+/fVoOszxE2xAP2N6c71zx+F53m/KAw6sQQ99Kg SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: janustech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2018 22:12:05.4677 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b2afaa91-f6be-47a2-8869-08d5fd7bfac6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 34eb020e-3cf3-43a1-afeb-f5cf1310628e X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2620 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.40.114 Subject: [Qemu-devel] [PATCH v4 1/5] qcow2: Options' documentation fixes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz , Leonid Bloch Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Leonid Bloch --- docs/qcow2-cache.txt | 3 +++ qemu-options.hx | 9 ++++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index 8a09a5cc5f..5bf2a8ad29 100644 --- a/docs/qcow2-cache.txt +++ b/docs/qcow2-cache.txt @@ -130,6 +130,9 @@ There are a few things that need to be taken into account: memory as possible to the L2 cache before increasing the refcount cache size. + - At most two of "l2-cache-size", "refcount-cache-size", and "cache-size" + can be set simultaneously. + Unlike L2 tables, refcount blocks are not used during normal I/O but only during allocations and internal snapshots. In most cases they are accessed sequentially (even during random guest I/O) so increasing the diff --git a/qemu-options.hx b/qemu-options.hx index b1bf0f485f..f6804758d3 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -752,15 +752,18 @@ image file) @item cache-size The maximum total size of the L2 table and refcount block caches in bytes -(default: 1048576 bytes or 8 clusters, whichever is larger) +(default: the sum of l2-cache-size and refcount-cache-size) @item l2-cache-size The maximum size of the L2 table cache in bytes -(default: 4/5 of the total cache size) +(default: if cache-size is not defined - 1048576 bytes or 8 clusters, whichever +is larger; otherwise, as large as possible or needed within the cache-size, +while permitting the requested or the minimal refcount cache size) @item refcount-cache-size The maximum size of the refcount block cache in bytes -(default: 1/5 of the total cache size) +(default: 4 times the cluster size; or if cache-size is specified, the part of +it which is not used for the L2 cache) @item cache-clean-interval Clean unused entries in the L2 and refcount caches. The interval is in seconds.