diff mbox series

[PULL,2/2] nvme: correct locking around completion

Message ID 20181012015026.17441-3-famz@redhat.com (mailing list archive)
State New, archived
Headers show
Series [PULL,1/2] iothread: fix crash with invalid properties | expand

Commit Message

Fam Zheng Oct. 12, 2018, 1:50 a.m. UTC 
From: Paolo Bonzini <pbonzini@redhat.com>

nvme_poll_queues is already protected by q->lock, and
AIO callbacks are invoked outside the AioContext lock.
So remove the acquire/release pair in nvme_handle_event.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20180814062739.19640-1-pbonzini@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/nvme.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/block/nvme.c b/block/nvme.c
index 781d77d6d2..29294038fc 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -489,10 +489,8 @@  static void nvme_handle_event(EventNotifier *n)
     BDRVNVMeState *s = container_of(n, BDRVNVMeState, irq_notifier);
 
     trace_nvme_handle_event(s);
-    aio_context_acquire(s->aio_context);
     event_notifier_test_and_clear(n);
     nvme_poll_queues(s);
-    aio_context_release(s->aio_context);
 }
 
 static bool nvme_add_io_queue(BlockDriverState *bs, Error **errp)