| Message ID | 20181012165347.2117-4-crosa@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bootstrap Python venv and acceptance/functional tests | expand |
Hi Cleber, On 12/10/2018 18:53, Cleber Rosa wrote: > This enables the execution of the acceptance tests on Travis. > > Because the Travis environment is based on Ubuntu Trusty, it requires > the python3-pip and python3.4-venv packages. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > .travis.yml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index 95be6ec59f..f55f799c52 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -36,6 +36,8 @@ addons: > - liburcu-dev > - libusb-1.0-0-dev > - libvte-2.90-dev > + - python3-pip > + - python3.4-venv I'd prefer not put Python specific version in the generic addons list... > - sparse > - uuid-dev > - gcovr > @@ -117,6 +119,9 @@ matrix: > - env: CONFIG="--target-list=x86_64-softmmu" > python: > - "3.6" > + # Acceptance (Functional) tests > + - env: CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu" > + TEST_CMD="make AVOCADO_SHOW=app check-acceptance" ... but rather in the single test that requires it: addons: apt: packages: - python3-pip - python3.4-venv Alex what do you prefer? > # Using newer GCC with sanitizers > - addons: > apt: > Both configs: Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > Hi Cleber, > > On 12/10/2018 18:53, Cleber Rosa wrote: >> This enables the execution of the acceptance tests on Travis. >> >> Because the Travis environment is based on Ubuntu Trusty, it requires >> the python3-pip and python3.4-venv packages. >> >> Signed-off-by: Cleber Rosa <crosa@redhat.com> >> --- >> .travis.yml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/.travis.yml b/.travis.yml >> index 95be6ec59f..f55f799c52 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -36,6 +36,8 @@ addons: >> - liburcu-dev >> - libusb-1.0-0-dev >> - libvte-2.90-dev >> + - python3-pip >> + - python3.4-venv > > I'd prefer not put Python specific version in the generic addons list... > >> - sparse >> - uuid-dev >> - gcovr >> @@ -117,6 +119,9 @@ matrix: >> - env: CONFIG="--target-list=x86_64-softmmu" >> python: >> - "3.6" >> + # Acceptance (Functional) tests >> + - env: CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu" >> + TEST_CMD="make AVOCADO_SHOW=app check-acceptance" > > ... but rather in the single test that requires it: > > addons: > apt: > packages: > - python3-pip > - python3.4-venv > > Alex what do you prefer? Out-of-band package managers can potentially add complexity to the build environment so we should limit them to where they are needed. We really need to transition to using docker for all out build environments as the default Travis environment is getting steadily crustier and out of date. We need to solve the caching/hub problem first though. With the move to the test: Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > >> # Using newer GCC with sanitizers >> - addons: >> apt: >> > > Both configs: > Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> -- Alex Bennée
diff --git a/.travis.yml b/.travis.yml index 95be6ec59f..f55f799c52 100644 --- a/.travis.yml +++ b/.travis.yml @@ -36,6 +36,8 @@ addons: - liburcu-dev - libusb-1.0-0-dev - libvte-2.90-dev + - python3-pip + - python3.4-venv - sparse - uuid-dev - gcovr @@ -117,6 +119,9 @@ matrix: - env: CONFIG="--target-list=x86_64-softmmu" python: - "3.6" + # Acceptance (Functional) tests + - env: CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu" + TEST_CMD="make AVOCADO_SHOW=app check-acceptance" # Using newer GCC with sanitizers - addons: apt:
This enables the execution of the acceptance tests on Travis. Because the Travis environment is based on Ubuntu Trusty, it requires the python3-pip and python3.4-venv packages. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- .travis.yml | 5 +++++ 1 file changed, 5 insertions(+)