| Message ID | 20181109150710.31085-5-crosa@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Record Python version and misc test/CI fixes | expand |
On 11/9/18 9:07 AM, Cleber Rosa wrote: > The "check" target is not a target that will run all other tests > listed, so in order to be accurate it's necessary to list those that > will run. The same is true for "check-clean". > > Then, to give a better visual impression of the differences in the > various targets, let's add empty lines. > > Finally, a small (and hopeful) grammar fix from a non-native speaker. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/Makefile.include | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
On 9/11/18 16:07, Cleber Rosa wrote: > The "check" target is not a target that will run all other tests > listed, so in order to be accurate it's necessary to list those that > will run. The same is true for "check-clean". > > Then, to give a better visual impression of the differences in the > various targets, let's add empty lines. > > Finally, a small (and hopeful) grammar fix from a non-native speaker. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/Makefile.include | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index c0a341c923..552faf9bbe 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -3,7 +3,8 @@ > check-help: > @echo "Regression testing targets:" > @echo > - @echo " $(MAKE) check Run all tests" > + @echo " $(MAKE) check Run unit, qapi-schema, qtest and decodetree" > + @echo > @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target" > @echo " $(MAKE) check-qtest Run qtest tests" > @echo " $(MAKE) check-unit Run qobject tests" > @@ -12,12 +13,13 @@ check-help: > @echo " $(MAKE) check-block Run block tests" > @echo " $(MAKE) check-tcg Run TCG tests" > @echo " $(MAKE) check-acceptance Run all acceptance (functional) tests" > + @echo > @echo " $(MAKE) check-report.html Generates an HTML test report" > @echo " $(MAKE) check-venv Creates a Python venv for tests" > - @echo " $(MAKE) check-clean Clean the tests" > + @echo " $(MAKE) check-clean Clean the tests and related data" > @echo > @echo "Please note that HTML reports do not regenerate if the unit tests" > - @echo "has not changed." > + @echo "have not changed." > @echo > @echo "The variable SPEED can be set to control the gtester speed setting." > @echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be" >
On Fri, Nov 09, 2018 at 10:07:10AM -0500, Cleber Rosa wrote: > The "check" target is not a target that will run all other tests > listed, so in order to be accurate it's necessary to list those that > will run. The same is true for "check-clean". > > Then, to give a better visual impression of the differences in the > various targets, let's add empty lines. > > Finally, a small (and hopeful) grammar fix from a non-native speaker. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
On 11/09/2018 01:07 PM, Cleber Rosa wrote: > The "check" target is not a target that will run all other tests > listed, so in order to be accurate it's necessary to list those that > will run. The same is true for "check-clean". > > Then, to give a better visual impression of the differences in the > various targets, let's add empty lines. > > Finally, a small (and hopeful) grammar fix from a non-native speaker. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/Makefile.include | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index c0a341c923..552faf9bbe 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -3,7 +3,8 @@ > check-help: > @echo "Regression testing targets:" > @echo > - @echo " $(MAKE) check Run all tests" > + @echo " $(MAKE) check Run unit, qapi-schema, qtest and decodetree" Hi Cleber! I would leave "tests" to the description, then it becomes: "Run unit, qapi-schema, qtest and decodetree tests" Note: there isn't an entry for check-decodetree on the help. You may want to address it in this patch (or I can send in a separate patch). Overall, this patch series looks good for me. I tested patches 1, 2 and 4 on Fedora 29. So: Tested-by: Wainer dos Santos Moschetta <wainersm@redhat.com> - Wainer > + @echo > @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target" > @echo " $(MAKE) check-qtest Run qtest tests" > @echo " $(MAKE) check-unit Run qobject tests" > @@ -12,12 +13,13 @@ check-help: > @echo " $(MAKE) check-block Run block tests" > @echo " $(MAKE) check-tcg Run TCG tests" > @echo " $(MAKE) check-acceptance Run all acceptance (functional) tests" > + @echo > @echo " $(MAKE) check-report.html Generates an HTML test report" > @echo " $(MAKE) check-venv Creates a Python venv for tests" > - @echo " $(MAKE) check-clean Clean the tests" > + @echo " $(MAKE) check-clean Clean the tests and related data" > @echo > @echo "Please note that HTML reports do not regenerate if the unit tests" > - @echo "has not changed." > + @echo "have not changed." > @echo > @echo "The variable SPEED can be set to control the gtester speed setting." > @echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be"
diff --git a/tests/Makefile.include b/tests/Makefile.include index c0a341c923..552faf9bbe 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -3,7 +3,8 @@ check-help: @echo "Regression testing targets:" @echo - @echo " $(MAKE) check Run all tests" + @echo " $(MAKE) check Run unit, qapi-schema, qtest and decodetree" + @echo @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target" @echo " $(MAKE) check-qtest Run qtest tests" @echo " $(MAKE) check-unit Run qobject tests" @@ -12,12 +13,13 @@ check-help: @echo " $(MAKE) check-block Run block tests" @echo " $(MAKE) check-tcg Run TCG tests" @echo " $(MAKE) check-acceptance Run all acceptance (functional) tests" + @echo @echo " $(MAKE) check-report.html Generates an HTML test report" @echo " $(MAKE) check-venv Creates a Python venv for tests" - @echo " $(MAKE) check-clean Clean the tests" + @echo " $(MAKE) check-clean Clean the tests and related data" @echo @echo "Please note that HTML reports do not regenerate if the unit tests" - @echo "has not changed." + @echo "have not changed." @echo @echo "The variable SPEED can be set to control the gtester speed setting." @echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be"
The "check" target is not a target that will run all other tests listed, so in order to be accurate it's necessary to list those that will run. The same is true for "check-clean". Then, to give a better visual impression of the differences in the various targets, let's add empty lines. Finally, a small (and hopeful) grammar fix from a non-native speaker. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/Makefile.include | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)