From patchwork Thu Nov 22 12:14:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuval Shaia X-Patchwork-Id: 10694089 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9132313BB for ; Thu, 22 Nov 2018 12:26:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F7FC2B1B7 for ; Thu, 22 Nov 2018 12:26:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 738EF2B258; Thu, 22 Nov 2018 12:26:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 268E12B1B7 for ; Thu, 22 Nov 2018 12:26:30 +0000 (UTC) Received: from localhost ([::1]:45476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPo3x-0002cJ-DK for patchwork-qemu-devel@patchwork.kernel.org; Thu, 22 Nov 2018 07:26:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPntc-0000RX-48 for qemu-devel@nongnu.org; Thu, 22 Nov 2018 07:15:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPntX-00029q-CA for qemu-devel@nongnu.org; Thu, 22 Nov 2018 07:15:47 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:53512) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPntU-0001ZV-0j for qemu-devel@nongnu.org; Thu, 22 Nov 2018 07:15:40 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAMCE5QH067904; Thu, 22 Nov 2018 12:15:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=QKFfTWQFAfw0bgQGiNLG9JBtm03f/pSP3g3+a2oAJpw=; b=T3vFVHvtgTd6JHPxU5T7HvPXuAcGYZkEI0r2muZ1UyGfmrwQUWU87mZrBvjdmEQQXqlf C8sqDimi4EN4VJgozUdCsyhYKEZPy16+zvy2UHztdajSpPrDstgxhWTQixS96as2WRRc j4/QqxZ3iglATZLkLRO6hgvxE/45XnsTh7PoX2U6b69fXOznSP5sS7ag8FxINMfwJWO7 fXDd6JuCevAQu0OsFRh8eLnOhYuQoXDOjVW4eCsA7orD0Z5ky22ERfwhCQb1htYe0fdD BzT1OjidAZFmENcFk8X5h3mq5Y/2gc3EhqBQG2bEKDSGcCyBG7PYoPBZdb9amKO+Mini 1A== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2ntadu6nug-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Nov 2018 12:15:30 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAMCFT3S001456 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Nov 2018 12:15:29 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wAMCFT2g004266; Thu, 22 Nov 2018 12:15:29 GMT Received: from localhost.localdomain (/77.138.186.148) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 22 Nov 2018 04:15:29 -0800 From: Yuval Shaia To: yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com, dmitry.fleytman@gmail.com, jasowang@redhat.com, eblake@redhat.com, armbru@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, shamir.rabinovitch@oracle.com, cohuck@redhat.com Date: Thu, 22 Nov 2018 14:14:01 +0200 Message-Id: <20181122121402.13764-24-yuval.shaia@oracle.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181122121402.13764-1-yuval.shaia@oracle.com> References: <20181122121402.13764-1-yuval.shaia@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9084 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811220111 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 156.151.31.86 Subject: [Qemu-devel] [PATCH v5 23/24] hw/pvrdma: Do not clean resources on shutdown X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP All resources are already cleaned at rm_fini phase. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 6a1e39d4c0..8ab25e94b1 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -1075,28 +1075,9 @@ static int mad_init(RdmaBackendDev *backend_dev, CharBackend *mad_chr_be) static void mad_stop(RdmaBackendDev *backend_dev) { - QObject *o_ctx_id; - unsigned long cqe_ctx_id; - BackendCtx *bctx; - - pr_dbg("Closing MAD\n"); + pr_dbg("Stopping MAD\n"); disable_rdmacm_mux_async(backend_dev); - - /* Clear MAD buffers list */ - qemu_mutex_lock(&backend_dev->recv_mads_list.lock); - do { - o_ctx_id = qlist_pop(backend_dev->recv_mads_list.list); - if (o_ctx_id) { - cqe_ctx_id = qnum_get_uint(qobject_to(QNum, o_ctx_id)); - bctx = rdma_rm_get_cqe_ctx(backend_dev->rdma_dev_res, cqe_ctx_id); - if (bctx) { - rdma_rm_dealloc_cqe_ctx(backend_dev->rdma_dev_res, cqe_ctx_id); - g_free(bctx); - } - } - } while (o_ctx_id); - qemu_mutex_unlock(&backend_dev->recv_mads_list.lock); } static void mad_fini(RdmaBackendDev *backend_dev)