| Message ID | 20190114225306.21569-1-samuel.thibault@ens-lyon.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20190114225306.21569-1-samuel.thibault@ens-lyon.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190114225306.21569-1-samuel.thibault@ens-lyon.org
Subject: [Qemu-devel] [PULLv3 00/65] slirp updates
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
017fc2f slirp: check data length while emulating ident function
e87d727 slirp: Mark debugging calls as unlikely
aa49d8f slirp: call into g_debug() for DEBUG macros
01dbc97 slirp: set G_LOG_DOMAIN
8a5a5ed build-sys: use a separate slirp-obj-y && slirp.mo
13d5ea9 slirp: add clock_get_ns() callback
753120f slirp: factor out guestfwd addition checks
2634d85 slirp: replace DEBUG_ARGS with DEBUG_ARG
4ba0640 slirp: remove remaining DEBUG blocks
6df5752 slirp: use %p for pointers format
25e8eec slirp: introduce SLIRP_DEBUG environment variable
e6ba465 slirp: always build with debug statements
17daeeb slirp: no need to make DPRINTF conditional on DEBUG
212865f slirp: replace a DEBUG block with WITH_ICMP_ERROR_MSG
99583b0 slirp: replace some fprintf() with DEBUG_MISC
9dc44cc slirp: replace a fprintf with g_critical()
284b5e8 slirp: use virtual time for packet expiration
17a297b slirp: rename exec_list
495e28c slirp: drop <Vista compatibility
ae1e716 slirp: Enable fork_exec support on Windows
33ab40a slirp: replace error_report() with g_critical()
6806bca slirp: simplify fork_exec()
1a26e8d glib-compat: add g_spawn_async_with_fds() fallback
e5bf42a net: do not depend on slirp internals
29a48b3 slirp: replace ARRAY_SIZE with G_N_ELEMENTS
7b883d6 slirp: remove dead TCP_ACK_HACK code
babb0f4 slirp: NULL is defined by stddef.h
98827e5 slirp: remove unused sbflush()
9f0401e slirp: remove #if notdef dead code
6d7b26d slirp: add a callback to log guest errors
40b1f32 slirp: improve a bit the debug macros
a2e7ea0 slirp: replace error_report() with g_critical()
1ab394c slirp: remove unused global slirp_instance
b6edd97 slirp: replace compile time DO_KEEPALIVE
012ad08 slirp: replace SIZEOF_CHAR_P with glib equivalent
a72ab14 slirp: replace HOST_WORDS_BIGENDIAN with glib equivalent
828a604 slirp: remove unused HAVE_INET_ATON
1b7ac8e slirp: remove unused DECLARE_IOVEC
d280dc0 slirp: remove HAVE_SYS_FILIO_H
c63485d slirp: remove HAVE_SYS_IOCTL_H
ccc7855 slirp: remove unused HAVE_SYS_SELECT_H
abdc8cf slirp: remove unused HAVE_SYS_WAIT_H
f855de1 slirp: remove unused HAVE_ARPA_INET_H
a6d2f4d slirp: remove unused HAVE_SYS_STROPTS_H
23c2b23 slirp: remove NO_UNIX_SOCKETS
69f38ed slirp: remove unused HAVE_SYS_BITYPES_H
789792c slirp: remove HAVE_SYS_SIGNAL_H
9bc89a4 slirp: remove the disabled readv()/writev() code path
eb61b82 slirp: remove FULL_BOLT
94ecb18 slirp: remove PROBE_CONN dead-code
4d2d201 slirp: use a callback structure to interface with qemu
2eb292d slirp: remove unused M_TRAILINGSPACE
251a687 slirp: move socket pair creation in helper function
e577000 slirp: add tftp tracing
cf883de slirp: remove dead declarations
ac8b25d slirp: replace the poor-man string split with g_strsplit()
c5d60a6 slirp: fix slirp_add_exec() leaks
89c3eaf slirp: remove Monitor dependency, return a string for info
2da06b1 slirp: move internal function declarations
e1ddac4 slirp: rename /extra/chardev
e20771f slirp: remove unused EMU_RSH
6ba5031 slirp: use a dedicated field for chardev pointer
f67ecc5 slirp: replace ex_pty with ex_chardev
e47b856 slirp: remove do_pty from fork_exec()
b91bf63 slirp: associate slirp_output callback with the Slirp context
=== OUTPUT BEGIN ===
1/65 Checking commit b91bf63f6da4 (slirp: associate slirp_output callback with the Slirp context)
2/65 Checking commit e47b856046a8 (slirp: remove do_pty from fork_exec())
3/65 Checking commit f67ecc52d2f8 (slirp: replace ex_pty with ex_chardev)
ERROR: code indent should never use tabs
#22: FILE: slirp/misc.c:56:
+^I(*ex_ptr)->ex_chardev = do_pty == 3;$
ERROR: code indent should never use tabs
#35: FILE: slirp/misc.h:12:
+^Iint ex_chardev;$
total: 2 errors, 0 warnings, 40 lines checked
Patch 3/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/65 Checking commit 6ba5031c5183 (slirp: use a dedicated field for chardev pointer)
ERROR: code indent should never use tabs
#77: FILE: slirp/misc.c:53:
+^I*ex_ptr = g_new0(struct ex_list, 1);$
ERROR: code indent should never use tabs
#82: FILE: slirp/misc.c:56:
+^Iif (chardev) {$
ERROR: code indent should never use tabs
#83: FILE: slirp/misc.c:57:
+^I^I(*ex_ptr)->ex_chardev = chardev;$
ERROR: code indent should never use tabs
#84: FILE: slirp/misc.c:58:
+^I} else {$
ERROR: code indent should never use tabs
#85: FILE: slirp/misc.c:59:
+^I^I(*ex_ptr)->ex_exec = g_strdup(cmdline);$
ERROR: code indent should never use tabs
#86: FILE: slirp/misc.c:60:
+^I}$
ERROR: code indent should never use tabs
#99: FILE: slirp/misc.h:12:
+^Ivoid *ex_chardev;$
total: 7 errors, 0 warnings, 100 lines checked
Patch 4/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/65 Checking commit e20771fed78b (slirp: remove unused EMU_RSH)
6/65 Checking commit e1ddac489c29 (slirp: rename /extra/chardev)
ERROR: "foo * bar" should be "foo *bar"
#39: FILE: slirp/socket.h:70:
+ void * chardev;
total: 1 errors, 0 warnings, 28 lines checked
Patch 6/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/65 Checking commit 2da06b131f4d (slirp: move internal function declarations)
8/65 Checking commit 89c3eaf69442 (slirp: remove Monitor dependency, return a string for info)
9/65 Checking commit c5d60a6957a3 (slirp: fix slirp_add_exec() leaks)
ERROR: code indent should never use tabs
#22: FILE: slirp/misc.h:15:
+^Ichar *ex_exec; /* Command line of what to exec */$
total: 1 errors, 0 warnings, 22 lines checked
Patch 9/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/65 Checking commit ac8b25d5141e (slirp: replace the poor-man string split with g_strsplit())
ERROR: code indent should never use tabs
#26: FILE: slirp/misc.c:91:
+^Ichar **argv;$
ERROR: code indent should never use tabs
#27: FILE: slirp/misc.c:92:
+^Iint ret;$
total: 2 errors, 0 warnings, 33 lines checked
Patch 10/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/65 Checking commit cf883deeb016 (slirp: remove dead declarations)
12/65 Checking commit e577000b30a7 (slirp: add tftp tracing)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57:
new file mode 100644
total: 0 errors, 1 warnings, 33 lines checked
Patch 12/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/65 Checking commit 251a687b9b7a (slirp: move socket pair creation in helper function)
ERROR: code indent should never use tabs
#102: FILE: slirp/misc.c:136:
+^Iint opt, c, sp[2];$
ERROR: code indent should never use tabs
#154: FILE: slirp/misc.c:151:
+^I^Iclosesocket(sp[0]);$
ERROR: code indent should never use tabs
#155: FILE: slirp/misc.c:152:
+^I^Iclosesocket(sp[1]);$
ERROR: code indent should never use tabs
#168: FILE: slirp/misc.c:156:
+^I^Isetsid();$
ERROR: code indent should never use tabs
#169: FILE: slirp/misc.c:157:
+^I^Idup2(sp[1], 0);$
ERROR: code indent should never use tabs
#170: FILE: slirp/misc.c:158:
+^I^Idup2(sp[1], 1);$
ERROR: code indent should never use tabs
#171: FILE: slirp/misc.c:159:
+^I^Idup2(sp[1], 2);$
ERROR: code indent should never use tabs
#172: FILE: slirp/misc.c:160:
+^I^Ifor (c = getdtablesize() - 1; c >= 3; c--)$
ERROR: suspect code indent for conditional statements (16, 19)
#172: FILE: slirp/misc.c:160:
+ for (c = getdtablesize() - 1; c >= 3; c--)
+ close(c);
ERROR: braces {} are necessary for all arms of this statement
#172: FILE: slirp/misc.c:160:
+ for (c = getdtablesize() - 1; c >= 3; c--)
[...]
ERROR: code indent should never use tabs
#173: FILE: slirp/misc.c:161:
+^I^I close(c);$
ERROR: code indent should never use tabs
#181: FILE: slirp/misc.c:173:
+^I^Iso->s = sp[0];$
ERROR: code indent should never use tabs
#182: FILE: slirp/misc.c:174:
+^I^Iclosesocket(sp[1]);$
ERROR: code indent should never use tabs
#196: FILE: slirp/misc.c:176:
+^I^Isocket_set_fast_reuse(so->s);$
ERROR: code indent should never use tabs
#197: FILE: slirp/misc.c:177:
+^I^Iopt = 1;$
WARNING: line over 80 characters
#198: FILE: slirp/misc.c:178:
+ qemu_setsockopt(so->s, SOL_SOCKET, SO_OOBINLINE, &opt, sizeof(int));
ERROR: code indent should never use tabs
#198: FILE: slirp/misc.c:178:
+^I^Iqemu_setsockopt(so->s, SOL_SOCKET, SO_OOBINLINE, &opt, sizeof(int));$
total: 16 errors, 1 warnings, 175 lines checked
Patch 13/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/65 Checking commit 2eb292db9be5 (slirp: remove unused M_TRAILINGSPACE)
15/65 Checking commit 4d2d20166523 (slirp: use a callback structure to interface with qemu)
16/65 Checking commit 94ecb187994c (slirp: remove PROBE_CONN dead-code)
17/65 Checking commit eb61b824d7bc (slirp: remove FULL_BOLT)
18/65 Checking commit 9bc89a4f2a5c (slirp: remove the disabled readv()/writev() code path)
19/65 Checking commit 789792cfe87e (slirp: remove HAVE_SYS_SIGNAL_H)
20/65 Checking commit 69f38ed4447b (slirp: remove unused HAVE_SYS_BITYPES_H)
21/65 Checking commit 23c2b23d572c (slirp: remove NO_UNIX_SOCKETS)
22/65 Checking commit a6d2f4d42343 (slirp: remove unused HAVE_SYS_STROPTS_H)
23/65 Checking commit f855de15d8cf (slirp: remove unused HAVE_ARPA_INET_H)
24/65 Checking commit abdc8cf9f2ff (slirp: remove unused HAVE_SYS_WAIT_H)
25/65 Checking commit ccc7855687b3 (slirp: remove unused HAVE_SYS_SELECT_H)
26/65 Checking commit c63485d789c7 (slirp: remove HAVE_SYS_IOCTL_H)
27/65 Checking commit d280dc058a4b (slirp: remove HAVE_SYS_FILIO_H)
WARNING: architecture specific defines should be avoided
#21: FILE: slirp/slirp.h:39:
+#ifdef __APPLE__
total: 0 errors, 1 warnings, 20 lines checked
Patch 27/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/65 Checking commit 1b7ac8e35ca4 (slirp: remove unused DECLARE_IOVEC)
29/65 Checking commit 828a604413f1 (slirp: remove unused HAVE_INET_ATON)
30/65 Checking commit a72ab1493793 (slirp: replace HOST_WORDS_BIGENDIAN with glib equivalent)
31/65 Checking commit 012ad080d1e0 (slirp: replace SIZEOF_CHAR_P with glib equivalent)
32/65 Checking commit b6edd977f00d (slirp: replace compile time DO_KEEPALIVE)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52:
deleted file mode 100644
ERROR: code indent should never use tabs
#78: FILE: slirp/tcp_input.c:484:
+^Iif (slirp_do_keepalive)$
ERROR: suspect code indent for conditional statements (8, 11)
#78: FILE: slirp/tcp_input.c:484:
+ if (slirp_do_keepalive)
tp->t_timer[TCPT_KEEP] = TCPTV_KEEPINTVL;
ERROR: braces {} are necessary for all arms of this statement
#78: FILE: slirp/tcp_input.c:484:
+ if (slirp_do_keepalive)
[...]
else
[...]
ERROR: code indent should never use tabs
#91: FILE: slirp/tcp_timer.c:265:
+^I^Iif (slirp_do_keepalive && tp->t_state <= TCPS_CLOSE_WAIT) {$
total: 4 errors, 1 warnings, 43 lines checked
Patch 32/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/65 Checking commit 1ab394cb6787 (slirp: remove unused global slirp_instance)
34/65 Checking commit a2e7ea0909cb (slirp: replace error_report() with g_critical())
35/65 Checking commit 40b1f3274db2 (slirp: improve a bit the debug macros)
ERROR: code indent should never use tabs
#68: FILE: slirp/cksum.c:127:
+^I^IDEBUG_ERROR("cksum: out of data\n");$
ERROR: code indent should never use tabs
#69: FILE: slirp/cksum.c:128:
+^I^IDEBUG_ERROR(" len = %d\n", len);$
ERROR: code indent should never use tabs
#199: FILE: slirp/ip_icmp.c:168:
+^IDEBUG_MISC("icmp_input udp_attach errno = %d-%s\n",$
ERROR: space required after that ',' (ctx:VxV)
#200: FILE: slirp/ip_icmp.c:169:
+ errno,strerror(errno));
^
ERROR: code indent should never use tabs
#210: FILE: slirp/ip_icmp.c:191:
+^IDEBUG_MISC("icmp_input udp sendto tx errno = %d-%s\n",$
ERROR: space required after that ',' (ctx:VxV)
#211: FILE: slirp/ip_icmp.c:192:
+ errno,strerror(errno));
^
ERROR: code indent should never use tabs
#244: FILE: slirp/mbuf.c:235:
+^IDEBUG_ERROR("dtom failed");$
ERROR: line over 90 characters
#322: FILE: slirp/socket.c:211:
+ DEBUG_MISC(" --- soread() disconnected, nn = %d, errno = %d-%s\n", nn, errno,strerror(errno));
ERROR: code indent should never use tabs
#322: FILE: slirp/socket.c:211:
+^I^I^IDEBUG_MISC(" --- soread() disconnected, nn = %d, errno = %d-%s\n", nn, errno,strerror(errno));$
ERROR: space required after that ',' (ctx:VxV)
#322: FILE: slirp/socket.c:211:
+ DEBUG_MISC(" --- soread() disconnected, nn = %d, errno = %d-%s\n", nn, errno,strerror(errno));
^
ERROR: code indent should never use tabs
#331: FILE: slirp/socket.c:240:
+^IDEBUG_MISC(" ... read nn = %d bytes\n", nn);$
ERROR: code indent should never use tabs
#340: FILE: slirp/socket.c:373:
+^I^I^IDEBUG_ERROR("Didn't send all data urgently XXXXX\n");$
ERROR: line over 90 characters
#349: FILE: slirp/socket.c:382:
+ DEBUG_MISC(" ---2 sent %d bytes urgent data, %d urgent bytes left\n", n, so->so_urgc);
ERROR: code indent should never use tabs
#349: FILE: slirp/socket.c:382:
+^IDEBUG_MISC(" ---2 sent %d bytes urgent data, %d urgent bytes left\n", n, so->so_urgc);$
ERROR: code indent should never use tabs
#368: FILE: slirp/socket.c:481:
+^IDEBUG_MISC(" --- sowrite disconnected, so->so_state = %x, errno = %d\n",$
ERROR: code indent should never use tabs
#379: FILE: slirp/socket.c:515:
+^I DEBUG_MISC(" udp icmp rx errno = %d-%s\n",$
ERROR: space required after that ',' (ctx:VxV)
#380: FILE: slirp/socket.c:516:
+ errno,strerror(errno));
^
ERROR: code indent should never use tabs
#390: FILE: slirp/socket.c:567:
+^I DEBUG_MISC(" did recvfrom %d, errno = %d-%s\n",$
ERROR: space required after that ',' (ctx:VxV)
#391: FILE: slirp/socket.c:568:
+ m->m_len, errno,strerror(errno));
^
ERROR: code indent should never use tabs
#400: FILE: slirp/socket.c:582:
+^I DEBUG_MISC(" rx error, tx icmp ICMP_UNREACH:%i\n", code);$
ERROR: code indent should never use tabs
#409: FILE: slirp/socket.c:594:
+^I DEBUG_MISC(" rx error, tx icmp6 ICMP_UNREACH:%i\n", code);$
ERROR: code indent should never use tabs
#436: FILE: slirp/tcp_input.c:239:
+^IDEBUG_ARGS(" m = %p iphlen = %2d inso = %p\n",$
ERROR: code indent should never use tabs
#447: FILE: slirp/tcp_input.c:665:
+^I DEBUG_MISC(" tcp fconnect errno = %d-%s\n",$
ERROR: space required after that ',' (ctx:VxV)
#448: FILE: slirp/tcp_input.c:666:
+ errno,strerror(errno));
^
ERROR: suspect code indent for conditional statements (24, 26)
#455: FILE: slirp/tcp_input.c:1034:
if (ti->ti_len == 0 && tiwin == tp->snd_wnd) {
+ DEBUG_MISC(" dup ack m = %p so = %p\n", m, so);
ERROR: code indent should never use tabs
#458: FILE: slirp/tcp_input.c:1035:
+^I^I^I DEBUG_MISC(" dup ack m = %p so = %p\n", m, so);$
ERROR: code indent should never use tabs
#467: FILE: slirp/tcp_input.c:1413:
+^IDEBUG_ARGS(" tp = %p cnt=%i\n", tp, cnt);$
ERROR: code indent should never use tabs
#476: FILE: slirp/tcp_input.c:1613:
+^IDEBUG_MISC(" returning mss = %d\n", mss);$
ERROR: code indent should never use tabs
#489: FILE: slirp/tcp_output.c:95:
+^IDEBUG_MISC(" --- tcp_output flags = 0x%x\n", flags);$
ERROR: code indent should never use tabs
#525: FILE: slirp/udp.c:175:
+^I DEBUG_MISC(" udp_attach errno = %d-%s\n",$
ERROR: code indent should never use tabs
#535: FILE: slirp/udp.c:212:
+^I DEBUG_MISC("udp tx errno = %d-%s\n", errno, strerror(errno));$
total: 31 errors, 0 warnings, 445 lines checked
Patch 35/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/65 Checking commit 6d7b26ddf447 (slirp: add a callback to log guest errors)
37/65 Checking commit 9f0401e53bed (slirp: remove #if notdef dead code)
38/65 Checking commit 98827e58f8aa (slirp: remove unused sbflush())
39/65 Checking commit babb0f4b20b1 (slirp: NULL is defined by stddef.h)
40/65 Checking commit 7b883d6e93a3 (slirp: remove dead TCP_ACK_HACK code)
41/65 Checking commit 29a48b37342a (slirp: replace ARRAY_SIZE with G_N_ELEMENTS)
ERROR: suspect code indent for conditional statements (2, 6)
#37: FILE: slirp/tftp.c:362:
+ while (k < pktlen && nb_options < G_N_ELEMENTS(option_name)) {
const char *key, *value;
ERROR: suspect code indent for conditional statements (2, 6)
#44: FILE: slirp/tftp.c:405:
if (nb_options > 0) {
+ assert(nb_options <= G_N_ELEMENTS(option_name));
total: 2 errors, 0 warnings, 24 lines checked
Patch 41/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
42/65 Checking commit e5bf42a86705 (net: do not depend on slirp internals)
43/65 Checking commit 1a26e8d5afc7 (glib-compat: add g_spawn_async_with_fds() fallback)
44/65 Checking commit 6806bca2d314 (slirp: simplify fork_exec())
WARNING: Block comments use a leading /* on a separate line
#58: FILE: slirp/misc.c:154:
+ g_spawn_async_with_fds(NULL /* cwd */,
WARNING: Block comments use a leading /* on a separate line
#60: FILE: slirp/misc.c:156:
+ NULL /* env */,
WARNING: Block comments use a leading /* on a separate line
#62: FILE: slirp/misc.c:158:
+ fork_exec_child_setup, NULL /* data */,
WARNING: Block comments use a leading /* on a separate line
#63: FILE: slirp/misc.c:159:
+ NULL /* child_pid */,
total: 0 errors, 4 warnings, 92 lines checked
Patch 44/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
45/65 Checking commit 33ab40a1799e (slirp: replace error_report() with g_critical())
46/65 Checking commit ae1e716c6522 (slirp: Enable fork_exec support on Windows)
47/65 Checking commit 495e28c5cd19 (slirp: drop <Vista compatibility)
48/65 Checking commit 17a297b93e93 (slirp: rename exec_list)
ERROR: code indent should never use tabs
#28: FILE: slirp/misc.c:42:
+^Istruct gfwd_list *tmp_ptr;$
ERROR: code indent should never use tabs
#37: FILE: slirp/misc.c:52:
+^I*ex_ptr = g_new0(struct gfwd_list, 1);$
ERROR: code indent should never use tabs
#56: FILE: slirp/misc.h:16:
+^Istruct gfwd_list *ex_next;$
WARNING: line over 80 characters
#99: FILE: slirp/slirp.c:783:
+ for (ex_ptr = slirp->guestfwd_list; ex_ptr; ex_ptr = ex_ptr->ex_next) {
WARNING: line over 80 characters
#173: FILE: slirp/tcp_input.c:397:
+ for (ex_ptr = slirp->guestfwd_list; ex_ptr; ex_ptr = ex_ptr->ex_next) {
ERROR: code indent should never use tabs
#182: FILE: slirp/tcp_input.c:619:
+^I^Ifor (ex_ptr = slirp->guestfwd_list; ex_ptr;$
ERROR: suspect code indent for conditional statements (16, 18)
#182: FILE: slirp/tcp_input.c:619:
+ for (ex_ptr = slirp->guestfwd_list; ex_ptr;
[...]
if(ex_ptr->ex_fport == so->so_fport &&
total: 5 errors, 2 warnings, 152 lines checked
Patch 48/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/65 Checking commit 284b5e847032 (slirp: use virtual time for packet expiration)
50/65 Checking commit 9dc44cc1dfcb (slirp: replace a fprintf with g_critical())
51/65 Checking commit 99583b0538af (slirp: replace some fprintf() with DEBUG_MISC)
52/65 Checking commit 212865ff2cf4 (slirp: replace a DEBUG block with WITH_ICMP_ERROR_MSG)
53/65 Checking commit 17daeebf144f (slirp: no need to make DPRINTF conditional on DEBUG)
54/65 Checking commit e6ba465226f0 (slirp: always build with debug statements)
55/65 Checking commit 25e8eec4a767 (slirp: introduce SLIRP_DEBUG environment variable)
56/65 Checking commit 6df57528d916 (slirp: use %p for pointers format)
57/65 Checking commit 4ba0640754f0 (slirp: remove remaining DEBUG blocks)
58/65 Checking commit 2634d8529ecb (slirp: replace DEBUG_ARGS with DEBUG_ARG)
ERROR: code indent should never use tabs
#145: FILE: slirp/tcp_input.c:218:
+^IDEBUG_ARG("m = %p iphlen = %2d inso = %p",$
ERROR: code indent should never use tabs
#155: FILE: slirp/tcp_input.c:1392:
+^IDEBUG_ARG("tp = %p cnt=%i", tp, cnt);$
total: 2 errors, 0 warnings, 112 lines checked
Patch 58/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
59/65 Checking commit 753120f87af5 (slirp: factor out guestfwd addition checks)
60/65 Checking commit 13d5ea9c3f4f (slirp: add clock_get_ns() callback)
61/65 Checking commit 8a5a5edeb8c0 (build-sys: use a separate slirp-obj-y && slirp.mo)
62/65 Checking commit 01dbc97b8989 (slirp: set G_LOG_DOMAIN)
63/65 Checking commit aa49d8f53dde (slirp: call into g_debug() for DEBUG macros)
ERROR: code indent should never use tabs
#29: FILE: slirp/cksum.c:124:
+^I^IDEBUG_ERROR("cksum: out of data");$
ERROR: code indent should never use tabs
#30: FILE: slirp/cksum.c:125:
+^I^IDEBUG_ERROR(" len = %d", len);$
ERROR: code indent should never use tabs
#127: FILE: slirp/ip_icmp.c:172:
+^IDEBUG_MISC("icmp_input udp_attach errno = %d-%s",$
ERROR: code indent should never use tabs
#136: FILE: slirp/ip_icmp.c:195:
+^IDEBUG_MISC("icmp_input udp sendto tx errno = %d-%s",$
WARNING: line over 80 characters
#204: FILE: slirp/socket.c:211:
+ DEBUG_MISC(" --- soread() disconnected, nn = %d, errno = %d-%s",
ERROR: code indent should never use tabs
#204: FILE: slirp/socket.c:211:
+^I^I^IDEBUG_MISC(" --- soread() disconnected, nn = %d, errno = %d-%s",$
ERROR: space required after that ',' (ctx:VxV)
#205: FILE: slirp/socket.c:212:
+ nn, errno,strerror(errno));
^
ERROR: code indent should never use tabs
#214: FILE: slirp/socket.c:241:
+^IDEBUG_MISC(" ... read nn = %d bytes", nn);$
ERROR: code indent should never use tabs
#223: FILE: slirp/socket.c:374:
+^I^I^IDEBUG_ERROR("Didn't send all data urgently XXXXX");$
ERROR: line over 90 characters
#232: FILE: slirp/socket.c:383:
+ DEBUG_MISC(" ---2 sent %d bytes urgent data, %d urgent bytes left", n, so->so_urgc);
ERROR: code indent should never use tabs
#232: FILE: slirp/socket.c:383:
+^IDEBUG_MISC(" ---2 sent %d bytes urgent data, %d urgent bytes left", n, so->so_urgc);$
ERROR: code indent should never use tabs
#250: FILE: slirp/socket.c:482:
+^IDEBUG_MISC(" --- sowrite disconnected, so->so_state = %x, errno = %d",$
ERROR: code indent should never use tabs
#259: FILE: slirp/socket.c:516:
+^I DEBUG_MISC(" udp icmp rx errno = %d-%s",$
ERROR: code indent should never use tabs
#268: FILE: slirp/socket.c:568:
+^I DEBUG_MISC(" did recvfrom %d, errno = %d-%s",$
ERROR: code indent should never use tabs
#277: FILE: slirp/socket.c:583:
+^I DEBUG_MISC(" rx error, tx icmp ICMP_UNREACH:%i", code);$
ERROR: code indent should never use tabs
#286: FILE: slirp/socket.c:595:
+^I DEBUG_MISC(" rx error, tx icmp6 ICMP_UNREACH:%i", code);$
ERROR: code indent should never use tabs
#310: FILE: slirp/tcp_input.c:644:
+^I DEBUG_MISC(" tcp fconnect errno = %d-%s", errno, strerror(errno));$
ERROR: suspect code indent for conditional statements (24, 26)
#317: FILE: slirp/tcp_input.c:1012:
if (ti->ti_len == 0 && tiwin == tp->snd_wnd) {
+ DEBUG_MISC(" dup ack m = %p so = %p", m, so);
ERROR: code indent should never use tabs
#319: FILE: slirp/tcp_input.c:1013:
+^I^I^I DEBUG_MISC(" dup ack m = %p so = %p", m, so);$
ERROR: code indent should never use tabs
#328: FILE: slirp/tcp_input.c:1552:
+^IDEBUG_MISC(" returning mss = %d", mss);$
ERROR: code indent should never use tabs
#341: FILE: slirp/tcp_output.c:95:
+^IDEBUG_MISC(" --- tcp_output flags = 0x%x", flags);$
ERROR: code indent should never use tabs
#368: FILE: slirp/udp.c:175:
+^I DEBUG_MISC(" udp_attach errno = %d-%s", errno, strerror(errno));$
ERROR: code indent should never use tabs
#377: FILE: slirp/udp.c:211:
+^I DEBUG_MISC("udp tx errno = %d-%s", errno, strerror(errno));$
total: 22 errors, 1 warnings, 310 lines checked
Patch 63/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
64/65 Checking commit e87d727081e2 (slirp: Mark debugging calls as unlikely)
65/65 Checking commit 017fc2ffc1d9 (slirp: check data length while emulating ident function)
ERROR: code indent should never use tabs
#24: FILE: slirp/tcp_subr.c:637:
+^I^I^Iif (m->m_len > so_rcv->sb_datalen$
ERROR: code indent should never use tabs
#25: FILE: slirp/tcp_subr.c:638:
+^I^I^I^I^I- (so_rcv->sb_wptr - so_rcv->sb_data)) {$
ERROR: code indent should never use tabs
#26: FILE: slirp/tcp_subr.c:639:
+^I^I^I return 1;$
ERROR: code indent should never use tabs
#27: FILE: slirp/tcp_subr.c:640:
+^I^I^I}$
total: 4 errors, 0 warnings, 11 lines checked
Patch 65/65 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190114225306.21569-1-samuel.thibault@ens-lyon.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Mon, 14 Jan 2019 at 23:01, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote: > > The following changes since commit 27df21ca3886fff4dd3d70e515517667963a52f1: > > Merge remote-tracking branch 'remotes/kraxel/tags/misc-20190111-pull-request' into staging (2019-01-11 16:45:59 +0000) > > are available in the Git repository at: > > https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault > > for you to fetch changes up to a7104eda7dab99d0cdbd3595c211864cba415905: > > slirp: check data length while emulating ident function (2019-01-14 23:36:38 +0100) > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 for any user-visible changes. -- PMM
The following changes since commit 27df21ca3886fff4dd3d70e515517667963a52f1: Merge remote-tracking branch 'remotes/kraxel/tags/misc-20190111-pull-request' into staging (2019-01-11 16:45:59 +0000) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to a7104eda7dab99d0cdbd3595c211864cba415905: slirp: check data length while emulating ident function (2019-01-14 23:36:38 +0100) ---------------------------------------------------------------- slirp updates Gerd Hoffmann (1): slirp: add tftp tracing Marc-André Lureau (61): slirp: associate slirp_output callback with the Slirp context slirp: remove do_pty from fork_exec() slirp: replace ex_pty with ex_chardev slirp: use a dedicated field for chardev pointer slirp: remove unused EMU_RSH slirp: rename /extra/chardev slirp: move internal function declarations slirp: remove Monitor dependency, return a string for info slirp: fix slirp_add_exec() leaks slirp: replace the poor-man string split with g_strsplit() slirp: remove dead declarations slirp: move socket pair creation in helper function slirp: remove unused M_TRAILINGSPACE slirp: use a callback structure to interface with qemu slirp: remove PROBE_CONN dead-code slirp: remove FULL_BOLT slirp: remove the disabled readv()/writev() code path slirp: remove HAVE_SYS_SIGNAL_H slirp: remove unused HAVE_SYS_BITYPES_H slirp: remove NO_UNIX_SOCKETS slirp: remove unused HAVE_SYS_STROPTS_H slirp: remove unused HAVE_ARPA_INET_H slirp: remove unused HAVE_SYS_WAIT_H slirp: remove unused HAVE_SYS_SELECT_H slirp: remove HAVE_SYS_IOCTL_H slirp: remove HAVE_SYS_FILIO_H slirp: remove unused DECLARE_IOVEC slirp: remove unused HAVE_INET_ATON slirp: replace HOST_WORDS_BIGENDIAN with glib equivalent slirp: replace SIZEOF_CHAR_P with glib equivalent slirp: replace compile time DO_KEEPALIVE slirp: remove unused global slirp_instance slirp: replace error_report() with g_critical() slirp: improve a bit the debug macros slirp: add a callback to log guest errors slirp: remove #if notdef dead code slirp: remove unused sbflush() slirp: NULL is defined by stddef.h slirp: remove dead TCP_ACK_HACK code slirp: replace ARRAY_SIZE with G_N_ELEMENTS net: do not depend on slirp internals glib-compat: add g_spawn_async_with_fds() fallback slirp: simplify fork_exec() slirp: replace error_report() with g_critical() slirp: drop <Vista compatibility slirp: rename exec_list slirp: use virtual time for packet expiration slirp: replace a fprintf with g_critical() slirp: replace some fprintf() with DEBUG_MISC slirp: replace a DEBUG block with WITH_ICMP_ERROR_MSG slirp: no need to make DPRINTF conditional on DEBUG slirp: always build with debug statements slirp: introduce SLIRP_DEBUG environment variable slirp: use %p for pointers format slirp: remove remaining DEBUG blocks slirp: replace DEBUG_ARGS with DEBUG_ARG slirp: factor out guestfwd addition checks slirp: add clock_get_ns() callback build-sys: use a separate slirp-obj-y && slirp.mo slirp: set G_LOG_DOMAIN slirp: call into g_debug() for DEBUG macros Prasad J Pandit (1): slirp: check data length while emulating ident function Samuel Thibault (2): slirp: Enable fork_exec support on Windows slirp: Mark debugging calls as unlikely Makefile | 5 +- Makefile.objs | 4 +- Makefile.target | 5 +- include/glib-compat.h | 56 +++++++++ net/colo-compare.c | 11 +- net/colo.c | 1 + net/colo.h | 7 +- net/filter-rewriter.c | 9 +- net/slirp.c | 61 +++++---- net/util.h | 55 ++++++++ slirp/Makefile.objs | 37 +++++- slirp/arp_table.c | 12 +- slirp/bootp.c | 10 +- slirp/cksum.c | 8 +- slirp/debug.h | 47 ++++--- slirp/dhcpv6.c | 17 ++- slirp/if.c | 4 +- slirp/ip.h | 10 +- slirp/ip6.h | 3 +- slirp/ip6_icmp.c | 27 ++-- slirp/ip6_icmp.h | 6 +- slirp/ip6_input.c | 2 +- slirp/ip6_output.c | 4 +- slirp/ip_icmp.c | 31 ++--- slirp/ip_input.c | 200 ----------------------------- slirp/libslirp.h | 27 ++-- slirp/main.h | 33 ----- slirp/mbuf.c | 2 +- slirp/mbuf.h | 1 - slirp/misc.c | 286 +++++++++++++++++------------------------- slirp/misc.h | 13 +- slirp/ncsi.c | 4 +- slirp/ndp_table.c | 32 +++-- slirp/sbuf.h | 1 - slirp/slirp.c | 177 +++++++++++++------------- slirp/slirp.h | 45 ++----- slirp/slirp_config.h | 86 ------------- slirp/socket.c | 53 +++----- slirp/socket.h | 2 +- slirp/tcp.h | 4 +- slirp/tcp_input.c | 84 ++----------- slirp/tcp_output.c | 2 +- slirp/tcp_subr.c | 22 ++-- slirp/tcp_timer.c | 2 +- slirp/tftp.c | 7 +- slirp/trace-events | 5 + slirp/udp.c | 5 +- slirp/udp6.c | 11 +- stubs/slirp.c | 2 +- 49 files changed, 603 insertions(+), 935 deletions(-) delete mode 100644 slirp/slirp_config.h create mode 100644 slirp/trace-events -- 2.20.1 ---------------------------------------------------------------- Gerd Hoffmann (1): slirp: add tftp tracing Marc-André Lureau (61): slirp: associate slirp_output callback with the Slirp context slirp: remove do_pty from fork_exec() slirp: replace ex_pty with ex_chardev slirp: use a dedicated field for chardev pointer slirp: remove unused EMU_RSH slirp: rename /extra/chardev slirp: move internal function declarations slirp: remove Monitor dependency, return a string for info slirp: fix slirp_add_exec() leaks slirp: replace the poor-man string split with g_strsplit() slirp: remove dead declarations slirp: move socket pair creation in helper function slirp: remove unused M_TRAILINGSPACE slirp: use a callback structure to interface with qemu slirp: remove PROBE_CONN dead-code slirp: remove FULL_BOLT slirp: remove the disabled readv()/writev() code path slirp: remove HAVE_SYS_SIGNAL_H slirp: remove unused HAVE_SYS_BITYPES_H slirp: remove NO_UNIX_SOCKETS slirp: remove unused HAVE_SYS_STROPTS_H slirp: remove unused HAVE_ARPA_INET_H slirp: remove unused HAVE_SYS_WAIT_H slirp: remove unused HAVE_SYS_SELECT_H slirp: remove HAVE_SYS_IOCTL_H slirp: remove HAVE_SYS_FILIO_H slirp: remove unused DECLARE_IOVEC slirp: remove unused HAVE_INET_ATON slirp: replace HOST_WORDS_BIGENDIAN with glib equivalent slirp: replace SIZEOF_CHAR_P with glib equivalent slirp: replace compile time DO_KEEPALIVE slirp: remove unused global slirp_instance slirp: replace error_report() with g_critical() slirp: improve a bit the debug macros slirp: add a callback to log guest errors slirp: remove #if notdef dead code slirp: remove unused sbflush() slirp: NULL is defined by stddef.h slirp: remove dead TCP_ACK_HACK code slirp: replace ARRAY_SIZE with G_N_ELEMENTS net: do not depend on slirp internals glib-compat: add g_spawn_async_with_fds() fallback slirp: simplify fork_exec() slirp: replace error_report() with g_critical() slirp: drop <Vista compatibility slirp: rename exec_list slirp: use virtual time for packet expiration slirp: replace a fprintf with g_critical() slirp: replace some fprintf() with DEBUG_MISC slirp: replace a DEBUG block with WITH_ICMP_ERROR_MSG slirp: no need to make DPRINTF conditional on DEBUG slirp: always build with debug statements slirp: introduce SLIRP_DEBUG environment variable slirp: use %p for pointers format slirp: remove remaining DEBUG blocks slirp: replace DEBUG_ARGS with DEBUG_ARG slirp: factor out guestfwd addition checks slirp: add clock_get_ns() callback build-sys: use a separate slirp-obj-y && slirp.mo slirp: set G_LOG_DOMAIN slirp: call into g_debug() for DEBUG macros Prasad J Pandit (1): slirp: check data length while emulating ident function Samuel Thibault (2): slirp: Enable fork_exec support on Windows slirp: Mark debugging calls as unlikely Makefile | 5 +- Makefile.objs | 4 +- Makefile.target | 5 +- include/glib-compat.h | 56 ++++++++++ net/colo-compare.c | 11 +- net/colo.c | 1 + net/colo.h | 7 +- net/filter-rewriter.c | 9 +- net/slirp.c | 61 +++++------ net/util.h | 55 ++++++++++ slirp/Makefile.objs | 37 ++++++- slirp/arp_table.c | 12 +-- slirp/bootp.c | 10 +- slirp/cksum.c | 8 +- slirp/debug.h | 47 +++++---- slirp/dhcpv6.c | 17 ++- slirp/if.c | 4 +- slirp/ip.h | 10 +- slirp/ip6.h | 3 +- slirp/ip6_icmp.c | 27 +++-- slirp/ip6_icmp.h | 6 +- slirp/ip6_input.c | 2 +- slirp/ip6_output.c | 4 +- slirp/ip_icmp.c | 31 +++--- slirp/ip_input.c | 200 ----------------------------------- slirp/libslirp.h | 27 +++-- slirp/main.h | 33 ------ slirp/mbuf.c | 2 +- slirp/mbuf.h | 1 - slirp/misc.c | 286 ++++++++++++++++++++------------------------------ slirp/misc.h | 13 ++- slirp/ncsi.c | 4 +- slirp/ndp_table.c | 32 +++--- slirp/sbuf.h | 1 - slirp/slirp.c | 177 +++++++++++++++---------------- slirp/slirp.h | 45 ++------ slirp/slirp_config.h | 86 --------------- slirp/socket.c | 53 +++------- slirp/socket.h | 2 +- slirp/tcp.h | 4 +- slirp/tcp_input.c | 84 ++------------- slirp/tcp_output.c | 2 +- slirp/tcp_subr.c | 22 ++-- slirp/tcp_timer.c | 2 +- slirp/tftp.c | 7 +- slirp/trace-events | 5 + slirp/udp.c | 5 +- slirp/udp6.c | 11 +- stubs/slirp.c | 2 +- 49 files changed, 603 insertions(+), 935 deletions(-) delete mode 100644 slirp/slirp_config.h create mode 100644 slirp/trace-events