From patchwork Wed Feb 20 13:59:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 10822405 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E58461399 for ; Wed, 20 Feb 2019 15:46:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF8EA2EA2F for ; Wed, 20 Feb 2019 15:46:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1B232EA6A; Wed, 20 Feb 2019 15:46:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1D4C62EA2F for ; Wed, 20 Feb 2019 15:45:55 +0000 (UTC) Received: from localhost ([127.0.0.1]:41219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwU4I-0000qL-4Q for patchwork-qemu-devel@patchwork.kernel.org; Wed, 20 Feb 2019 10:45:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwTvk-0001uW-As for qemu-devel@nongnu.org; Wed, 20 Feb 2019 10:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwTvi-0005fY-G7 for qemu-devel@nongnu.org; Wed, 20 Feb 2019 10:37:03 -0500 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:46191) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwTvZ-0004aU-3S for qemu-devel@nongnu.org; Wed, 20 Feb 2019 10:36:56 -0500 Received: by mail-ot1-x344.google.com with SMTP id c18so19220996otl.13 for ; Wed, 20 Feb 2019 07:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=8zVyIe1cY6HugBqehzuwkdCf1WHIryJGgXM2dZd5dtU=; b=qqatf8i+5UfM2XRPYDMTb5BhscvDZSqBDDw5d0fH+3u+tfNHpOlN5aohRjBWpbPWNw Usto7xoOKRTY/7Yhf7jtb1UHEjdc/qfiqe+V9YNnRXjrx37aZM+u6Y683svqMVtkGe3t Hl5W0w2yv5yWsmjDQXSIIuT64OtnIqUKuk0jz1uKMzO/9QNap1rO9KZSDxzkaO1RJWuh E7/meIIJKASwY+XHgIXaH8EVb9dKgUdM8aFz4XWazkgQ8rJmI19GlBxzsIDQ3untpM3P LQjXoSNs9jvXpjLgc/Z3Hz1y4xBnn2ZIxbQe+K+ggYik+pw2isMzU7D22gEK5AxV2vRL NvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=8zVyIe1cY6HugBqehzuwkdCf1WHIryJGgXM2dZd5dtU=; b=LI0NpZjOcDuvQApldWsWbB3j5//OqQfTKJIeqkmNLudGCmcIv39xJaMxV/Qcf8K3PE 6OoctI7PCyQHcOKQ2fTvmTVxrIv5tjqymc+8gVitMhYc089RFdxWHs1c53z6M70yNtia WBsyHjh7GYLp4ovhkOgU3dASQe3JLt5rMR7dqE9mXaeSDhC58mOnDvkrc64GwDAmCcln st6ZoHmNVMHP+4m8UseQAysTkhZRsTak0kafLix2sc70pf7hP9HyLCyX28S4CeWsZitN PlLrUwk7t9FfbYjh6oLAfTMYg8jNbVhUr2n18y2L7y/8q6ZVHx18XDkIpYQ58fRjPYEl aWsA== X-Gm-Message-State: AHQUAuZQ1Wu0qK8jjMLiWj7WNmg7tXhJR9DyHyTSfPJN6Ha8qlSqqvMB S+DRWNkWv5oacrugQ+ZrfxZQXyH+XA== X-Google-Smtp-Source: AHgI3IYyLmri2LiPyG0Kd569e77eWPopoOth5rrjmqojNv6EV9dfaH05pF26omrW9Xu+7BArXZXzkQ== X-Received: by 2002:aca:75cf:: with SMTP id q198mr6067698oic.125.1550671215197; Wed, 20 Feb 2019 06:00:15 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id l134sm3198160oih.43.2019.02.20.06.00.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 06:00:12 -0800 (PST) Received: from t430.minyard.net (unknown [IPv6:2001:470:b8f6:1b:d1f6:7172:48bb:512b]) by serve.minyard.net (Postfix) with ESMTPA id 7B7CC1808F5; Wed, 20 Feb 2019 14:00:09 +0000 (UTC) Received: by t430.minyard.net (Postfix, from userid 1000) id 2F8A8302812; Wed, 20 Feb 2019 08:00:08 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Wed, 20 Feb 2019 07:59:45 -0600 Message-Id: <20190220135956.22589-9-minyard@acm.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190220135956.22589-1-minyard@acm.org> References: <20190220135956.22589-1-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::344 Subject: [Qemu-devel] [PATCH 08/19] i2c:smbus_eeprom: Get rid of the quick command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Corey Minyard , Corey Minyard , "Michael S . Tsirkin" , "Dr . David Alan Gilbert" , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Corey Minyard It's not necessary, it won't be called if it's NULL. Signed-off-by: Corey Minyard --- hw/i2c/smbus_eeprom.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index c2b9e3383e..4bc579e69e 100644 --- a/hw/i2c/smbus_eeprom.c +++ b/hw/i2c/smbus_eeprom.c @@ -36,13 +36,6 @@ typedef struct SMBusEEPROMDevice { uint8_t offset; } SMBusEEPROMDevice; -static void eeprom_quick_cmd(SMBusDevice *dev, uint8_t read) -{ -#ifdef DEBUG - printf("eeprom_quick_cmd: addr=0x%02x read=%d\n", dev->i2c.address, read); -#endif -} - static uint8_t eeprom_receive_byte(SMBusDevice *dev) { SMBusEEPROMDevice *eeprom = (SMBusEEPROMDevice *) dev; @@ -95,7 +88,6 @@ static void smbus_eeprom_class_initfn(ObjectClass *klass, void *data) SMBusDeviceClass *sc = SMBUS_DEVICE_CLASS(klass); dc->realize = smbus_eeprom_realize; - sc->quick_cmd = eeprom_quick_cmd; sc->receive_byte = eeprom_receive_byte; sc->write_data = eeprom_write_data; dc->props = smbus_eeprom_properties;