| Message ID | 20190227085546.23690-1-kamalheib1@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/rdma: Fix the error prints in create_qp_rings() | expand |
On Wed, Feb 27, 2019 at 10:55:46AM +0200, Kamal Heib wrote: > The prints should indicate that we are talking about QP and not CQ. > > Fixes: 98d176f8e592 ("hw/rdma: PVRDMA commands and data-path ops") > Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > --- > hw/rdma/vmw/pvrdma_cmd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c > index 21a55e225a61..8bc24e952073 100644 > --- a/hw/rdma/vmw/pvrdma_cmd.c > +++ b/hw/rdma/vmw/pvrdma_cmd.c > @@ -374,13 +374,13 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, > > dir = rdma_pci_dma_map(pci_dev, pdir_dma, TARGET_PAGE_SIZE); > if (!dir) { > - rdma_error_report("Failed to map to CQ page directory"); > + rdma_error_report("Failed to map to QP page directory"); I guess it is based on latest patch-set, suggesting to specify it next time. > goto out; > } > > tbl = rdma_pci_dma_map(pci_dev, dir[0], TARGET_PAGE_SIZE); > if (!tbl) { > - rdma_error_report("Failed to map to CQ page table"); > + rdma_error_report("Failed to map to QP page table"); > goto out; > } > > @@ -393,7 +393,7 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, > sr->ring_state = (struct pvrdma_ring *) > rdma_pci_dma_map(pci_dev, tbl[0], TARGET_PAGE_SIZE); > if (!sr->ring_state) { > - rdma_error_report("Failed to map to CQ ring state"); > + rdma_error_report("Failed to map to QP ring state"); > goto out_free_sr_mem; > } > Thanks! Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > -- > 2.20.1 > >
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 21a55e225a61..8bc24e952073 100644 --- a/hw/rdma/vmw/pvrdma_cmd.c +++ b/hw/rdma/vmw/pvrdma_cmd.c @@ -374,13 +374,13 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, dir = rdma_pci_dma_map(pci_dev, pdir_dma, TARGET_PAGE_SIZE); if (!dir) { - rdma_error_report("Failed to map to CQ page directory"); + rdma_error_report("Failed to map to QP page directory"); goto out; } tbl = rdma_pci_dma_map(pci_dev, dir[0], TARGET_PAGE_SIZE); if (!tbl) { - rdma_error_report("Failed to map to CQ page table"); + rdma_error_report("Failed to map to QP page table"); goto out; } @@ -393,7 +393,7 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, sr->ring_state = (struct pvrdma_ring *) rdma_pci_dma_map(pci_dev, tbl[0], TARGET_PAGE_SIZE); if (!sr->ring_state) { - rdma_error_report("Failed to map to CQ ring state"); + rdma_error_report("Failed to map to QP ring state"); goto out_free_sr_mem; }
The prints should indicate that we are talking about QP and not CQ. Fixes: 98d176f8e592 ("hw/rdma: PVRDMA commands and data-path ops") Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> Signed-off-by: Kamal Heib <kamalheib1@gmail.com> --- hw/rdma/vmw/pvrdma_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)