| Message ID | 20191119075759.4334-1-xieyongji@baidu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] libvhost-user: Zero memory allocated for VuVirtqInflightDesc | expand |
On Tue, Nov 19, 2019 at 11:58 AM <elohimes@gmail.com> wrote: > > From: Xie Yongji <xieyongji@baidu.com> > > Use a zero-initialized VuVirtqInflightDesc struct to avoid > that scan-build reports that vq->resubmit_list[0].counter may > be garbage value in vu_check_queue_inflights(). > > Fixes: 5f9ff1eff ("libvhost-user: Support tracking inflight I/O in > shared memory") > Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com> > Signed-off-by: Xie Yongji <xieyongji@baidu.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > contrib/libvhost-user/libvhost-user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c > index 68c27136ae..ec27b78ff1 100644 > --- a/contrib/libvhost-user/libvhost-user.c > +++ b/contrib/libvhost-user/libvhost-user.c > @@ -992,7 +992,7 @@ vu_check_queue_inflights(VuDev *dev, VuVirtq *vq) > vq->shadow_avail_idx = vq->last_avail_idx = vq->inuse + vq->used_idx; > > if (vq->inuse) { > - vq->resubmit_list = malloc(sizeof(VuVirtqInflightDesc) * vq->inuse); > + vq->resubmit_list = calloc(vq->inuse, sizeof(VuVirtqInflightDesc)); > if (!vq->resubmit_list) { > return -1; > } > -- > 2.17.1 >
diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c index 68c27136ae..ec27b78ff1 100644 --- a/contrib/libvhost-user/libvhost-user.c +++ b/contrib/libvhost-user/libvhost-user.c @@ -992,7 +992,7 @@ vu_check_queue_inflights(VuDev *dev, VuVirtq *vq) vq->shadow_avail_idx = vq->last_avail_idx = vq->inuse + vq->used_idx; if (vq->inuse) { - vq->resubmit_list = malloc(sizeof(VuVirtqInflightDesc) * vq->inuse); + vq->resubmit_list = calloc(vq->inuse, sizeof(VuVirtqInflightDesc)); if (!vq->resubmit_list) { return -1; }