From patchwork Mon Nov 25 15:36:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felipe Franciosi X-Patchwork-Id: 11260549 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A61F51390 for ; Mon, 25 Nov 2019 15:38:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 359B1207FD for ; Mon, 25 Nov 2019 15:38:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nutanix.com header.i=@nutanix.com header.b="uGoQOGXJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 359B1207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nutanix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZGR7-0005zH-OB for patchwork-qemu-devel@patchwork.kernel.org; Mon, 25 Nov 2019 10:38:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33287) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZGPp-0004PP-Jo for qemu-devel@nongnu.org; Mon, 25 Nov 2019 10:36:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZGPn-0007p5-UM for qemu-devel@nongnu.org; Mon, 25 Nov 2019 10:36:41 -0500 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]:1480) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iZGPn-0007oj-PQ for qemu-devel@nongnu.org; Mon, 25 Nov 2019 10:36:39 -0500 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAPFVfei009365; Mon, 25 Nov 2019 07:36:39 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=proofpoint20171006; bh=eOwV4DeHBup9OqaefCFkcue4SmcvXAexlK1LjnCrbbk=; b=uGoQOGXJQ/PPufxMJJiepvIG2HoG9vE4xfyf3qkuZ1gM0wLIHuyKKoSF86F2/i4glsUn myl53o5KqQmbcVSTqLoaFg0zppxMO9lNgjwZ3oaJ3Xilh2Pkv0JpM9W6A0+VXyPo98n2 ZnshH6yHv9xgP2FPszU1NfKr6dVIzlus1OdgGsM4DXGGScEJi3aTbuy6uZyCzoJcG+AE JarjB4iMraDV0Lq3GUwc95fUNtGPTKBCoynCb4KQSxDwrfB3mrtOSQ7Kx2jffhltebU5 qcC83taqC//1elAbkSMNDDYnyTov07NHdDjG2TdN1PZFHKSVQUrYjw1JNdP79h5XyyLA cQ== Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2052.outbound.protection.outlook.com [104.47.36.52]) by mx0b-002c1b01.pphosted.com with ESMTP id 2wf4yn3unq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Nov 2019 07:36:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CmKS57ASB6U76qQ3ies+J0nigDr1B3mIqgmH7MfsVIn38E4IOzg17CEWOGkfxR6vS9sPQKL2foyFizF/P8toJN7LU9VTwHUWzZs2JJSwOs15mx0V84/MS8pSiH+QclK1yVKoQnS/rAB4i2ixGv4BvD0i6sjZOdbkVXvKKrNrTb/qGl+wk8F27Q57WLNrhh2Q9cdzcxqOE5NQ5mFWB6sEbFQ7WNOBeHa6cfD38YAZkx1oSmertStfHLZ1zV/bnckBGvgYSlrvW2SWrW40ifWu67/3QH54e7Q+xh0GunzpAlPktMFo0L9Vc1uViIQaqVNE4BYhzGBIxM12kix9GmsuYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eOwV4DeHBup9OqaefCFkcue4SmcvXAexlK1LjnCrbbk=; b=D1NcdMnr+Ykpoc9+/5TiYQluQncovW83JeQhnTSg4qC8AWJr9VmMowZ4N12eh7ytLTZgSlEnfLlrDjDcqZ63DrKS0CKh06HhCVwBZiWzUxrx0c53DiiLMK/5/dO/kkwI1FEFqP488qoOrXQYIll7I5FF6qENsItdZzDbbk34D15WiSOf+ZTeFn/1MNN6yX3Q/fHuYZRI1m3ScdRsYWHxTG0Ak98h6pLmkfyFABZE/JFc8XEH1HX/I7KTy++QnfzJPB9btN9b3ZCCpCY8kXNYrXiZNiAXq6M3T/gOCDyPYeHc33UPJledz/uloSJaO6NWDQSZTvrE5O6vHuKzJ4SwWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none Received: from MWHPR02MB2656.namprd02.prod.outlook.com (10.168.206.142) by MWHPR02MB3183.namprd02.prod.outlook.com (10.164.133.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Mon, 25 Nov 2019 15:36:38 +0000 Received: from MWHPR02MB2656.namprd02.prod.outlook.com ([fe80::f801:763d:e7fc:6bf]) by MWHPR02MB2656.namprd02.prod.outlook.com ([fe80::f801:763d:e7fc:6bf%7]) with mapi id 15.20.2474.023; Mon, 25 Nov 2019 15:36:38 +0000 From: Felipe Franciosi To: Eduardo Habkost , Markus Armbruster , Stefan Hajnoczi Subject: [PATCH 2/4] ich9: fix getter type for sci_int property Thread-Topic: [PATCH 2/4] ich9: fix getter type for sci_int property Thread-Index: AQHVo6YgVQPIYdSUK0GhG0cq3dH2nw== Date: Mon, 25 Nov 2019 15:36:38 +0000 Message-ID: <20191125153619.39893-3-felipe@nutanix.com> References: <20191125153619.39893-1-felipe@nutanix.com> In-Reply-To: <20191125153619.39893-1-felipe@nutanix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM0PR02CA0087.eurprd02.prod.outlook.com (2603:10a6:208:154::28) To MWHPR02MB2656.namprd02.prod.outlook.com (2603:10b6:300:45::14) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [62.254.189.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17099d98-f109-44b7-ffbf-08d771bd42d7 x-ms-traffictypediagnostic: MWHPR02MB3183: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-proofpoint-crosstenant: true x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 0232B30BBC x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(136003)(376002)(396003)(39860400002)(366004)(189003)(199004)(4326008)(6512007)(86362001)(1076003)(3846002)(6116002)(386003)(6506007)(7736002)(305945005)(6436002)(6486002)(478600001)(54906003)(26005)(102836004)(110136005)(2906002)(36756003)(25786009)(14454004)(316002)(446003)(99286004)(256004)(107886003)(66066001)(66446008)(64756008)(66556008)(66476007)(11346002)(2616005)(5660300002)(66946007)(186003)(76176011)(52116002)(50226002)(81166006)(81156014)(8676002)(71200400001)(8936002)(71190400001)(64030200001); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR02MB3183; H:MWHPR02MB2656.namprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nutanix.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UWEeawA9iadJtrhOolW68ZZRhSl8dBW81sOjrH9Z21+BVdMTRFMqxY01xr5NkkH4YZrYQuR3J9A8Xlv5k8it41uIIN5oNg7TXWoOxSQ9S417PgZw+iXSzNwvTA1BjZjCYhDVF25eWuT/tHyqi6zDGZNLoaPBt+MCW1keR0ovKrVa0YG6dlJfY8Df581Ub3HxYGLRz7lyAm6ofobOVoP+CI6C3fXwzupifFPj+rCpBBpVUUgtCEItztRhqU9L5oFOIGYzfE4g5vDRja+Y+24jE21uVUmOLi1jb+2IIPnaIVq7+t93krjE7Wnl37P1UZpdKSamkk/3VN4WQPH1nv5qKbZ3wJ3JeBttl5XsIGbVGcW18KIxZGzVYDsPoh51lSYhzsWqpvPl4T8zIIsyTOK9WVuzrSkXKeA9qSp1V8M18NNHxx4nFa6clH9ow7AyDYns MIME-Version: 1.0 X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17099d98-f109-44b7-ffbf-08d771bd42d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2019 15:36:38.2023 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vp1Tl12IRXLMBUgBDGlQi9nPK3NsMzQrpnIERNMcGm03PYl5netCePhJidTBr3rkJwvHWNtOEBWYq1wP5CZS8J2xi1gd+8mSh6lHGmAS6bw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3183 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-25_03:2019-11-21,2019-11-25 signatures=0 X-Proofpoint-Spam-Reason: safe X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.155.12 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-devel@nongnu.org" , Felipe Franciosi Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was written using uint32_t. However, the object property is uint8_t. This fixes the getter for correctness. Signed-off-by: Felipe Franciosi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- hw/isa/lpc_ich9.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 5555ce3342..240979885d 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -631,9 +631,9 @@ static void ich9_lpc_get_sci_int(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { ICH9LPCState *lpc = ICH9_LPC_DEVICE(obj); - uint32_t value = lpc->sci_gsi; + uint8_t value = lpc->sci_gsi; - visit_type_uint32(v, name, &value, errp); + visit_type_uint8(v, name, &value, errp); } static void ich9_lpc_add_properties(ICH9LPCState *lpc) @@ -641,7 +641,7 @@ static void ich9_lpc_add_properties(ICH9LPCState *lpc) static const uint8_t acpi_enable_cmd = ICH9_APM_ACPI_ENABLE; static const uint8_t acpi_disable_cmd = ICH9_APM_ACPI_DISABLE; - object_property_add(OBJECT(lpc), ACPI_PM_PROP_SCI_INT, "uint32", + object_property_add(OBJECT(lpc), ACPI_PM_PROP_SCI_INT, "uint8", ich9_lpc_get_sci_int, NULL, NULL, NULL, NULL); object_property_add_uint8_ptr(OBJECT(lpc), ACPI_PM_PROP_ACPI_ENABLE_CMD,