From patchwork Thu Nov 28 16:48:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felipe Franciosi X-Patchwork-Id: 11266545 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C296138C for ; Thu, 28 Nov 2019 19:43:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 616582176D for ; Thu, 28 Nov 2019 19:43:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nutanix.com header.i=@nutanix.com header.b="pBxhw4ps" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 616582176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nutanix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:52678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaPhA-0002Jn-Hb for patchwork-qemu-devel@patchwork.kernel.org; Thu, 28 Nov 2019 14:43:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50134) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaMyN-0002m7-TL for qemu-devel@nongnu.org; Thu, 28 Nov 2019 11:48:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaMyM-0002KM-3I for qemu-devel@nongnu.org; Thu, 28 Nov 2019 11:48:55 -0500 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]:65190) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iaMyF-0002A0-Ov for qemu-devel@nongnu.org; Thu, 28 Nov 2019 11:48:49 -0500 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xASGlf7g014210; Thu, 28 Nov 2019 08:48:31 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=proofpoint20171006; bh=9zPGVjyV5VQnm3bt6A02V0umR+NCvpD843NmYvStucM=; b=pBxhw4psSBrPR4mEWz79S6a/zLnTdpBRRR7Rd5LLfAgaK+NohiQowSHJXukcESRoR6at ceABUv5g+PQ11HfvgU6SqpuyFV/ZSpw7CUIHO0V4TtnLQxmcPAIVga06IdtJbuWgOJpU xb15FPJHxEoAfviueRAlnde7CNY8gJzl9Ke9E1X/sAcXAOtj69+2wpN35CRm+A31gDau 61Wqql8RMsYICw33PMIrMypOqTQoO/JQgOeLAqai/M0/GCCqknfwGiN7qplOE5fPMmUx zGr8t58OWwDiHMzjVhIfEg6znmlb3Pmhv/qbc+xzhFla+fIpWHkOwsvEtoS7l2XxlFHf Ag== Received: from nam01-sn1-obe.outbound.protection.outlook.com (mail-sn1nam01lp2054.outbound.protection.outlook.com [104.47.32.54]) by mx0a-002c1b01.pphosted.com with ESMTP id 2whhdhujgh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Nov 2019 08:48:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZP8cGeDOqo9DoltyMY3it1r7N7B4n/XkNl4J8sdCU3dde78eZavRAknQew4DncpBOuVhoUHOwybmu+ozC5bJSsS9n+1MRIMS6Tu/sb23PwR+IVXkr4IH9H654vl66bCa5kRJgL1HCxJLtWi6NxDdXaWJioMdzITw6bITDmHRd0ZxkQLnWn/D2fpAL/j8MrOqFnN0ZU+g54s03Xcu+1SkRqJzzYiLhpdQkBABOAhX6HfKuikJpfRbfucaA9Aj07liGb1sWxBRTZTAEP+R53dlhS4LiFY/YcQiTxQCadeYnqWBS2h+OFWR3bbYDLaV4t2sneVRG51HZTPJKsBQUGZaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9zPGVjyV5VQnm3bt6A02V0umR+NCvpD843NmYvStucM=; b=iZxw2qeea+/jqWxG12osTJ9+rEsAXR405ckIeUJ6ZN8QHYvOTxVj6ZAZAsQngnwd/9gSIdAC38szEVXxwTBy0mtvGMDyWVs4u3bpCvzwuCQAN4l5kGV7zyyo1BgOcCGbH+0mNwBMwT1pLXNFZ5mu6HXjb3HXWthVUYk+OFxkI+lOoWQ3kOVV4REKsSiauzXph72IZOjZE8fqTSwEgh6zWZv9iPEUtOUOnuj4UnJfjTCOy0utog/ydU26Fd2ujpPYnV1qWDTHlzFimmQ2UsPT3HZ2hQAz/HEG5azS9eO+3GkAX0Q/Ys4OzfMGqq3fbRc640xoTRZIs3an9mWPS3G1RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none Received: from MWHPR02MB2656.namprd02.prod.outlook.com (10.168.206.142) by MWHPR02MB2398.namprd02.prod.outlook.com (10.168.243.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.20; Thu, 28 Nov 2019 16:48:29 +0000 Received: from MWHPR02MB2656.namprd02.prod.outlook.com ([fe80::f801:763d:e7fc:6bf]) by MWHPR02MB2656.namprd02.prod.outlook.com ([fe80::f801:763d:e7fc:6bf%7]) with mapi id 15.20.2474.023; Thu, 28 Nov 2019 16:48:29 +0000 From: Felipe Franciosi To: Marc-Andre Lureau , Philippe Mathieu-Daude , Stefan Hajnoczi , Eduardo Habkost , Markus Armbruster , Alexey Kardashevskiy Subject: [PATCH v2 2/4] ich9: fix getter type for sci_int property Thread-Topic: [PATCH v2 2/4] ich9: fix getter type for sci_int property Thread-Index: AQHVpgupAr8vV7eYO0SbN77IztInIw== Date: Thu, 28 Nov 2019 16:48:29 +0000 Message-ID: <20191128164810.54279-3-felipe@nutanix.com> References: <20191128164810.54279-1-felipe@nutanix.com> In-Reply-To: <20191128164810.54279-1-felipe@nutanix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM3PR05CA0154.eurprd05.prod.outlook.com (2603:10a6:207:3::32) To MWHPR02MB2656.namprd02.prod.outlook.com (2603:10b6:300:45::14) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [62.254.189.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c3ebc907-9432-46bf-d22f-08d77422cbfb x-ms-traffictypediagnostic: MWHPR02MB2398: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-proofpoint-crosstenant: true x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 0235CBE7D0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(346002)(366004)(376002)(39860400002)(136003)(189003)(199004)(102836004)(110136005)(256004)(446003)(36756003)(14454004)(2616005)(6436002)(11346002)(66066001)(4326008)(386003)(6506007)(186003)(26005)(52116002)(76176011)(66556008)(64756008)(1076003)(71190400001)(66946007)(5660300002)(71200400001)(6486002)(66446008)(66476007)(86362001)(6512007)(478600001)(54906003)(8936002)(50226002)(316002)(81166006)(2906002)(8676002)(7736002)(305945005)(81156014)(99286004)(25786009)(6116002)(3846002)(64030200001); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR02MB2398; H:MWHPR02MB2656.namprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nutanix.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sakWcFsPGuyDQ4F2JHvM3MlGmytwk1zgsQZBaRt3eq55qRz2GMqcZwbIzE08+d8fo4Z3Uljb1Jy7Q8RuUNtnM2Y+xK/otvhd0aL01G3T4X0tkF3033vpyxql1BX+ws13OcBeABCEmoE5Zx2afyN5B/vWZYV3GLksPdQhhLUrzYHiUOa0M+o+rF+y+07ysY1PcSUKElfFWC0DbxVXDN5qbV+uX53L/bSNMVXWMXNYeBrj6qExJU2B5NjtNvJeU89qo+plaZN5zZmIV97oRFRwzSTQufX19hcSGWfl1GbFUfvIZipmokutFm9wO4KZlIiALNQRSdgp7g/bmAMFBmY8VZV/OU/r78L02o316rEpgN6gGmiTkj8M4fo/k05VFn1AVsQFHoTrB4ninTjTwFHIr1dsek24mwnePhQ2Be+cqIbnwT446UeRaQWv5EGDpU+B MIME-Version: 1.0 X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3ebc907-9432-46bf-d22f-08d77422cbfb X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2019 16:48:29.7642 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bqyxkR1a/XZU04I+zcTEI9im8N5vNbJ8ag/rIW80CKA17hiXjU304NATgg2jRPR9GUJ3q5V6VxAYEo88YSYgWsvVDVoB3fVnNMvu2mwwctc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2398 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-28_05:2019-11-28,2019-11-28 signatures=0 X-Proofpoint-Spam-Reason: safe X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.151.68 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-devel@nongnu.org" , Felipe Franciosi Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was written using uint32_t. However, the object property is uint8_t. This fixes the getter for correctness. Signed-off-by: Felipe Franciosi Reviewed-by: Marc-André Lureau --- hw/isa/lpc_ich9.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index f5526f9c3b..3a9c4f0503 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -631,9 +631,7 @@ static void ich9_lpc_get_sci_int(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { ICH9LPCState *lpc = ICH9_LPC_DEVICE(obj); - uint32_t value = lpc->sci_gsi; - - visit_type_uint32(v, name, &value, errp); + visit_type_uint8(v, name, &lpc->sci_gsi, errp); } static void ich9_lpc_add_properties(ICH9LPCState *lpc) @@ -641,7 +639,7 @@ static void ich9_lpc_add_properties(ICH9LPCState *lpc) static const uint8_t acpi_enable_cmd = ICH9_APM_ACPI_ENABLE; static const uint8_t acpi_disable_cmd = ICH9_APM_ACPI_DISABLE; - object_property_add(OBJECT(lpc), ACPI_PM_PROP_SCI_INT, "uint32", + object_property_add(OBJECT(lpc), ACPI_PM_PROP_SCI_INT, "uint8", ich9_lpc_get_sci_int, NULL, NULL, NULL, NULL); object_property_add_uint8_ptr(OBJECT(lpc), ACPI_PM_PROP_ACPI_ENABLE_CMD,