| Message ID | 20200206183219.3756-4-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/4] m25p80: Convert to support tracing | expand |
On 2/6/20 7:32 PM, Guenter Roeck wrote: > The Linux kernel recently started using FAST_READ_4 commands. > This results in flash read failures. At the same time, the m25p80 > emulation is seen to read 8 more bytes than expected. Adjusting the > expected number of dummy cycles to match FAST_READ fixes the problem. > > Fixes: f95c4bffdc4c ("aspeed/smc: snoop SPI transfers to fake dummy cycles") > Reviewed-by: Cédric Le Goater <clg@kaod.org> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > v2: No change > > hw/ssi/aspeed_smc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c > index 23c8d2f062..0444570750 100644 > --- a/hw/ssi/aspeed_smc.c > +++ b/hw/ssi/aspeed_smc.c > @@ -787,11 +787,11 @@ static int aspeed_smc_num_dummies(uint8_t command) > case FAST_READ: > case DOR: > case QOR: > + case FAST_READ_4: > case DOR_4: > case QOR_4: > return 1; > case DIOR: > - case FAST_READ_4: > case DIOR_4: > return 2; > case QIOR: > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 23c8d2f062..0444570750 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -787,11 +787,11 @@ static int aspeed_smc_num_dummies(uint8_t command) case FAST_READ: case DOR: case QOR: + case FAST_READ_4: case DOR_4: case QOR_4: return 1; case DIOR: - case FAST_READ_4: case DIOR_4: return 2; case QIOR:
The Linux kernel recently started using FAST_READ_4 commands. This results in flash read failures. At the same time, the m25p80 emulation is seen to read 8 more bytes than expected. Adjusting the expected number of dummy cycles to match FAST_READ fixes the problem. Fixes: f95c4bffdc4c ("aspeed/smc: snoop SPI transfers to fake dummy cycles") Reviewed-by: Cédric Le Goater <clg@kaod.org> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- v2: No change hw/ssi/aspeed_smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)