diff mbox series

[v3,2/2] block/curl: HTTP header field names are case insensitive

Message ID 20200224101310.101169-3-david.edmondson@oracle.com (mailing list archive)
State New, archived
Headers show
Series block/curl: Improve HTTP header parsing | expand

Commit Message

David Edmondson Feb. 24, 2020, 10:13 a.m. UTC
RFC 7230 section 3.2 indicates that HTTP header field names are case
insensitive.

Signed-off-by: David Edmondson <david.edmondson@oracle.com>
---
 block/curl.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Max Reitz Feb. 25, 2020, 5:17 p.m. UTC | #1
On 24.02.20 11:13, David Edmondson wrote:
> RFC 7230 section 3.2 indicates that HTTP header field names are case
> insensitive.
> 
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> ---
>  block/curl.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>
diff mbox series

Patch

diff --git a/block/curl.c b/block/curl.c
index f9ffb7f4e2bf..6e325901dc68 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -216,11 +216,12 @@  static size_t curl_header_cb(void *ptr, size_t size, size_t nmemb, void *opaque)
     size_t realsize = size * nmemb;
     const char *header = (char *)ptr;
     const char *end = header + realsize;
-    const char *accept_ranges = "Accept-Ranges:";
+    const char *accept_ranges = "accept-ranges:";
     const char *bytes = "bytes";
 
     if (realsize >= strlen(accept_ranges)
-        && strncmp(header, accept_ranges, strlen(accept_ranges)) == 0) {
+        && g_ascii_strncasecmp(header, accept_ranges,
+                               strlen(accept_ranges)) == 0) {
 
         char *p = strchr(header, ':') + 1;