| Message ID | 20200302130715.29440-5-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | redundant code: Fix warnings reported by Clang static code analyzer | expand |
Le 02/03/2020 à 14:07, Chen Qun a écrit : > Clang static code analyzer show warning: > block/file-posix.c:891:9: warning: Value stored to 'op' is never read > op = RAW_PL_ABORT; > ^ ~~~~~~~~~~~~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > Reviewed-by: Kevin Wolf <kwolf@redhat.com> > --- > Cc: Kevin Wolf <kwolf@redhat.com> > Cc: Max Reitz <mreitz@redhat.com> > --- > block/file-posix.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/file-posix.c b/block/file-posix.c > index 6345477112..0f77447a25 100644 > --- a/block/file-posix.c > +++ b/block/file-posix.c > @@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs, > "Is another process using the image [%s]?\n", > bs->filename); > } > - op = RAW_PL_ABORT; > /* fall through to unlock bytes. */ > case RAW_PL_ABORT: > raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm, > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/block/file-posix.c b/block/file-posix.c index 6345477112..0f77447a25 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs, "Is another process using the image [%s]?\n", bs->filename); } - op = RAW_PL_ABORT; /* fall through to unlock bytes. */ case RAW_PL_ABORT: raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm,
Clang static code analyzer show warning: block/file-posix.c:891:9: warning: Value stored to 'op' is never read op = RAW_PL_ABORT; ^ ~~~~~~~~~~~~ Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> --- Cc: Kevin Wolf <kwolf@redhat.com> Cc: Max Reitz <mreitz@redhat.com> --- block/file-posix.c | 1 - 1 file changed, 1 deletion(-)