| Message ID | 20200302130715.29440-7-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | redundant code: Fix warnings reported by Clang static code analyzer | expand |
Le 02/03/2020 à 14:07, Chen Qun a écrit : > Clang static code analyzer show warning: > scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read > buflen = req->cmd.xfer; > ^ ~~~~~~~~~~~~~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Fam Zheng <fam@euphon.net> > --- > hw/scsi/scsi-disk.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index 10d0794d60..1c0cb63a6f 100644 > --- a/hw/scsi/scsi-disk.c > +++ b/hw/scsi/scsi-disk.c > @@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf) > r->iov.iov_base = blk_blockalign(s->qdev.conf.blk, r->buflen); > } > > - buflen = req->cmd.xfer; > outbuf = r->iov.iov_base; > memset(outbuf, 0, r->buflen); > switch (req->cmd.buf[0]) { > Fixes: c8dcb531bcd3 ("scsi: do not return short responses for emulated commands") Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Le 02/03/2020 à 14:07, Chen Qun a écrit : > Clang static code analyzer show warning: > scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read > buflen = req->cmd.xfer; > ^ ~~~~~~~~~~~~~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Fam Zheng <fam@euphon.net> > --- > hw/scsi/scsi-disk.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index 10d0794d60..1c0cb63a6f 100644 > --- a/hw/scsi/scsi-disk.c > +++ b/hw/scsi/scsi-disk.c > @@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf) > r->iov.iov_base = blk_blockalign(s->qdev.conf.blk, r->buflen); > } > > - buflen = req->cmd.xfer; > outbuf = r->iov.iov_base; > memset(outbuf, 0, r->buflen); > switch (req->cmd.buf[0]) { > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 10d0794d60..1c0cb63a6f 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf) r->iov.iov_base = blk_blockalign(s->qdev.conf.blk, r->buflen); } - buflen = req->cmd.xfer; outbuf = r->iov.iov_base; memset(outbuf, 0, r->buflen); switch (req->cmd.buf[0]) {
Clang static code analyzer show warning: scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read buflen = req->cmd.xfer; ^ ~~~~~~~~~~~~~ Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> --- Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Fam Zheng <fam@euphon.net> --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 deletion(-)