| Message ID | 20200302130715.29440-8-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | redundant code: Fix warnings reported by Clang static code analyzer | expand |
Le 02/03/2020 à 14:07, Chen Qun a écrit : > Clang static code analyzer show warning: > hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read > format = 0; > ^ ~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > Cc: Andrzej Zaborowski <balrogg@gmail.com> > Cc: Peter Maydell <peter.maydell@linaro.org> > --- > hw/display/pxa2xx_lcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c > index 05f5f84671..464e93161a 100644 > --- a/hw/display/pxa2xx_lcd.c > +++ b/hw/display/pxa2xx_lcd.c > @@ -593,7 +593,6 @@ static void pxa2xx_palette_parse(PXA2xxLCDState *s, int ch, int bpp) > n = 256; > break; > default: > - format = 0; > return; > } > > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Le 02/03/2020 à 14:07, Chen Qun a écrit : > Clang static code analyzer show warning: > hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read > format = 0; > ^ ~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > Cc: Andrzej Zaborowski <balrogg@gmail.com> > Cc: Peter Maydell <peter.maydell@linaro.org> > --- > hw/display/pxa2xx_lcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c > index 05f5f84671..464e93161a 100644 > --- a/hw/display/pxa2xx_lcd.c > +++ b/hw/display/pxa2xx_lcd.c > @@ -593,7 +593,6 @@ static void pxa2xx_palette_parse(PXA2xxLCDState *s, int ch, int bpp) > n = 256; > break; > default: > - format = 0; > return; > } > > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c index 05f5f84671..464e93161a 100644 --- a/hw/display/pxa2xx_lcd.c +++ b/hw/display/pxa2xx_lcd.c @@ -593,7 +593,6 @@ static void pxa2xx_palette_parse(PXA2xxLCDState *s, int ch, int bpp) n = 256; break; default: - format = 0; return; }
Clang static code analyzer show warning: hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read format = 0; ^ ~ Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> --- Cc: Andrzej Zaborowski <balrogg@gmail.com> Cc: Peter Maydell <peter.maydell@linaro.org> --- hw/display/pxa2xx_lcd.c | 1 - 1 file changed, 1 deletion(-)