| Message ID | 20200302130715.29440-9-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | redundant code: Fix warnings reported by Clang static code analyzer | expand |
Le 02/03/2020 à 14:07, Chen Qun a écrit : > Clang static code analyzer show warning: > hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is never read > is_dirty = false; > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > Cc: Igor Mitsyanko <i.mitsyanko@gmail.com> > Cc: Peter Maydell <peter.maydell@linaro.org> > --- > hw/display/exynos4210_fimd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c > index c1071ecd46..05d3265b76 100644 > --- a/hw/display/exynos4210_fimd.c > +++ b/hw/display/exynos4210_fimd.c > @@ -1310,7 +1310,6 @@ static void exynos4210_fimd_update(void *opaque) > } > host_fb_addr += inc_size; > fb_line_addr += inc_size; > - is_dirty = false; > } > g_free(snap); > blend = true; > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Le 02/03/2020 à 14:07, Chen Qun a écrit : > Clang static code analyzer show warning: > hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is never read > is_dirty = false; > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > Cc: Igor Mitsyanko <i.mitsyanko@gmail.com> > Cc: Peter Maydell <peter.maydell@linaro.org> > --- > hw/display/exynos4210_fimd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c > index c1071ecd46..05d3265b76 100644 > --- a/hw/display/exynos4210_fimd.c > +++ b/hw/display/exynos4210_fimd.c > @@ -1310,7 +1310,6 @@ static void exynos4210_fimd_update(void *opaque) > } > host_fb_addr += inc_size; > fb_line_addr += inc_size; > - is_dirty = false; > } > g_free(snap); > blend = true; > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c index c1071ecd46..05d3265b76 100644 --- a/hw/display/exynos4210_fimd.c +++ b/hw/display/exynos4210_fimd.c @@ -1310,7 +1310,6 @@ static void exynos4210_fimd_update(void *opaque) } host_fb_addr += inc_size; fb_line_addr += inc_size; - is_dirty = false; } g_free(snap); blend = true;
Clang static code analyzer show warning: hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is never read is_dirty = false; Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> --- Cc: Igor Mitsyanko <i.mitsyanko@gmail.com> Cc: Peter Maydell <peter.maydell@linaro.org> --- hw/display/exynos4210_fimd.c | 1 - 1 file changed, 1 deletion(-)