| Message ID | 20200305200558.71104-2-palmerdabbelt@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [PULL] RISC-V: Add a missing "," in riscv_excp_names | expand |
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index c47d10b739..c0b7023100 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -66,7 +66,7 @@ const char * const riscv_excp_names[] = { "exec_page_fault", "load_page_fault", "reserved", - "store_page_fault" + "store_page_fault", "reserved", "reserved", "reserved", @@ -74,7 +74,7 @@ const char * const riscv_excp_names[] = { "guest_exec_page_fault", "guest_load_page_fault", "reserved", - "guest_store_page_fault" + "guest_store_page_fault", }; const char * const riscv_intr_names[] = {
This would almost certainly cause the exception names to be reported incorrectly. Coverity found the issue (CID 1420223). As per Peter's suggestion, I've also added a comma at the end of the list to avoid the issue reappearing in the future. Fixes: ab67a1d07a ("target/riscv: Add support for the new execption numbers") Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com> --- target/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)