| Message ID | 20200505085940.28592-1-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] crypto: Redundant type conversion for AES_KEY pointer | expand |
On Tue, May 05, 2020 at 04:59:40PM +0800, Chen Qun wrote: > We can delete the redundant type conversion if > we set the the AES_KEY parameter with 'const' in > qcrypto_cipher_aes_ecb_(en|de)crypt() function. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > v1->v2: > Cc: "Daniel P. Berrangé" <berrange@redhat.com> > > Modify the AES_KEY parameter with 'const' in > qcrypto_cipher_aes_ecb_(en|de)crypt() methods. > (Base on Daniel P. Berrangé's suggestion) > > https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg00515.html > > --- > crypto/cipher-builtin.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> and queued - will send a PR with this and some other crypto fixes later today most likely. Regards, Daniel
diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c index bf8413e71a..35cf7820d9 100644 --- a/crypto/cipher-builtin.c +++ b/crypto/cipher-builtin.c @@ -74,7 +74,7 @@ static void qcrypto_cipher_free_aes(QCryptoCipher *cipher) } -static void qcrypto_cipher_aes_ecb_encrypt(AES_KEY *key, +static void qcrypto_cipher_aes_ecb_encrypt(const AES_KEY *key, const void *in, void *out, size_t len) @@ -100,7 +100,7 @@ static void qcrypto_cipher_aes_ecb_encrypt(AES_KEY *key, } -static void qcrypto_cipher_aes_ecb_decrypt(AES_KEY *key, +static void qcrypto_cipher_aes_ecb_decrypt(const AES_KEY *key, const void *in, void *out, size_t len) @@ -133,8 +133,7 @@ static void qcrypto_cipher_aes_xts_encrypt(const void *ctx, { const QCryptoCipherBuiltinAESContext *aesctx = ctx; - qcrypto_cipher_aes_ecb_encrypt((AES_KEY *)&aesctx->enc, - src, dst, length); + qcrypto_cipher_aes_ecb_encrypt(&aesctx->enc, src, dst, length); } @@ -145,8 +144,7 @@ static void qcrypto_cipher_aes_xts_decrypt(const void *ctx, { const QCryptoCipherBuiltinAESContext *aesctx = ctx; - qcrypto_cipher_aes_ecb_decrypt((AES_KEY *)&aesctx->dec, - src, dst, length); + qcrypto_cipher_aes_ecb_decrypt(&aesctx->dec, src, dst, length); }
We can delete the redundant type conversion if we set the the AES_KEY parameter with 'const' in qcrypto_cipher_aes_ecb_(en|de)crypt() function. Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> --- v1->v2: Cc: "Daniel P. Berrangé" <berrange@redhat.com> Modify the AES_KEY parameter with 'const' in qcrypto_cipher_aes_ecb_(en|de)crypt() methods. (Base on Daniel P. Berrangé's suggestion) https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg00515.html --- crypto/cipher-builtin.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)