diff mbox series

[v2,06/15] tests/tcg/tricore: Add macros to create tests and first test 'abs'

Message ID 20200604085441.103087-7-kbastian@mail.uni-paderborn.de (mailing list archive)
State New, archived
Headers show
Series tests/tcg: Add TriCore tests | expand

Commit Message

Bastian Koppelmann June 4, 2020, 8:54 a.m. UTC
This kind of tests is inspired by the riscv-tests repository. This adds
macros that makes it easy to create single instruction self containing
tests.

It is achieved by macros that create a test sequence for an
instruction and check for a supplied correct value. If the value is correct the
next instruction is tested. Otherwise we jump to fail handler that writes is
test number as a status code back to qemu that then exits on that status code.
If all tests pass we write back 0 as a status code and exit.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
 tests/tcg/configure.sh                    |  7 ++-
 tests/tcg/tricore/Makefile.softmmu-target |  2 +
 tests/tcg/tricore/macros.h                | 53 +++++++++++++++++++++++
 tests/tcg/tricore/test_abs.S              |  8 ++++
 4 files changed, 69 insertions(+), 1 deletion(-)
 create mode 100644 tests/tcg/tricore/macros.h
 create mode 100644 tests/tcg/tricore/test_abs.S

Comments

Alex Bennée June 16, 2020, 5:28 p.m. UTC | #1
Bastian Koppelmann <kbastian@mail.uni-paderborn.de> writes:

> This kind of tests is inspired by the riscv-tests repository. This adds
> macros that makes it easy to create single instruction self containing
> tests.
>
> It is achieved by macros that create a test sequence for an
> instruction and check for a supplied correct value. If the value is correct the
> next instruction is tested. Otherwise we jump to fail handler that writes is
> test number as a status code back to qemu that then exits on that status code.
> If all tests pass we write back 0 as a status code and exit.
>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
>  tests/tcg/configure.sh                    |  7 ++-
>  tests/tcg/tricore/Makefile.softmmu-target |  2 +
>  tests/tcg/tricore/macros.h                | 53 +++++++++++++++++++++++
>  tests/tcg/tricore/test_abs.S              |  8 ++++
>  4 files changed, 69 insertions(+), 1 deletion(-)
>  create mode 100644 tests/tcg/tricore/macros.h
>  create mode 100644 tests/tcg/tricore/test_abs.S
>
> diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
> index 6e8659d488..cd857433d9 100755
> --- a/tests/tcg/configure.sh
> +++ b/tests/tcg/configure.sh
> @@ -85,7 +85,7 @@ for target in $target_list; do
>      xtensa|xtensaeb)
>        arches=xtensa
>        ;;
> -    alpha|cris|hppa|i386|lm32|m68k|openrisc|riscv64|s390x|sh4|sparc64)
> +    alpha|cris|hppa|i386|lm32|m68k|openrisc|riscv64|s390x|sh4|sparc64|tricore)
>        arches=$target
>        ;;
>      *)
> @@ -169,6 +169,11 @@ for target in $target_list; do
>        container_image=debian-sparc64-cross
>        container_cross_cc=sparc64-linux-gnu-gcc
>        ;;
> +    tricore-softmmu)
> +        container_image=debian-tricore-cross
> +        container_cross_as=tricore-as
> +        container_cross_ld=tricore-ld
> +        ;;
>      xtensa*-softmmu)
>        container_image=debian-xtensa-cross

I'd of been tempted to include this with the build infrastructure patch
but whatever...

>  
> diff --git a/tests/tcg/tricore/Makefile.softmmu-target b/tests/tcg/tricore/Makefile.softmmu-target
> index 4a2cd6f218..1b1f220c7c 100644
> --- a/tests/tcg/tricore/Makefile.softmmu-target
> +++ b/tests/tcg/tricore/Makefile.softmmu-target
> @@ -7,6 +7,8 @@ ASFLAGS =
>  
>  QEMU_OPTS += -M tricore_testboard -nographic -kernel
>  
> +TESTS += test_abs.tst
> +

Also you could use wildcards so adding new tests is simpler but anyway:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
diff mbox series

Patch

diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
index 6e8659d488..cd857433d9 100755
--- a/tests/tcg/configure.sh
+++ b/tests/tcg/configure.sh
@@ -85,7 +85,7 @@  for target in $target_list; do
     xtensa|xtensaeb)
       arches=xtensa
       ;;
-    alpha|cris|hppa|i386|lm32|m68k|openrisc|riscv64|s390x|sh4|sparc64)
+    alpha|cris|hppa|i386|lm32|m68k|openrisc|riscv64|s390x|sh4|sparc64|tricore)
       arches=$target
       ;;
     *)
@@ -169,6 +169,11 @@  for target in $target_list; do
       container_image=debian-sparc64-cross
       container_cross_cc=sparc64-linux-gnu-gcc
       ;;
+    tricore-softmmu)
+        container_image=debian-tricore-cross
+        container_cross_as=tricore-as
+        container_cross_ld=tricore-ld
+        ;;
     xtensa*-softmmu)
       container_image=debian-xtensa-cross
 
diff --git a/tests/tcg/tricore/Makefile.softmmu-target b/tests/tcg/tricore/Makefile.softmmu-target
index 4a2cd6f218..1b1f220c7c 100644
--- a/tests/tcg/tricore/Makefile.softmmu-target
+++ b/tests/tcg/tricore/Makefile.softmmu-target
@@ -7,6 +7,8 @@  ASFLAGS =
 
 QEMU_OPTS += -M tricore_testboard -nographic -kernel
 
+TESTS += test_abs.tst
+
 %.pS: $(TESTS_PATH)/%.S
 	$(HOST_CC) -E -o $@ $<
 
diff --git a/tests/tcg/tricore/macros.h b/tests/tcg/tricore/macros.h
new file mode 100644
index 0000000000..76c133132a
--- /dev/null
+++ b/tests/tcg/tricore/macros.h
@@ -0,0 +1,53 @@ 
+/* Helpers */
+#define LI(reg, val)           \
+    mov.u reg, lo:val;         \
+    movh DREG_TEMP_LI, up:val; \
+    or reg, reg, DREG_TEMP_LI; \
+
+/* Address definitions */
+#define TESTDEV_ADDR 0xf0000000
+/* Register definitions */
+#define DREG_RS1 %d0
+#define DREG_CALC_RESULT %d1
+#define DREG_TEMP_LI %d10
+#define DREG_TEMP %d11
+#define DREG_TEST_NUM %d14
+#define DREG_CORRECT_RESULT %d15
+
+#define DREG_DEV_ADDR %a15
+
+/* Test case wrappers */
+#define TEST_CASE(num, testreg, correct, code...) \
+test_ ## num:                                     \
+    code;                                         \
+    LI(DREG_CORRECT_RESULT, correct)              \
+    mov DREG_TEST_NUM, num;                       \
+    jne testreg, DREG_CORRECT_RESULT, fail        \
+
+/* Actual test case type
+ * e.g inst %dX, %dY      -> TEST_D_D
+ *     inst %dX, %dY, %dZ -> TEST_D_DD
+ *     inst %eX, %dY, %dZ -> TEST_E_DD
+ */
+#define TEST_D_D(insn, num, result, rs1)      \
+    TEST_CASE(num, DREG_CALC_RESULT, result,  \
+    LI(DREG_RS1, rs1);                        \
+    insn DREG_CALC_RESULT, DREG_RS1;          \
+    )
+
+/* Pass/Fail handling part */
+#define TEST_PASSFAIL                       \
+        j pass;                             \
+fail:                                       \
+        LI(DREG_TEMP, TESTDEV_ADDR)         \
+        mov.a DREG_DEV_ADDR, DREG_TEMP;     \
+        st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
+        debug;                              \
+        j fail;                             \
+pass:                                       \
+        LI(DREG_TEMP, TESTDEV_ADDR)         \
+        mov.a DREG_DEV_ADDR, DREG_TEMP;     \
+        mov DREG_TEST_NUM, 0;               \
+        st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
+        debug;                              \
+        j pass;
diff --git a/tests/tcg/tricore/test_abs.S b/tests/tcg/tricore/test_abs.S
new file mode 100644
index 0000000000..acc143901c
--- /dev/null
+++ b/tests/tcg/tricore/test_abs.S
@@ -0,0 +1,8 @@ 
+#include "macros.h"
+.text
+.global _start
+_start:
+    TEST_D_D(abs, 1, 0, 0)
+
+    TEST_PASSFAIL
+