| Message ID | 20200626164307.3327380-11-dinechin@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RFC: Move SPICE to a load module | expand |
On Fri, Jun 26, 2020 at 06:43:07PM +0200, Christophe de Dinechin wrote: > Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> > --- > include/qemu/module.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/qemu/module.h b/include/qemu/module.h > index 1922a0293c..8d6e10ba81 100644 > --- a/include/qemu/module.h > +++ b/include/qemu/module.h > @@ -14,10 +14,13 @@ > #ifndef QEMU_MODULE_H > #define QEMU_MODULE_H > > +#include "trace/recorder.h" > > #define DSO_STAMP_FUN glue(qemu_stamp, CONFIG_STAMP) > #define DSO_STAMP_FUN_STR stringify(DSO_STAMP_FUN) > > +RECORDER_DECLARE(modules); > + > #ifdef BUILD_DSO > void DSO_STAMP_FUN(void); > /* This is a dummy symbol to identify a loaded DSO as a QEMU module, so we can > @@ -55,6 +58,7 @@ static void __attribute__((constructor)) do_qemu_init_ ## function(void) \ > static void __attribute__((constructor)) Name##_register(void) \ > { \ > Name = Name##_implementation; \ > + record(modules, "Setting " #Name " to %p", Name); \ > } \ > Ret Name##_implementation Args > #else /* !CONFIG_MODULES */ Contrary to the commit $SUBJECT, I think you should keep this, not remove it. It should use QEMU's trace backend though. Regards, Daniel
On 2020-06-26 at 19:29 CEST, Daniel P. Berrangé wrote... > On Fri, Jun 26, 2020 at 06:43:07PM +0200, Christophe de Dinechin wrote: >> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> >> --- >> include/qemu/module.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/qemu/module.h b/include/qemu/module.h >> index 1922a0293c..8d6e10ba81 100644 >> --- a/include/qemu/module.h >> +++ b/include/qemu/module.h >> @@ -14,10 +14,13 @@ >> #ifndef QEMU_MODULE_H >> #define QEMU_MODULE_H >> >> +#include "trace/recorder.h" >> >> #define DSO_STAMP_FUN glue(qemu_stamp, CONFIG_STAMP) >> #define DSO_STAMP_FUN_STR stringify(DSO_STAMP_FUN) >> >> +RECORDER_DECLARE(modules); >> + >> #ifdef BUILD_DSO >> void DSO_STAMP_FUN(void); >> /* This is a dummy symbol to identify a loaded DSO as a QEMU module, so we can >> @@ -55,6 +58,7 @@ static void __attribute__((constructor)) do_qemu_init_ ## function(void) \ >> static void __attribute__((constructor)) Name##_register(void) \ >> { \ >> Name = Name##_implementation; \ >> + record(modules, "Setting " #Name " to %p", Name); \ >> } \ >> Ret Name##_implementation Args >> #else /* !CONFIG_MODULES */ > > Contrary to the commit $SUBJECT, I think you should keep this, not remove > it. It should use QEMU's trace backend though. OK. Will add a trace backend version in next iteration. > > Regards, > Daniel -- Cheers, Christophe de Dinechin (IRC c3d)
diff --git a/include/qemu/module.h b/include/qemu/module.h index 1922a0293c..8d6e10ba81 100644 --- a/include/qemu/module.h +++ b/include/qemu/module.h @@ -14,10 +14,13 @@ #ifndef QEMU_MODULE_H #define QEMU_MODULE_H +#include "trace/recorder.h" #define DSO_STAMP_FUN glue(qemu_stamp, CONFIG_STAMP) #define DSO_STAMP_FUN_STR stringify(DSO_STAMP_FUN) +RECORDER_DECLARE(modules); + #ifdef BUILD_DSO void DSO_STAMP_FUN(void); /* This is a dummy symbol to identify a loaded DSO as a QEMU module, so we can @@ -55,6 +58,7 @@ static void __attribute__((constructor)) do_qemu_init_ ## function(void) \ static void __attribute__((constructor)) Name##_register(void) \ { \ Name = Name##_implementation; \ + record(modules, "Setting " #Name " to %p", Name); \ } \ Ret Name##_implementation Args #else /* !CONFIG_MODULES */
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> --- include/qemu/module.h | 4 ++++ 1 file changed, 4 insertions(+)