diff mbox series

[3/7] minikconf: Pass variables for modules

Message ID 20200723174615.2370096-4-dinechin@redhat.com (mailing list archive)
State New, archived
Headers show
Series Make SPICE a load module | expand

Commit Message

Christophe de Dinechin July 23, 2020, 5:46 p.m. UTC
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
---
 scripts/minikconf.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Gerd Hoffmann Aug. 4, 2020, 6:19 a.m. UTC | #1
On Thu, Jul 23, 2020 at 07:46:11PM +0200, Christophe de Dinechin wrote:
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
>  scripts/minikconf.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/minikconf.py b/scripts/minikconf.py
> index bcd91015d3..d60add97f6 100755
> --- a/scripts/minikconf.py
> +++ b/scripts/minikconf.py
> @@ -690,10 +690,10 @@ if __name__ == '__main__':
>      parser = KconfigParser(data)
>      external_vars = set()
>      for arg in argv[3:]:
> -        m = re.match(r'^(CONFIG_[A-Z0-9_]+)=([yn]?)$', arg)
> +        m = re.match(r'^(CONFIG_[A-Z0-9_]+)=([ymn]?)$', arg)
>          if m is not None:
>              name, value = m.groups()
> -            parser.do_assignment(name, value == 'y')
> +            parser.do_assignment(name, value == 'y' or value == 'm')
>              external_vars.add(name[7:])
>          else:
>              fp = open(arg, 'rt', encoding='utf-8')

Hmm, I somehow doubt it is _that_ simple, miniconf supports only bool
(y+n) not tristate (y+n+m) ...

take care,
  Gerd
diff mbox series

Patch

diff --git a/scripts/minikconf.py b/scripts/minikconf.py
index bcd91015d3..d60add97f6 100755
--- a/scripts/minikconf.py
+++ b/scripts/minikconf.py
@@ -690,10 +690,10 @@  if __name__ == '__main__':
     parser = KconfigParser(data)
     external_vars = set()
     for arg in argv[3:]:
-        m = re.match(r'^(CONFIG_[A-Z0-9_]+)=([yn]?)$', arg)
+        m = re.match(r'^(CONFIG_[A-Z0-9_]+)=([ymn]?)$', arg)
         if m is not None:
             name, value = m.groups()
-            parser.do_assignment(name, value == 'y')
+            parser.do_assignment(name, value == 'y' or value == 'm')
             external_vars.add(name[7:])
         else:
             fp = open(arg, 'rt', encoding='utf-8')