| Message ID | 20200723174615.2370096-5-dinechin@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Make SPICE a load module | expand |
On Thu, Jul 23, 2020 at 07:46:12PM +0200, Christophe de Dinechin wrote: > This commit changes the spice configuration 'm' by default, and moves > the spice components to obj-m variables. It is sufficient to build > without modules enable, but does not link correctly yet, since no > shims have been created for the missing functions yet. So it breaks the modular build? Don't do that, it is bad for bisecting. I guess this patch should simply come later in the patch series. I can see that it is useful to have it here for development, so you easily find all the places which need a fixup, but for merging the patches should be reordered. take care, Gerd
diff --git a/chardev/Makefile.objs b/chardev/Makefile.objs index 3783dadc4c..7cf05c9541 100644 --- a/chardev/Makefile.objs +++ b/chardev/Makefile.objs @@ -26,4 +26,5 @@ baum.o-cflags := $(SDL_CFLAGS) baum.o-libs := $(BRLAPI_LIBS) endif -common-obj-$(CONFIG_SPICE) += spice.o +common-obj-$(CONFIG_SPICE) += spice.mo +spice.mo-objs := spice.o diff --git a/configure b/configure index 4bd80ed507..054aab31be 100755 --- a/configure +++ b/configure @@ -7534,7 +7534,7 @@ if test "$posix_memalign" = "yes" ; then fi if test "$spice" = "yes" ; then - echo "CONFIG_SPICE=y" >> $config_host_mak + echo "CONFIG_SPICE=m" >> $config_host_mak fi if test "$smartcard" = "yes" ; then
This commit changes the spice configuration 'm' by default, and moves the spice components to obj-m variables. It is sufficient to build without modules enable, but does not link correctly yet, since no shims have been created for the missing functions yet. Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> --- chardev/Makefile.objs | 3 ++- configure | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)