| Message ID | 20200817140144.373403-2-edgar.iglesias@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/microblaze: Enable MTTCG | expand |
On 8/17/20 7:01 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Transfer dc->rd to mbar_imm to improve the readability when > comparing to the specs. > > No functional change. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > --- > target/microblaze/translate.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Mon, Aug 17, 2020 at 7:04 AM Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote: > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Transfer dc->rd to mbar_imm to improve the readability when > comparing to the specs. > > No functional change. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > target/microblaze/translate.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c > index f6ff2591c3..47637f152b 100644 > --- a/target/microblaze/translate.c > +++ b/target/microblaze/translate.c > @@ -1229,8 +1229,10 @@ static void dec_br(DisasContext *dc) > /* Memory barrier. */ > mbar = (dc->ir >> 16) & 31; > if (mbar == 2 && dc->imm == 4) { > + uint16_t mbar_imm = dc->rd; > + > /* mbar IMM & 16 decodes to sleep. */ > - if (dc->rd & 16) { > + if (mbar_imm & 16) { > TCGv_i32 tmp_hlt = tcg_const_i32(EXCP_HLT); > TCGv_i32 tmp_1 = tcg_const_i32(1); > > @@ -1246,7 +1248,7 @@ static void dec_br(DisasContext *dc) > tcg_temp_free_i32(tmp_1); > return; > } > - LOG_DIS("mbar %d\n", dc->rd); > + LOG_DIS("mbar %d\n", mbar_imm); > /* Break the TB. */ > dc->cpustate_changed = 1; > return; > -- > 2.25.1 > >
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index f6ff2591c3..47637f152b 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1229,8 +1229,10 @@ static void dec_br(DisasContext *dc) /* Memory barrier. */ mbar = (dc->ir >> 16) & 31; if (mbar == 2 && dc->imm == 4) { + uint16_t mbar_imm = dc->rd; + /* mbar IMM & 16 decodes to sleep. */ - if (dc->rd & 16) { + if (mbar_imm & 16) { TCGv_i32 tmp_hlt = tcg_const_i32(EXCP_HLT); TCGv_i32 tmp_1 = tcg_const_i32(1); @@ -1246,7 +1248,7 @@ static void dec_br(DisasContext *dc) tcg_temp_free_i32(tmp_1); return; } - LOG_DIS("mbar %d\n", dc->rd); + LOG_DIS("mbar %d\n", mbar_imm); /* Break the TB. */ dc->cpustate_changed = 1; return;