[3/3] vhost-vsock-ccw: force virtio version 1

Commit Message

Stefano Garzarella Aug. 19, 2020, 10:51 a.m. UTC

virtio-vsock was introduced after the release of VIRTIO 1.0
specifications, so it should be 'modern-only'.

This patch forces virtio version 1 as done for vhost-vsock-pci.

Cc: [e-mail]
Suggested-by: Cornelia Huck <[e-mail]>
Signed-off-by: Stefano Garzarella <[e-mail]>
---
 hw/s390x/vhost-vsock-ccw.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Cornelia Huck Aug. 19, 2020, 12:01 p.m. UTC | #1

On Wed, 19 Aug 2020 12:51:56 +0200
Stefano Garzarella <[e-mail]> wrote:

> virtio-vsock was introduced after the release of VIRTIO 1.0
> specifications, so it should be 'modern-only'.
> 
> This patch forces virtio version 1 as done for vhost-vsock-pci.
> 
> Cc: [e-mail]
> Suggested-by: Cornelia Huck <[e-mail]>
> Signed-off-by: Stefano Garzarella <[e-mail]>
> ---
>  hw/s390x/vhost-vsock-ccw.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Cornelia Huck <[e-mail]>

Patch

diff --git a/hw/s390x/vhost-vsock-ccw.c b/hw/s390x/vhost-vsock-ccw.c
index 0822ecca89..0759143efa 100644
--- a/hw/s390x/vhost-vsock-ccw.c
+++ b/hw/s390x/vhost-vsock-ccw.c
@@ -40,7 +40,9 @@  static void vhost_vsock_ccw_class_init(ObjectClass *klass, void *data)
 static void vhost_vsock_ccw_instance_init(Object *obj)
 {
     VHostVSockCCWState *dev = VHOST_VSOCK_CCW(obj);
+    VirtioCcwDevice *ccw_dev = VIRTIO_CCW_DEVICE(obj);
 
+    ccw_dev->force_revision_1 = true;
     virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
                                 TYPE_VHOST_VSOCK);
 }