| Message ID | 20200825001649.1811-1-luoyonggang@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | meson: Mingw64 gcc doesn't recognize system include_type for sdl2 | expand |
Hi On Tue, Aug 25, 2020 at 4:17 AM <luoyonggang@gmail.com> wrote: > From: Yonggang Luo <luoyonggang@gmail.com> > > --- > meson.build | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/meson.build b/meson.build > index df5bf728b5..a3585881e1 100644 > --- a/meson.build > +++ b/meson.build > @@ -224,8 +224,7 @@ if 'CONFIG_BRLAPI' in config_host > brlapi = declare_dependency(link_args: > config_host['BRLAPI_LIBS'].split()) > endif > > -sdl = dependency('sdl2', required: get_option('sdl'), static: > enable_static, > - include_type: 'system') > +sdl = dependency('sdl2', required: get_option('sdl'), static: > enable_static) > sdl_image = not_found > if sdl.found() > # work around 2.0.8 bug > -- > 2.27.0.windows.1 > > > Which version of gcc are you using? Paolo, why did you you -isystem includes here? (if it's on purpose, it's worth to document it in build-system.rst since it takes sdl as an example and doesn't mention this)
I am using gcc 10 ``` $ gcc -v Using built-in specs. COLLECT_GCC=C:\CI-Tools\msys64\mingw64\bin\gcc.exe COLLECT_LTO_WRAPPER=C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/lto-wrapper.exe Target: x86_64-w64-mingw32 Configured with: ../gcc-10.2.0/configure --prefix=/mingw64 --with-local-prefix=/mingw64/local --build=x86_64-w64-mingw32 --host=x86_64-w64-mingw32 --target=x86_64-w64-mingw32 --with-native-system-header-dir=/mingw64/x86_64-w64-mingw32/include --libexecdir=/mingw64/lib --enable-bootstrap --with-arch=x86-64 --with-tune=generic --enable-languages=c,lto,c++,fortran,ada,objc,obj-c++ --enable-shared --enable-static --enable-libatomic --enable-threads=posix --enable-graphite --enable-fully-dynamic-string --enable-libstdcxx-filesystem-ts=yes --enable-libstdcxx-time=yes --disable-libstdcxx-pch --disable-libstdcxx-debug --disable-isl-version-check --enable-lto --enable-libgomp --disable-multilib --enable-checking=release --disable-rpath --disable-win32-registry --disable-nls --disable-werror --disable-symvers --disable-plugin --with-libiconv --with-system-zlib --with-gmp=/mingw64 --with-mpfr=/mingw64 --with-mpc=/mingw64 --with-isl=/mingw64 --with-pkgversion='Rev1, Built by MSYS2 project' --with-bugurl= https://github.com/msys2/MINGW-packages/issues --with-gnu-as --with-gnu-ld Thread model: posix Supported LTO compression algorithms: zlib zstd gcc version 10.2.0 (Rev1, Built by MSYS2 project) ``` On Tue, Aug 25, 2020 at 6:25 PM Marc-André Lureau < marcandre.lureau@gmail.com> wrote: > Hi > > On Tue, Aug 25, 2020 at 4:17 AM <luoyonggang@gmail.com> wrote: > >> From: Yonggang Luo <luoyonggang@gmail.com> >> >> --- >> meson.build | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/meson.build b/meson.build >> index df5bf728b5..a3585881e1 100644 >> --- a/meson.build >> +++ b/meson.build >> @@ -224,8 +224,7 @@ if 'CONFIG_BRLAPI' in config_host >> brlapi = declare_dependency(link_args: >> config_host['BRLAPI_LIBS'].split()) >> endif >> >> -sdl = dependency('sdl2', required: get_option('sdl'), static: >> enable_static, >> - include_type: 'system') >> +sdl = dependency('sdl2', required: get_option('sdl'), static: >> enable_static) >> sdl_image = not_found >> if sdl.found() >> # work around 2.0.8 bug >> -- >> 2.27.0.windows.1 >> >> >> > Which version of gcc are you using? > > Paolo, why did you you -isystem includes here? (if it's on purpose, it's > worth to document it in build-system.rst since it takes sdl as an example > and doesn't mention this) > > > -- > Marc-André Lureau >
Patchew URL: https://patchew.org/QEMU/20200825001649.1811-1-luoyonggang@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200825001649.1811-1-luoyonggang@gmail.com Subject: [PATCH] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200826184334.4120620-1-ehabkost@redhat.com -> patchew/20200826184334.4120620-1-ehabkost@redhat.com Switched to a new branch 'test' 700cdc8 meson: Mingw64 gcc doesn't recognize system include_type for sdl2 === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 9 lines checked Commit 700cdc84f4ae (meson: Mingw64 gcc doesn't recognize system include_type for sdl2) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200825001649.1811-1-luoyonggang@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
diff --git a/meson.build b/meson.build index df5bf728b5..a3585881e1 100644 --- a/meson.build +++ b/meson.build @@ -224,8 +224,7 @@ if 'CONFIG_BRLAPI' in config_host brlapi = declare_dependency(link_args: config_host['BRLAPI_LIBS'].split()) endif -sdl = dependency('sdl2', required: get_option('sdl'), static: enable_static, - include_type: 'system') +sdl = dependency('sdl2', required: get_option('sdl'), static: enable_static) sdl_image = not_found if sdl.found() # work around 2.0.8 bug
From: Yonggang Luo <luoyonggang@gmail.com> --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)