| Message ID | 20200909094617.1582-14-luoyonggang@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | W32, W64 msys2/mingw patches | expand |
On Wed, Sep 09, 2020 at 05:46:09PM +0800, Yonggang Luo wrote: > The vmstate are valid on win32, just need generate tmp path properly > > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Reviewed-by: Thomas Huth <thuth@redhat.com> > --- > tests/test-vmstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c > index f8de709a0b..51fe8e8ec5 100644 > --- a/tests/test-vmstate.c > +++ b/tests/test-vmstate.c > @@ -34,7 +34,6 @@ > #include "qemu/module.h" > #include "io/channel-file.h" > > -static char temp_file[] = "/tmp/vmst.test.XXXXXX"; > static int temp_fd; > > > @@ -1487,6 +1486,7 @@ static void test_tmp_struct(void) > > int main(int argc, char **argv) > { > + g_autofree char *temp_file = g_strdup_printf("%s/vmst.test.XXXXXX", g_get_tmp_dir()); Could do with a line break before the arg. I'm surprised 'checkpatch.pl' didn't complain about this. With the line break Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index f8de709a0b..51fe8e8ec5 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -34,7 +34,6 @@ #include "qemu/module.h" #include "io/channel-file.h" -static char temp_file[] = "/tmp/vmst.test.XXXXXX"; static int temp_fd; @@ -1487,6 +1486,7 @@ static void test_tmp_struct(void) int main(int argc, char **argv) { + g_autofree char *temp_file = g_strdup_printf("%s/vmst.test.XXXXXX", g_get_tmp_dir()); temp_fd = mkstemp(temp_file); module_call_init(MODULE_INIT_QOM);