| Message ID | 20210209153757.1653598-2-eperezma@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vDPA shadow virtqueue - notifications forwarding | expand |
On 2/9/21 9:37 AM, Eugenio Pérez wrote: > As error_setg points Incomplete sentence? Missing Signed-off-by. > --- > hw/virtio/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > index 6e17d631f7..1c5b442081 100644 > --- a/hw/virtio/vhost.c > +++ b/hw/virtio/vhost.c > @@ -1358,7 +1358,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque, > if (hdev->migration_blocker == NULL) { > if (!(hdev->features & (0x1ULL << VHOST_F_LOG_ALL))) { > error_setg(&hdev->migration_blocker, > - "Migration disabled: vhost lacks VHOST_F_LOG_ALL feature."); > + "Migration disabled: vhost lacks VHOST_F_LOG_ALL feature"); > } else if (vhost_dev_log_is_shared(hdev) && !qemu_memfd_alloc_check()) { > error_setg(&hdev->migration_blocker, > "Migration disabled: failed to allocate shared memory"); >
On Tue, Feb 9, 2021 at 5:25 PM Eric Blake <eblake@redhat.com> wrote: > > On 2/9/21 9:37 AM, Eugenio Pérez wrote: > > As error_setg points > > Incomplete sentence? > > Missing Signed-off-by. > Sorry, I should have paid more attention. Maybe it is better to send this though qemu-trivial, so it does not mess with this series? Thanks! > > --- > > hw/virtio/vhost.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > > index 6e17d631f7..1c5b442081 100644 > > --- a/hw/virtio/vhost.c > > +++ b/hw/virtio/vhost.c > > @@ -1358,7 +1358,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque, > > if (hdev->migration_blocker == NULL) { > > if (!(hdev->features & (0x1ULL << VHOST_F_LOG_ALL))) { > > error_setg(&hdev->migration_blocker, > > - "Migration disabled: vhost lacks VHOST_F_LOG_ALL feature."); > > + "Migration disabled: vhost lacks VHOST_F_LOG_ALL feature"); > > } else if (vhost_dev_log_is_shared(hdev) && !qemu_memfd_alloc_check()) { > > error_setg(&hdev->migration_blocker, > > "Migration disabled: failed to allocate shared memory"); > > > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qemu.org | libvirt.org >
On Tue, Feb 09, 2021 at 07:11:41PM +0100, Eugenio Perez Martin wrote: >On Tue, Feb 9, 2021 at 5:25 PM Eric Blake <eblake@redhat.com> wrote: >> >> On 2/9/21 9:37 AM, Eugenio Pérez wrote: >> > As error_setg points >> >> Incomplete sentence? >> >> Missing Signed-off-by. >> > >Sorry, I should have paid more attention. > >Maybe it is better to send this though qemu-trivial, so it does not >mess with this series? Yes, I agree that it can go regardless of this series. Thanks, Stefano
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 6e17d631f7..1c5b442081 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1358,7 +1358,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque, if (hdev->migration_blocker == NULL) { if (!(hdev->features & (0x1ULL << VHOST_F_LOG_ALL))) { error_setg(&hdev->migration_blocker, - "Migration disabled: vhost lacks VHOST_F_LOG_ALL feature."); + "Migration disabled: vhost lacks VHOST_F_LOG_ALL feature"); } else if (vhost_dev_log_is_shared(hdev) && !qemu_memfd_alloc_check()) { error_setg(&hdev->migration_blocker, "Migration disabled: failed to allocate shared memory");