Message ID | 20210222174757.2329740-3-david.edmondson@oracle.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=2ba2=HY=nongnu.org=qemu-devel-bounces+qemu-devel=archiver.kernel.org@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A00EC433DB for <qemu-devel@archiver.kernel.org>; Mon, 22 Feb 2021 17:50:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E510E6186A for <qemu-devel@archiver.kernel.org>; Mon, 22 Feb 2021 17:50:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E510E6186A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org>) id 1lEFLt-0002vW-18 for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 12:50:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <david.edmondson@oracle.com>) id 1lEFJb-00013N-VW; Mon, 22 Feb 2021 12:48:11 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:34386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <david.edmondson@oracle.com>) id 1lEFJZ-0001y2-5p; Mon, 22 Feb 2021 12:48:11 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11MHk3r6104226; Mon, 22 Feb 2021 17:48:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=jk2R58gq0UYjjMx2VkQKAlIeZKH8PUpycv1oXRGJIC8=; b=lpyjrJsubpIU5OpfM/22KD4YLbZkBc6ItWcktCpXfiHatP0ii4RXo7KTXIfg252zE93u OnjxnV1qQFiAD6x6nosge5hnHSPOMwhkQeaCGYjf/zcnmV4Akz7OEP3eCRgvZfhiRcfb 7+wdFSrmHv5AooqMEgUWl5AP1sdxe7/kK+uT5kFzqLXM5ng0wd6Ihu/5kLmZqO+oBaT5 CDwVahAIUWSAndsAw0kmPVtW23v1l1v9PtOLNSSXx+elBycWcINtcqd5trDPVlweW2bl E3amEtZE1yUm7Sinvzw/p127rIb5qxXUgUtFWWMbux4J+J6KkYMtQAzxgYFAD9KuarEE Sw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 36tsuqvj2m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Feb 2021 17:48:07 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11MHkPu8106492; Mon, 22 Feb 2021 17:48:07 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by userp3030.oracle.com with ESMTP id 36ucbwdp2k-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Feb 2021 17:48:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=geVJfkoYPoBz1oC0kg4ViheExqOpEAjL8tAliDaHzG9aqQlKEIZ8/SLggE4CPPYQIXZBPYdnv9FWZgVoddMJdcE1uJqYhVydxL2XbwrUn23amTq3i+PsyKrIe5Yjug5FJFlz/wBTXgalB4xzvJS2QEP97Z8Y246VhcgmZU3sult7lKVb34cH2Tnfxgzrr6C21NryPovvYH13R2o8SyTB/OVME+ew/boxfXYDGY1BhHo2SVeRGjue8VbcQ9AYhDqZ+DYdnFmUG0TCl7EwahoI4GtSvVIzXh5HO+8caVnkxQaCAvTLlV8OcNazfny+T5vstqvHXmWANNRUjFk+Q/fdjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jk2R58gq0UYjjMx2VkQKAlIeZKH8PUpycv1oXRGJIC8=; b=Mmyn25DL5PIFTgJMSTlUO/u7BB3Y2zXwxDj6QqZlsAiKS/vgExjvKTyVYfmbKe1m93uQgWLNdAbVwNV2+J8+aZwBn0UdocXFxUjUKEjUHWxdOfCmh+a4dElM5p8QYbHLB3HmGHjsv2P3AZ9d9LlhRDE2rPVIxOiNXMsHIMivrQF3Vyr9rwS/oDY0KHo0H3MBhGlDu21jk+SuKsljsBVnfF1NnY7CoBKjc+ap+2x5p2ouDV0vR9UqKGicOXISp5d7/OJ/XpvRVQfTjf8O9Vkq23UFRQwe0wcFHVj6hiCJd7zMpEZZMt1dx6g6eKbblOZBl8I5FVx0ab+yXdH0Kj12RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jk2R58gq0UYjjMx2VkQKAlIeZKH8PUpycv1oXRGJIC8=; b=sWJj/3nsRS7PnW4BicCgUiNf/xaY1/6nGzEIIkJhWOSSpcjw9T5g1Cvwu2SG4wqpW0j0K9oNXyCT8fTr+pF6fI/v2bOW95lRhV+asH6e1mv0Y1CjmlaCLo5qaUbqS6k8fsB9sBNpH5w4iiJbSpja5t/Jb2tkhlC2ZwTR0iVC8KA= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=oracle.com; Received: from DM6PR10MB3148.namprd10.prod.outlook.com (2603:10b6:5:1a4::21) by DM6PR10MB3466.namprd10.prod.outlook.com (2603:10b6:5:17e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.31; Mon, 22 Feb 2021 17:48:05 +0000 Received: from DM6PR10MB3148.namprd10.prod.outlook.com ([fe80::f871:5965:2081:3934]) by DM6PR10MB3148.namprd10.prod.outlook.com ([fe80::f871:5965:2081:3934%5]) with mapi id 15.20.3868.033; Mon, 22 Feb 2021 17:48:05 +0000 From: David Edmondson <david.edmondson@oracle.com> To: qemu-devel@nongnu.org Subject: [RFC PATCH v3 2/3] hw/pflash_cfi01: Correct the type of PFlashCFI01.ro Date: Mon, 22 Feb 2021 17:47:56 +0000 Message-Id: <20210222174757.2329740-3-david.edmondson@oracle.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210222174757.2329740-1-david.edmondson@oracle.com> References: <20210222174757.2329740-1-david.edmondson@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [2001:8b0:bb71:7140:64::1] X-ClientProxiedBy: LO2P265CA0448.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::28) To DM6PR10MB3148.namprd10.prod.outlook.com (2603:10b6:5:1a4::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from disaster-area.hh.sledj.net (2001:8b0:bb71:7140:64::1) by LO2P265CA0448.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.31 via Frontend Transport; Mon, 22 Feb 2021 17:48:04 +0000 Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id ea7c68c5; Mon, 22 Feb 2021 17:47:57 +0000 (UTC) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 11dcd2ab-7edc-439c-304e-08d8d75a01c9 X-MS-TrafficTypeDiagnostic: DM6PR10MB3466: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <DM6PR10MB3466424C6FD1A43024E3BD9B88819@DM6PR10MB3466.namprd10.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:2582; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HBQIlCJ26vg9b3zTUJrToBCK4yRlk4D/9uPwBkgpO3yfSP14RH8ffoEDOBX9tSDiWbfKkhc+eninjJHM+qlKiCoZ7tpYt9iA/NKx0DvxFh1LHsH8KoScYvYHcdbftvRuE1xeU1SnbXd114l0aPeeJAoxkaHkdDU9i52kn+diihlrNQjr9f0LHvPTXvPE3XqNLFi65IM6CtnlD1au+kWrDJOPVaz6FJlXjuscV5lCwvew897vF52MJVJF8IWymgw3O04cOptoN95Nxo1RZNakT6focwrzJYfB5RQ+KBaMUe4z0+XMHf5GBrb4LoTM0c5k8TKXV7IsDVE17QbUw0yknSmQi5HGrGbvoH68xmAClI+nGxHBGzaUk+72PbnTtWR6PxgronvSgZt6+9zzLpS7BEN9d83j1n6JdAWhGXO+m+bscUsleYK7vr+jlDtR0WneiXreqtok5Cg+cpaHH3+E5m6zbxwcs9eiVNUMZQBUMJESVnaqaoMHjtdVWsZzmXdHjSWY73mW9NbVj5uRwSCPig== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR10MB3148.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(136003)(346002)(366004)(39860400002)(376002)(54906003)(478600001)(44832011)(316002)(83380400001)(52116002)(86362001)(186003)(66946007)(66476007)(66556008)(36756003)(8936002)(107886003)(4326008)(5660300002)(2616005)(4744005)(1076003)(8676002)(2906002)(6916009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?3qR671tQjBO2c7vU4ZlEdFE3lIcmwa?= =?utf-8?q?6ssCE88BeCtwq5gA6YUcguIXw8Bek3d+7OBqCr7FwVOVGQL1Z8WPIJ69GqWsXWAK5?= =?utf-8?q?MQ7pbxmtMHeYuslDX9LWaDtB3yRvhKsMplo4omhRZJ/xmGhd6HMVdKbFQ2Mru+hIf?= =?utf-8?q?Mt+aHliPondc+3UBk9TRF5tu8+xBZyJ4yAQZhQ4GdM3wytGNFBle22I8z8nFk1JW4?= =?utf-8?q?AC1qG7tfVyyaVw9wZmdL+J0IHYBxgwiSmw4q1frfAsUt7mfwXGRyR0dMjU93HwY+q?= =?utf-8?q?sKqyQIXGr/M0yrKLo4DbYPLoSbeNB6GhGyA7bjtWeoxBagGOdeZi/WR5gadau6H8g?= =?utf-8?q?lM8kES9ikYiRDS/PuqNTU65srpz+WShkSj38P9ASVIpQcaIpGt2nj5rcsEpGJFZhJ?= =?utf-8?q?AOTlCJ86cf5r5WvAEJ98eRr6iEAwZgALhsPEpwuI8aH5Rf/r8fG3gryrzYVBkBYXp?= =?utf-8?q?5W6dTrcJAdafSaCfM4CSFN6IJZ6Tb26buQWAZ7IiS4V9Q6AHyHqSqTajJk88mfPdX?= =?utf-8?q?HK5V3Mx41WFn4HWZ15DMUXzOBeZVBWQZpciSD7KHmoiyL9hwPgULSC0QWAKGzYOQm?= =?utf-8?q?xIDOlf0m6ufFPGOM8NPxcJ+EHSig3+Zgk/woV2OOsS3AKtaCE+/aK4PRKrVyXNuc7?= =?utf-8?q?dWYcGxt7AIuThImSHg1/9Gtk87VPQKPKrzbexUM09L7Av2mHSuQ2FwsHNf0kDui6y?= =?utf-8?q?xapjKT4ePSWzD5nxSK6wEPc3afmc+njrTlc4WshiufPY6oI7fTDMD2GB/x7XlsU9o?= =?utf-8?q?XkbeQcgaAOM4XNju6f7tyKmGftp3PkGuzv3F8Ows6Kj32zwRuzdHOtgPeoCeLD5zh?= =?utf-8?q?TtnViPyp7cfKtfuilGLxk2XgTQ/dncbrGyYJhew0xnK7PIwDF8Kl734NEhlxiWa3L?= =?utf-8?q?vln4KTN4EsJJrIzowkpTWgDO+CaCHvKG6WwRisbvoJZzj40k+xnxuemomBBENgHBR?= =?utf-8?q?q2X+JxmmHxE8J9c07dIjJFCZylUjQqNnPmX5UUHSgR4WeliuCcJ5id4O0A8MnHAK/?= =?utf-8?q?pbP6I+IoNIIbyDGGtd5XUZuGP/VjQ3bncTHg/vDr5A3718YaPI+zKVns9fBePT0x6?= =?utf-8?q?vgX8V6CanmtJhC0VthiZdQkMLo5CBzeE1vHme06JeJ365OUeDM/63yW5Aug2+gjpT?= =?utf-8?q?mRgpVSB/MpDsM2cvaUpxia99c2Ab2sAlCPzzZoTug1AksZYoZlyjKtDfC6MS/l5bQ?= =?utf-8?q?xi2DsKZCM+0ue7it6AzrcAmaNAbdqIBAaQnF/BXhB7/5OZnlfFp1EZQPWlhtziThh?= =?utf-8?q?Y9uxzEWiYpw6+HouMuk9c4Qx76fj7tKvb7Zg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11dcd2ab-7edc-439c-304e-08d8d75a01c9 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3148.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2021 17:48:05.2794 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AgE2s7zXSpfe2c5cdPJ70Y2W95L9XtNZG/cNUQbwn8zXwbgOgLvkYvYC34mrdw1ZOyG93sAMiUH0SCmt4RDX9K03Koo4U5AxjTT/PZ00ing= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3466 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9903 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102220158 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9903 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 mlxscore=0 malwarescore=0 clxscore=1015 phishscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102220158 Received-SPF: pass client-ip=156.151.31.86; envelope-from=david.edmondson@oracle.com; helo=userp2130.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Kevin Wolf <kwolf@redhat.com>, David Edmondson <david.edmondson@oracle.com>, =?utf-8?q?Philippe_Mathieu-Da?= =?utf-8?q?ud=C3=A9?= <philmd@redhat.com>, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> |
Series |
hw/flash_cfi01: Reduce memory consumption when flash image is smaller than region
|
expand
|
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 9e1f3b42c6..6b21b4af52 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -72,7 +72,7 @@ struct PFlashCFI01 { uint8_t max_device_width; /* max device width in bytes */ uint32_t features; uint8_t wcycle; /* if 0, the flash is read normally */ - int ro; + bool ro; uint8_t cmd; uint8_t status; uint16_t ident0; @@ -738,7 +738,7 @@ static void pflash_cfi01_realize(DeviceState *dev, Error **errp) return; } } else { - pfl->ro = 0; + pfl->ro = false; } if (pfl->blk) {