diff mbox series

[2/2] docs/system/arm: Add quanta-gbs-bmc reference

Message ID 20210615192848.1065297-3-venture@google.com (mailing list archive)
State New, archived
Headers show
Series Updates docs/system/arm to include new bmc machines | expand

Commit Message

Patrick Leis June 15, 2021, 7:28 p.m. UTC
Add line item reference to quanta-gbs-bmc machine.

Signed-off-by: Patrick Venture <venture@google.com>
---
 docs/system/arm/nuvoton.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Cédric Le Goater June 16, 2021, 9:05 a.m. UTC | #1
On 6/15/21 9:28 PM, Patrick Venture wrote:
> Add line item reference to quanta-gbs-bmc machine.
> 
> Signed-off-by: Patrick Venture <venture@google.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>  docs/system/arm/nuvoton.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/system/arm/nuvoton.rst b/docs/system/arm/nuvoton.rst
> index ca011bd479..197d149f66 100644
> --- a/docs/system/arm/nuvoton.rst
> +++ b/docs/system/arm/nuvoton.rst
> @@ -1,4 +1,4 @@
> -Nuvoton iBMC boards (``npcm750-evb``, ``quanta-gsj``)
> +Nuvoton iBMC boards (``*-bmc``, ``npcm750-evb``, ``quanta-gsj``)
>  =====================================================
>  
>  The `Nuvoton iBMC`_ chips (NPCM7xx) are a family of ARM-based SoCs that are
> @@ -18,6 +18,7 @@ segment. The following machines are based on this chip :
>  The NPCM730 SoC has two Cortex-A9 cores and is targeted for Data Center and
>  Hyperscale applications. The following machines are based on this chip :
>  
> +- ``quanta-gbs-bmc``    Quanta GBS server BMC
>  - ``quanta-gsj``        Quanta GSJ server BMC
>  
>  There are also two more SoCs, NPCM710 and NPCM705, which are single-core
>
Peter Maydell June 21, 2021, 1:31 p.m. UTC | #2
On Tue, 15 Jun 2021 at 20:29, Patrick Venture <venture@google.com> wrote:
>
> Add line item reference to quanta-gbs-bmc machine.
>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
>  docs/system/arm/nuvoton.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/docs/system/arm/nuvoton.rst b/docs/system/arm/nuvoton.rst
> index ca011bd479..197d149f66 100644
> --- a/docs/system/arm/nuvoton.rst
> +++ b/docs/system/arm/nuvoton.rst
> @@ -1,4 +1,4 @@
> -Nuvoton iBMC boards (``npcm750-evb``, ``quanta-gsj``)
> +Nuvoton iBMC boards (``*-bmc``, ``npcm750-evb``, ``quanta-gsj``)
>  =====================================================
>
>  The `Nuvoton iBMC`_ chips (NPCM7xx) are a family of ARM-based SoCs that are
> @@ -18,6 +18,7 @@ segment. The following machines are based on this chip :
>  The NPCM730 SoC has two Cortex-A9 cores and is targeted for Data Center and
>  Hyperscale applications. The following machines are based on this chip :
>
> +- ``quanta-gbs-bmc``    Quanta GBS server BMC
>  - ``quanta-gsj``        Quanta GSJ server BMC

Why aren't we consistent about the names of the machines here?
This suggests that either we should have called the new board
'quanta-gbs', not 'quanta-gbs-bmc', or we should deprecate
'quanta-gsj' and rename it 'quanta-gsj-bmc' ...

thanks
-- PMM
Cédric Le Goater June 22, 2021, 8:53 a.m. UTC | #3
On 6/21/21 3:31 PM, Peter Maydell wrote:
> On Tue, 15 Jun 2021 at 20:29, Patrick Venture <venture@google.com> wrote:
>>
>> Add line item reference to quanta-gbs-bmc machine.
>>
>> Signed-off-by: Patrick Venture <venture@google.com>
>> ---
>>  docs/system/arm/nuvoton.rst | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/system/arm/nuvoton.rst b/docs/system/arm/nuvoton.rst
>> index ca011bd479..197d149f66 100644
>> --- a/docs/system/arm/nuvoton.rst
>> +++ b/docs/system/arm/nuvoton.rst
>> @@ -1,4 +1,4 @@
>> -Nuvoton iBMC boards (``npcm750-evb``, ``quanta-gsj``)
>> +Nuvoton iBMC boards (``*-bmc``, ``npcm750-evb``, ``quanta-gsj``)
>>  =====================================================
>>
>>  The `Nuvoton iBMC`_ chips (NPCM7xx) are a family of ARM-based SoCs that are
>> @@ -18,6 +18,7 @@ segment. The following machines are based on this chip :
>>  The NPCM730 SoC has two Cortex-A9 cores and is targeted for Data Center and
>>  Hyperscale applications. The following machines are based on this chip :
>>
>> +- ``quanta-gbs-bmc``    Quanta GBS server BMC
>>  - ``quanta-gsj``        Quanta GSJ server BMC
> 
> Why aren't we consistent about the names of the machines here?
> This suggests that either we should have called the new board
> 'quanta-gbs', not 'quanta-gbs-bmc', or we should deprecate
> 'quanta-gsj' and rename it 'quanta-gsj-bmc' ...

Indeed, the latter would be the best option. 

Thanks,

C.
diff mbox series

Patch

diff --git a/docs/system/arm/nuvoton.rst b/docs/system/arm/nuvoton.rst
index ca011bd479..197d149f66 100644
--- a/docs/system/arm/nuvoton.rst
+++ b/docs/system/arm/nuvoton.rst
@@ -1,4 +1,4 @@ 
-Nuvoton iBMC boards (``npcm750-evb``, ``quanta-gsj``)
+Nuvoton iBMC boards (``*-bmc``, ``npcm750-evb``, ``quanta-gsj``)
 =====================================================
 
 The `Nuvoton iBMC`_ chips (NPCM7xx) are a family of ARM-based SoCs that are
@@ -18,6 +18,7 @@  segment. The following machines are based on this chip :
 The NPCM730 SoC has two Cortex-A9 cores and is targeted for Data Center and
 Hyperscale applications. The following machines are based on this chip :
 
+- ``quanta-gbs-bmc``    Quanta GBS server BMC
 - ``quanta-gsj``        Quanta GSJ server BMC
 
 There are also two more SoCs, NPCM710 and NPCM705, which are single-core