| Message ID | 20210617155247.442150-2-mreitz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: block-status cache for data regions | expand |
On Thu, Jun 17, 2021 at 05:52:42PM +0200, Max Reitz wrote: > There is a comment above the BDS definition stating care must be taken > to consider handling newly added fields in bdrv_append(). > > Actually, this comment should have said "bdrv_swap()" as of 4ddc07cac > (nine years ago), and in any case, bdrv_swap() was dropped in > 8e419aefa (six years ago). So no such care is necessary anymore. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > include/block/block_int.h | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
17.06.2021 18:52, Max Reitz wrote: > There is a comment above the BDS definition stating care must be taken > to consider handling newly added fields in bdrv_append(). > > Actually, this comment should have said "bdrv_swap()" as of 4ddc07cac > (nine years ago), and in any case, bdrv_swap() was dropped in > 8e419aefa (six years ago). So no such care is necessary anymore. > > Signed-off-by: Max Reitz<mreitz@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
diff --git a/include/block/block_int.h b/include/block/block_int.h index 057d88b1fc..a8f9598102 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -832,12 +832,6 @@ struct BdrvChild { QLIST_ENTRY(BdrvChild) next_parent; }; -/* - * Note: the function bdrv_append() copies and swaps contents of - * BlockDriverStates, so if you add new fields to this struct, please - * inspect bdrv_append() to determine if the new fields need to be - * copied as well. - */ struct BlockDriverState { /* Protected by big QEMU lock or read-only after opening. No special * locking needed during I/O...
There is a comment above the BDS definition stating care must be taken to consider handling newly added fields in bdrv_append(). Actually, this comment should have said "bdrv_swap()" as of 4ddc07cac (nine years ago), and in any case, bdrv_swap() was dropped in 8e419aefa (six years ago). So no such care is necessary anymore. Signed-off-by: Max Reitz <mreitz@redhat.com> --- include/block/block_int.h | 6 ------ 1 file changed, 6 deletions(-)