| Message ID | 20210629141931.4489-10-acho@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x cleanup | expand |
On 29/06/2021 16.19, Cho, Yu-Chen wrote: > Now that we have moved cpu-dump functionality out of helper.c, > we can make the module sysemu-only. > > Signed-off-by: Claudio Fontana <cfontana@suse.de> > Signed-off-by: Cho, Yu-Chen <acho@suse.com> > Acked-by: Cornelia Huck <cohuck@redhat.com> > --- > target/s390x/helper.c | 9 +-------- > target/s390x/meson.build | 2 +- > 2 files changed, 2 insertions(+), 9 deletions(-) > > diff --git a/target/s390x/helper.c b/target/s390x/helper.c > index c72e990f4d..a4d4665f67 100644 > --- a/target/s390x/helper.c > +++ b/target/s390x/helper.c > @@ -1,5 +1,5 @@ > /* > - * S/390 helpers > + * S/390 helpers - systemu only s/systemu/sysemu/ With that typo fixed: Reviewed-by: Thomas Huth <thuth@redhat.com>
On Thu, 2021-07-01 at 14:36 +0200, Thomas Huth wrote: > On 29/06/2021 16.19, Cho, Yu-Chen wrote: > > Now that we have moved cpu-dump functionality out of helper.c, > > we can make the module sysemu-only. > > > > Signed-off-by: Claudio Fontana <cfontana@suse.de> > > Signed-off-by: Cho, Yu-Chen <acho@suse.com> > > Acked-by: Cornelia Huck <cohuck@redhat.com> > > --- > > target/s390x/helper.c | 9 +-------- > > target/s390x/meson.build | 2 +- > > 2 files changed, 2 insertions(+), 9 deletions(-) > > > > diff --git a/target/s390x/helper.c b/target/s390x/helper.c > > index c72e990f4d..a4d4665f67 100644 > > --- a/target/s390x/helper.c > > +++ b/target/s390x/helper.c > > @@ -1,5 +1,5 @@ > > /* > > - * S/390 helpers > > + * S/390 helpers - systemu only > > s/systemu/sysemu/ > > With that typo fixed: > Reviewed-by: Thomas Huth <thuth@redhat.com> > That's a stupid mistake, it should be fixed this version. Will fix it. Thanks, AL
diff --git a/target/s390x/helper.c b/target/s390x/helper.c index c72e990f4d..a4d4665f67 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -1,5 +1,5 @@ /* - * S/390 helpers + * S/390 helpers - systemu only * * Copyright (c) 2009 Ulrich Hecht * Copyright (c) 2011 Alexander Graf @@ -27,11 +27,8 @@ #include "hw/s390x/pv.h" #include "sysemu/hw_accel.h" #include "sysemu/runstate.h" -#ifndef CONFIG_USER_ONLY #include "sysemu/tcg.h" -#endif -#ifndef CONFIG_USER_ONLY void s390x_tod_timer(void *opaque) { cpu_inject_clock_comparator((S390CPU *) opaque); @@ -284,7 +281,3 @@ int s390_store_adtl_status(S390CPU *cpu, hwaddr addr, hwaddr len) cpu_physical_memory_unmap(sa, len, 1, len); return 0; } -#else -/* For user-only, tcg is always enabled. */ -#define tcg_enabled() true -#endif /* CONFIG_USER_ONLY */ diff --git a/target/s390x/meson.build b/target/s390x/meson.build index 6e1aa3b0cd..bbcaede384 100644 --- a/target/s390x/meson.build +++ b/target/s390x/meson.build @@ -4,7 +4,6 @@ s390x_ss.add(files( 'cpu_features.c', 'cpu_models.c', 'gdbstub.c', - 'helper.c', 'interrupt.c', 'cpu-dump.c', )) @@ -23,6 +22,7 @@ s390x_ss.add(gen_features_h) s390x_softmmu_ss = ss.source_set() s390x_softmmu_ss.add(files( + 'helper.c', 'arch_dump.c', 'diag.c', 'ioinst.c',