mbox

[PULL,V3,for,6.2,0/6] COLO-Proxy patches for 2021-06-25

Message ID 20210719090051.3824672-1-chen.zhang@intel.com (mailing list archive)
State New, archived
Headers show

Pull-request

https://github.com/zhangckid/qemu.git master-colo-21jun25-pull-request-v3

Message

Zhang Chen July 19, 2021, 9 a.m. UTC 
Hi Jason,

Please help to queue COLO-proxy patches to net branch.

Thanks
Chen


The following changes since commit fd79f89c76c8e2f409dd9db5d7a367b1f64b6dc6:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210718' into staging (2021-07-18 13:46:39 +0100)

are available in the Git repository at:

  https://github.com/zhangckid/qemu.git master-colo-21jun25-pull-request-v3

for you to fetch changes up to 91176794e3a72c74b01e149638ac1a7e2dee73fc:

  net/net.c: Add handler for passthrough filter command (2021-07-19 16:50:44 +0800)


----------------------------------------------------------------

This series add passthrough support frame to object with network
processing function. The first object is colo-compare.

V3: Fix memory leak issue.

V2: Optimize HMP code from Dave's comment.

----------------------------------------------------------------
Zhang Chen (6):
      qapi/net: Add IPFlowSpec and QMP command for filter passthrough
      util/qemu-sockets.c: Add inet_parse_base to handle InetSocketAddressBase
      hmp-commands: Add new HMP command for filter passthrough
      net/colo-compare: Move data structure and define to .h file.
      net/colo-compare: Add passthrough list to CompareState
      net/net.c: Add handler for passthrough filter command

 hmp-commands.hx        |  26 ++++++++
 include/monitor/hmp.h  |   2 +
 include/qemu/sockets.h |   1 +
 monitor/hmp-cmds.c     |  63 +++++++++++++++++++
 net/colo-compare.c     | 160 ++++++++++++++++--------------------------------
 net/colo-compare.h     |  98 ++++++++++++++++++++++++++++++
 net/net.c              | 205 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 qapi/net.json          |  78 ++++++++++++++++++++++++
 util/qemu-sockets.c    |  14 +++++
 9 files changed, 538 insertions(+), 109 deletions(-)

Comments

Peter Maydell July 19, 2021, 9:19 a.m. UTC | #1 
On Mon, 19 Jul 2021 at 10:10, Zhang Chen <chen.zhang@intel.com> wrote:
>
> Hi Jason,
>
> Please help to queue COLO-proxy patches to net branch.

Hi Chen; for this kind of pull request that isn't intended
to go directly into master, could I ask you to follow the notes
in https://wiki.qemu.org/Contribute/SubmitAPullRequest
for not-for-master pullrequests, please?

# Pull requests not for master should say "not for master" and have
# "PULL SUBSYSTEM whatever" in the subject tag. If your pull request
# is targeting a stable branch or some submaintainer tree, please
# include the string "not for master" in the cover letter email, and
# make sure the subject tag is "PULL SUBSYSTEM s390/block/whatever"
# rather than just "PULL". This allows it to be automatically filtered
# out of the set of pull requests that should be applied to master.

It's not a big deal, but if you put the right tags in your email
then my filtering will automatically ignore it for me :-)

thanks
-- PMM
Zhang Chen July 19, 2021, 1:28 p.m. UTC | #2 
> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Monday, July 19, 2021 5:19 PM
> To: Zhang, Chen <chen.zhang@intel.com>
> Cc: Jason Wang <jasowang@redhat.com>; Eric Blake <eblake@redhat.com>;
> Dr. David Alan Gilbert <dgilbert@redhat.com>; Markus Armbruster
> <armbru@redhat.com>; Lukas Straub <lukasstraub2@web.de>; Daniel P.
> Berrangé <berrange@redhat.com>; Li Zhijian <lizhijian@cn.fujitsu.com>;
> qemu-dev <qemu-devel@nongnu.org>; Gerd Hoffmann
> <kraxel@redhat.com>
> Subject: Re: [PULL V3 for 6.2 0/6] COLO-Proxy patches for 2021-06-25
> 
> On Mon, 19 Jul 2021 at 10:10, Zhang Chen <chen.zhang@intel.com> wrote:
> >
> > Hi Jason,
> >
> > Please help to queue COLO-proxy patches to net branch.
> 
> Hi Chen; for this kind of pull request that isn't intended to go directly into
> master, could I ask you to follow the notes in
> https://wiki.qemu.org/Contribute/SubmitAPullRequest
> for not-for-master pullrequests, please?
> 
> # Pull requests not for master should say "not for master" and have # "PULL
> SUBSYSTEM whatever" in the subject tag. If your pull request # is targeting a
> stable branch or some submaintainer tree, please # include the string "not
> for master" in the cover letter email, and # make sure the subject tag is
> "PULL SUBSYSTEM s390/block/whatever"
> # rather than just "PULL". This allows it to be automatically filtered # out of
> the set of pull requests that should be applied to master.
> 
> It's not a big deal, but if you put the right tags in your email then my filtering
> will automatically ignore it for me :-)

Thanks for reminding, I will add the "not for master" tag if have next version.

Thanks
Chen

> 
> thanks
> -- PMM
Jason Wang July 23, 2021, 2:49 a.m. UTC | #3 
在 2021/7/19 下午5:00, Zhang Chen 写道:
> Hi Jason,
>
> Please help to queue COLO-proxy patches to net branch.
>
> Thanks
> Chen
>

Queued for 6.2

Thanks


> The following changes since commit fd79f89c76c8e2f409dd9db5d7a367b1f64b6dc6:
>
>    Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210718' into staging (2021-07-18 13:46:39 +0100)
>
> are available in the Git repository at:
>
>    https://github.com/zhangckid/qemu.git master-colo-21jun25-pull-request-v3
>
> for you to fetch changes up to 91176794e3a72c74b01e149638ac1a7e2dee73fc:
>
>    net/net.c: Add handler for passthrough filter command (2021-07-19 16:50:44 +0800)
>
>
> ----------------------------------------------------------------
>
> This series add passthrough support frame to object with network
> processing function. The first object is colo-compare.
>
> V3: Fix memory leak issue.
>
> V2: Optimize HMP code from Dave's comment.
>
> ----------------------------------------------------------------
> Zhang Chen (6):
>        qapi/net: Add IPFlowSpec and QMP command for filter passthrough
>        util/qemu-sockets.c: Add inet_parse_base to handle InetSocketAddressBase
>        hmp-commands: Add new HMP command for filter passthrough
>        net/colo-compare: Move data structure and define to .h file.
>        net/colo-compare: Add passthrough list to CompareState
>        net/net.c: Add handler for passthrough filter command
>
>   hmp-commands.hx        |  26 ++++++++
>   include/monitor/hmp.h  |   2 +
>   include/qemu/sockets.h |   1 +
>   monitor/hmp-cmds.c     |  63 +++++++++++++++++++
>   net/colo-compare.c     | 160 ++++++++++++++++--------------------------------
>   net/colo-compare.h     |  98 ++++++++++++++++++++++++++++++
>   net/net.c              | 205 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   qapi/net.json          |  78 ++++++++++++++++++++++++
>   util/qemu-sockets.c    |  14 +++++
>   9 files changed, 538 insertions(+), 109 deletions(-)
>