diff mbox series

[2/2] Acceptance Tests: updates to the MAINTAINERS file

Message ID 20210803193447.3946219-3-crosa@redhat.com (mailing list archive)
State New, archived
Headers show
Series Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry | expand

Commit Message

Cleber Rosa Aug. 3, 2021, 7:34 p.m. UTC
The tests/acceptance directory is currently lacking a maintainer
entry, even though I've been performing that role (of course with help
from many others).  Thus, its status is, even more now, Maintained.

This also removes the currently broken Trello board link, which was
make unavailable unintentionally by a third party.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Willian Rampazzo Aug. 3, 2021, 8:09 p.m. UTC | #1
On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> The tests/acceptance directory is currently lacking a maintainer
> entry, even though I've been performing that role (of course with help
> from many others).  Thus, its status is, even more now, Maintained.
>
> This also removes the currently broken Trello board link, which was
> make unavailable unintentionally by a third party.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  MAINTAINERS | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Philippe Mathieu-Daudé Aug. 4, 2021, 9:45 a.m. UTC | #2
On 8/3/21 10:09 PM, Willian Rampazzo wrote:
> On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote:
>>
>> The tests/acceptance directory is currently lacking a maintainer
>> entry, even though I've been performing that role (of course with help
>> from many others).  Thus, its status is, even more now, Maintained.
>>
>> This also removes the currently broken Trello board link, which was
>> make unavailable unintentionally by a third party.
>>
>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>> ---
>>  MAINTAINERS | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
> 
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>

Willian you could send an extra patch to add yourself a R: tag.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Willian Rampazzo Aug. 4, 2021, 1:49 p.m. UTC | #3
On Wed, Aug 4, 2021 at 6:45 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 8/3/21 10:09 PM, Willian Rampazzo wrote:
> > On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote:
> >>
> >> The tests/acceptance directory is currently lacking a maintainer
> >> entry, even though I've been performing that role (of course with help
> >> from many others).  Thus, its status is, even more now, Maintained.
> >>
> >> This also removes the currently broken Trello board link, which was
> >> make unavailable unintentionally by a third party.
> >>
> >> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> >> ---
> >>  MAINTAINERS | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >
> > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>
> Willian you could send an extra patch to add yourself a R: tag.

Ack!
Wainer dos Santos Moschetta Aug. 16, 2021, 5:59 p.m. UTC | #4
Hi,

On 8/3/21 4:34 PM, Cleber Rosa wrote:
> The tests/acceptance directory is currently lacking a maintainer
> entry, even though I've been performing that role (of course with help
> from many others).  Thus, its status is, even more now, Maintained.
yay!
>
> This also removes the currently broken Trello board link, which was
> make unavailable unintentionally by a third party.
I can still access the link. Anyway, maybe we could migrate the cards 
(not everything, just those which still make sense) to the GitLab's 
Issues tracker?
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   MAINTAINERS | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 37b1a8e442..d35b948e8d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile
>   F: tests/tcg/Makefile.include
>   
>   Acceptance (Integration) Testing with the Avocado framework
> -W: https://trello.com/b/6Qi1pxVn/avocado-qemu
> -R: Cleber Rosa <crosa@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
>   R: Philippe Mathieu-Daudé <philmd@redhat.com>
>   R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> -S: Odd Fixes
> +S: Maintained
> +F: tests/Makefile.include
>   F: tests/acceptance/
>   
>   Documentation
Thomas Huth Sept. 1, 2021, 1:49 p.m. UTC | #5
On 03/08/2021 21.34, Cleber Rosa wrote:
> The tests/acceptance directory is currently lacking a maintainer
> entry, even though I've been performing that role (of course with help
> from many others).  Thus, its status is, even more now, Maintained.
> 
> This also removes the currently broken Trello board link, which was
> make unavailable unintentionally by a third party.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   MAINTAINERS | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 37b1a8e442..d35b948e8d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile
>   F: tests/tcg/Makefile.include
>   
>   Acceptance (Integration) Testing with the Avocado framework
> -W: https://trello.com/b/6Qi1pxVn/avocado-qemu
> -R: Cleber Rosa <crosa@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
>   R: Philippe Mathieu-Daudé <philmd@redhat.com>
>   R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> -S: Odd Fixes
> +S: Maintained
> +F: tests/Makefile.include

Not sure whether we really should add tests/Makefile.include in this 
section, since there are only a couple of lines in there that are related to 
the "acceptance" tests... Anyway:

Acked-by: Thomas Huth <thuth@redhat.com>

Cleber, now that the freeze period is over, could you collect the related 
patches on the list and send a pull request?

  Thomas
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 37b1a8e442..d35b948e8d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3418,11 +3418,11 @@  F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
 
 Acceptance (Integration) Testing with the Avocado framework
-W: https://trello.com/b/6Qi1pxVn/avocado-qemu
-R: Cleber Rosa <crosa@redhat.com>
+M: Cleber Rosa <crosa@redhat.com>
 R: Philippe Mathieu-Daudé <philmd@redhat.com>
 R: Wainer dos Santos Moschetta <wainersm@redhat.com>
-S: Odd Fixes
+S: Maintained
+F: tests/Makefile.include
 F: tests/acceptance/
 
 Documentation