diff mbox series

[v3] hw/arm/Kconfig: no need to enable ACPI_MEMORY_HOTPLUG/ACPI_NVDIMM explicitly

Message ID 20210819162637.518507-1-ani@anisinha.ca (mailing list archive)
State New, archived
Headers show
Series [v3] hw/arm/Kconfig: no need to enable ACPI_MEMORY_HOTPLUG/ACPI_NVDIMM explicitly | expand

Commit Message

Ani Sinha Aug. 19, 2021, 4:26 p.m. UTC
Since commit
36b79e3219d ("hw/acpi/Kconfig: Add missing Kconfig dependencies (build error)"),
ACPI_MEMORY_HOTPLUG and ACPI_NVDIMM is implicitly turned on when
ACPI_HW_REDUCED is selected. ACPI_HW_REDUCED is already enabled. No need to
turn on ACPI_MEMORY_HOTPLUG or ACPI_NVDIMM explicitly. This is a minor cleanup.

Signed-off-by: Ani Sinha <ani@anisinha.ca>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/arm/Kconfig | 2 --
 1 file changed, 2 deletions(-)

changelog:
v1: initial patch
v2: commit log updated and ACPI_NVDIMM also removed from config.
v3: added missing parenthesis in commit message.

Comments

Peter Maydell Aug. 26, 2021, 1:20 p.m. UTC | #1
On Thu, 19 Aug 2021 at 17:26, Ani Sinha <ani@anisinha.ca> wrote:
>
> Since commit
> 36b79e3219d ("hw/acpi/Kconfig: Add missing Kconfig dependencies (build error)"),
> ACPI_MEMORY_HOTPLUG and ACPI_NVDIMM is implicitly turned on when
> ACPI_HW_REDUCED is selected. ACPI_HW_REDUCED is already enabled. No need to
> turn on ACPI_MEMORY_HOTPLUG or ACPI_NVDIMM explicitly. This is a minor cleanup.
>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



Applied to target-arm.next, thanks.

-- PMM
diff mbox series

Patch

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 4ba0aca067..dc050b5c37 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -25,9 +25,7 @@  config ARM_VIRT
     select ACPI_PCI
     select MEM_DEVICE
     select DIMM
-    select ACPI_MEMORY_HOTPLUG
     select ACPI_HW_REDUCED
-    select ACPI_NVDIMM
     select ACPI_APEI
 
 config CHEETAH